Bug 1621385 - Account for unaccesible tabs in mobile's WindowTracker.getAll. r=mixedpuppy

Differential Revision: https://phabricator.services.mozilla.com/D66310

--HG--
extra : moz-landing-system : lando

browser/components/extensions/parent/ext-browser.js

@@ -1221,13 +1221,6 @@ class WindowManager extends WindowManagerBase {
     return this.getWrapper(window);
   }
 
-  canAccessWindow(window, context) {
-    return (
-      (context && context.canAccessWindow(window)) ||
-      this.extension.canAccessWindow(window)
-    );
-  }
-
   *getAll(context) {
     for (let window of windowTracker.browserWindows()) {
       if (!this.canAccessWindow(window, context)) {

mobile/android/components/extensions/ext-utils.js

@@ -585,9 +585,15 @@ class WindowManager extends WindowManagerBase {
     return this.getWrapper(window);
   }
 
-  *getAll() {
+  *getAll(context) {
     for (let window of windowTracker.browserWindows()) {
-      yield this.getWrapper(window);
+      if (!this.canAccessWindow(window, context)) {
+        continue;
+      }
+      let wrapped = this.getWrapper(window);
+      if (wrapped) {
+        yield wrapped;
+      }
     }
   }
 

toolkit/components/extensions/parent/ext-tabs-base.js

@@ -2070,6 +2070,23 @@ class WindowManagerBase {
     }
   }
 
+  /**
+   * Returns whether this window can be accessed by the extension in the given
+   * context.
+   *
+   * @param {DOMWindow} window
+   *        The browser window that is being tested
+   * @param {BaseContext|null} context
+   *        The extension context for which this test is being performed.
+   * @returns {boolean}
+   */
+  canAccessWindow(window, context) {
+    return (
+      (context && context.canAccessWindow(window)) ||
+      this.extension.canAccessWindow(window)
+    );
+  }
+
   // The JSDoc validator does not support @returns tags in abstract functions or
   // star functions without return statements.
   /* eslint-disable valid-jsdoc */