Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-17 15:25:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1580403 - Clean up certviewer.ftl (localization comment, trailing spaces, duplicate string) r=johannh,Pike,fluent-reviewers

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D45487

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Francesco Lodolo (:flod) 2019-09-11 14:01:33 +00:00
parent 051674c0c7
commit bfeec26afc
3 changed files with 30 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
toolkit/components/certviewer/content/components/info-item.js
View File

@ -33,7 +33,15 @@ export class InfoItem extends HTMLElement {
render() {
let label = this.shadowRoot.querySelector("label");
let labelText = normalizeToKebabCase(this.item.label);
label.setAttribute("data-l10n-id", "certificate-viewer-" + labelText);
// Map specific elements to a different message ID, to allow updates to
// existing labels and avoid duplicates.
let stringMapping = {
signaturealgorithm: "signature-algorithm",
};
let fluentID = stringMapping[labelText] || labelText;
label.setAttribute("data-l10n-id", "certificate-viewer-" + fluentID);
this.classList.add(labelText);

6
toolkit/components/certviewer/tests/browser/browser_renderCertToUI.js
View File

@ -71,6 +71,10 @@ add_task(async function test() {
);
let i = 0;
// Message ID mappings
let stringMapping = {
signaturealgorithm: "signature-algorithm",
};
for (let infoItem of infoItems) {
let infoItemLabel = infoItem.shadowRoot
.querySelector("label")
@ -89,6 +93,8 @@ add_task(async function test() {
.replace(/\//g, "")
.replace(/--/g, "-")
.toLowerCase();
adjustedCertsElemLabel =
stringMapping[adjustedCertsElemLabel] || adjustedCertsElemLabel;
if (adjustedCertsElemInfo == null) {
adjustedCertsElemInfo = "";

35
toolkit/locales/en-US/toolkit/about/certviewer.ftl
View File

@ -2,10 +2,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
### This file is not in a locales directory to prevent it from
### being translated as the feature is still in heavy development
### and strings are likely to change often.
certificate-viewer-certificate-section-title = Certificate
## Error messages
@ -18,34 +14,34 @@ certificate-viewer-error-title = Something went wrong.
certificate-viewer-algorithm = Algorithm
certificate-viewer-certificate-authority = Certificate Authority
certificate-viewer-cipher-suite = Cipher Suite
certificate-viewer-common-name = Common Name
certificate-viewer-common-name = Common Name
# Inc. means Incorporated, e.g GitHub is incorporated in Delaware
certificate-viewer-inc-country = Inc. Country
certificate-viewer-country = Country
certificate-viewer-curve = Curve
certificate-viewer-inc-country = Inc. Country
certificate-viewer-country = Country
certificate-viewer-curve = Curve
certificate-viewer-distribution-point = Distribution Point
certificate-viewer-dns-name = DNS Name
certificate-viewer-exponent = Exponent
certificate-viewer-id = ID
certificate-viewer-exponent = Exponent
certificate-viewer-id = ID
certificate-viewer-key-exchange-group = Key Exchange Group
certificate-viewer-key-id = Key ID
certificate-viewer-key-size = Key Size
certificate-viewer-key-size = Key Size
certificate-viewer-locality = Locality
certificate-viewer-location = Location
certificate-viewer-logid = Log ID
certificate-viewer-logid = Log ID
certificate-viewer-method = Method
certificate-viewer-modulus = Modulus
certificate-viewer-name = Name
certificate-viewer-not-after = Not After
certificate-viewer-not-before = Not Before
certificate-viewer-name = Name
certificate-viewer-not-after = Not After
certificate-viewer-not-before = Not Before
certificate-viewer-organization = Organization
certificate-viewer-organizational-unit = Organizational Unit
certificate-viewer-policy = Policy
certificate-viewer-organizational-unit = Organizational Unit
certificate-viewer-policy = Policy
certificate-viewer-protocol = Protocol
certificate-viewer-public-value = Public Value
certificate-viewer-purposes = Purposes
certificate-viewer-qualifier = Qualifier
certificate-viewer-qualifiers = Qualifiers
certificate-viewer-qualifiers = Qualifiers
certificate-viewer-required = Required
# Inc. means Incorporated, e.g GitHub is incorporated in Delaware
certificate-viewer-inc-state-province = Inc. State/Province
@ -54,8 +50,7 @@ certificate-viewer-sha-1 = SHA-1
certificate-viewer-sha-256 = SHA-256
certificate-viewer-serial-number = Serial Number
certificate-viewer-signature-algorithm = Signature Algorithm
certificate-viewer-signaturealgorithm = Signature Algorithm
certificate-viewer-signature-scheme = Signature Scheme
certificate-viewer-signature-scheme = Signature Scheme
certificate-viewer-timestamp = Timestamp
certificate-viewer-value = Value
certificate-viewer-version = Version