Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 10:44:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1525134 - Remove remote url from browser_discovery_styles.js. r=andreio

Browse Source 
Before the other patch in this bug, list-style-image is the only image url that
made the list image request more lazily (during reflow and during
getComputedStyle).

This test was relying on the request being canceled soon enough that it didn't
crash the browser (we don't allow remote connections during tests).

I don't have a better idea than removing this test unfortunately. I've verified
that switching the test to use background-image or some other thing it makes the
request without my patch.

Differential Revision: https://phabricator.services.mozilla.com/D18732

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Emilio Cobos Álvarez 2019-02-05 19:47:27 +00:00
parent c48f274465
commit c072ec0173
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
browser/components/newtab/test/browser/browser_discovery_styles.js
View File

@ -66,8 +66,7 @@ test_newtab({
styles: {
"hr": `background-image: url(https://example.com/background);
content: url(chrome://browser/content);
cursor: url( resource://activity-stream/cursor ), auto;
list-style-image: url('https://img-getpocket.cdn.mozilla.net/list');`,
cursor: url( resource://activity-stream/cursor ), auto;`,
},
}],
}],
@ -79,7 +78,6 @@ test_newtab({
is(styles.backgroundImage, "none", "filtered out invalid background image url");
is(styles.content, `url("chrome://browser/content/browser.xul")`, "applied, normalized and allowed content url");
is(styles.cursor, `url("resource://activity-stream/cursor"), auto`, "applied, normalized and allowed cursor url");
is(styles.listStyleImage, `url("https://img-getpocket.cdn.mozilla.net/list")`, "applied, normalized and allowed list style image url");
},
});