Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-08 07:53:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 458158 - Crash [@ nsJAR::Open] when passing null argument to open method of zip-reader, r+sr=cbiesinger and r=jwalden+bmo

Browse Source
This commit is contained in:
Martijn Wargers 2009-01-22 16:12:00 +01:00
parent 47d464c3ce
commit c0fae0530d
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/libjar/nsJAR.cpp
View File

@ -168,6 +168,7 @@ nsrefcnt nsJAR::Release(void)
NS_IMETHODIMP
nsJAR::Open(nsIFile* zipFile)
{
NS_ENSURE_ARG_POINTER(zipFile);
if (mLock) return NS_ERROR_FAILURE; // Already open!
mZipFile = zipFile;

11
modules/libjar/test/unit/test_bug458158.js Normal file
View File

@ -0,0 +1,11 @@
function run_test() {
var zReader = Components.classes["@mozilla.org/libjar/zip-reader;1"]
.createInstance(Components.interfaces.nsIZipReader);
try {
zReader.open(null);
do_throw("Shouldn't get here!");
} catch (e if (e instanceof Components.interfaces.nsIException &&
e.result == Components.results.NS_ERROR_NULL_POINTER)) {
// do nothing, this test passes
}
}