Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-14 14:02:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add null check for options[0] to eliminate mochikit error.

Browse Source
This commit is contained in:
zach%zachlipton.com 2006-08-03 22:17:46 +00:00
parent ee6d5a0d06
commit c26797fc97
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
webtools/litmus/templates/en/default/admin/manage_testcases.tmpl
View File

@ -47,14 +47,19 @@ var showAllTests = function(err) {
} }
}; };
function splitIt(it) {
return it.split("\n");
}
var doFilterList = function(req) { var doFilterList = function(req) {
var tests = req.responseText.split("\n"); var tests = splitIt(req.responseText);
var testbox = document.getElementById("testcase_id"); var testbox = document.getElementById("testcase_id");
for (var i=0; i<testbox.options.length; i++) { var l = testbox.options.length;
var hideTest;
for (var i=0; i<l; i++) {
var test = testbox.options[i]; var test = testbox.options[i];
var hideTest = 0; if (tests.indexOf(test.value) == -1) { hideTest = 1; }
var id = test.value; else { hideTest=0 }
if (tests.indexOf(id) == -1) { hideTest = 1; }
hideTest == 1 ? test.style.display = 'none' : test.style.display = ''; hideTest == 1 ? test.style.display = 'none' : test.style.display = '';
} }
toggleMessage('none'); toggleMessage('none');
@ -70,9 +75,9 @@ function filterList() {
var testgroupfilter = document.getElementById('testgroup_filter'); var testgroupfilter = document.getElementById('testgroup_filter');
var subgroupfilter = document.getElementById('subgroup_filter'); var subgroupfilter = document.getElementById('subgroup_filter');
if (productfilter.options[productfilter.selectedIndex].value == '---' && if (productfilter.options[productfilter.selectedIndex].value == '' &&
testgroupfilter.options[testgroupfilter.selectedIndex].value == '---' && testgroupfilter.options[testgroupfilter.selectedIndex].value == '' &&
subgroupfilter.options[subgroupfilter.selectedIndex].value == '---') { subgroupfilter.options[subgroupfilter.selectedIndex].value == '') {
// nothing to do here // nothing to do here
showAllTests(); showAllTests();
return; return;
@ -154,7 +159,7 @@ function populateTestcase(data) {
options[i].selected = false; options[i].selected = false;
} }
} }
if (found_product == 0) { if (found_product == 0 && options[0]) {
options[0].selected = true; options[0].selected = true;
} }
changeProduct(); changeProduct();