Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 08:15:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1644288: Explicitly do not use timeDurationHelper when TaskController is enabled. r=smaug

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D78825
This commit is contained in:
Bas Schouten 2020-06-09 12:42:24 +00:00
parent 2f638f8699
commit c2dc5d2a40
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
xpcom/threads/nsThread.cpp
View File

@ -1139,13 +1139,13 @@ nsThread::ProcessNextEvent(bool aMayWait, bool* aResult) {
// Scope for |event| to make sure that its destructor fires while
// mNestedEventLoopDepth has been incremented, since that destructor can
// also do work.
// This value is only needed, and set, properly when not using
// TaskController. This will be removed once TaskController is enabled by
// default.
EventQueuePriority priority = EventQueuePriority::Normal;
nsCOMPtr<nsIRunnable> event;
bool usingTaskController = mIsMainThread && UseTaskController();
if (usingTaskController) {
// XXX should set priority? Maybe we can just grab the "last task"
// priority from the TaskController where we currently grab the
// "ranIdleTask" state?
event = TaskController::Get()->GetRunnableForMTTask(reallyWait);
} else {
event = mEvents->GetEvent(reallyWait, &priority, &mLastEventDelay);
@ -1218,14 +1218,13 @@ nsThread::ProcessNextEvent(bool aMayWait, bool* aResult) {
sMainThreadRunnableName[length] = '\0';
}
#endif
// Note, with TaskController InputTaskManager handles these updates.
Maybe<AutoTimeDurationHelper> timeDurationHelper;
if (priority == EventQueuePriority::InputHigh) {
timeDurationHelper.emplace();
}
Maybe<PerformanceCounterState::Snapshot> snapshot;
if (!usingTaskController) {
// Note, with TaskController InputTaskManager handles these updates.
if (priority == EventQueuePriority::InputHigh) {
timeDurationHelper.emplace();
}
snapshot.emplace(mPerformanceCounterState.RunnableWillRun(
GetPerformanceCounter(event), now,
priority == EventQueuePriority::Idle));