Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-18 07:45:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1166492 - Handle huge strings in the profile JSON writer. (r=mstange)

Browse Source
This commit is contained in:
Shu-yu Guo 2015-05-26 22:58:40 -07:00
parent 97501a00b6
commit c320562635
1 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tools/profiler/ProfileJSONWriter.h
View File

@ -25,29 +25,37 @@ class ChunkedJSONWriteFunc : public mozilla::JSONWriteFunc
mozilla::Vector<mozilla::UniquePtr<char[]>> mChunkList;
mozilla::Vector<size_t> mChunkLengths;
void AllocChunk() {
void AllocChunk(size_t aChunkSize) {
MOZ_ASSERT(mChunkLengths.length() == mChunkList.length());
mozilla::UniquePtr<char[]> newChunk = mozilla::MakeUnique<char[]>(kChunkSize);
mozilla::UniquePtr<char[]> newChunk = mozilla::MakeUnique<char[]>(aChunkSize);
mChunkPtr = newChunk.get();
mChunkEnd = mChunkPtr + kChunkSize;
mChunkEnd = mChunkPtr + aChunkSize;
MOZ_ALWAYS_TRUE(mChunkLengths.append(0));
MOZ_ALWAYS_TRUE(mChunkList.append(mozilla::Move(newChunk)));
}
public:
ChunkedJSONWriteFunc() {
AllocChunk();
AllocChunk(kChunkSize);
}
void Write(const char* aStr) override {
MOZ_ASSERT(strlen(aStr) < kChunkSize);
size_t len = strlen(aStr);
char* newPtr = mChunkPtr + len;
if (newPtr >= mChunkEnd) {
MOZ_ASSERT(*mChunkPtr == '\0');
AllocChunk();
// Most strings to be written are small, but subprocess profiles (e.g.,
// from the content process in e10s) may be huge. If the string is larger
// than a chunk, allocate its own chunk.
char* newPtr;
if (len >= kChunkSize) {
AllocChunk(len + 1);
newPtr = mChunkPtr + len;
} else {
newPtr = mChunkPtr + len;
if (newPtr >= mChunkEnd) {
MOZ_ASSERT(*mChunkPtr == '\0');
AllocChunk(kChunkSize);
newPtr = mChunkPtr + len;
}
}
memcpy(mChunkPtr, aStr, len);