Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 12:51:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1880535 - Enable ESLint recommended rules constructor-super, no-empty-static-block, no-new-native-nonconstructor. r=Gijs

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D202000
This commit is contained in:
Mark Banner 2024-02-20 22:09:21 +00:00
parent 68367dec11
commit c333f64e1c
3 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
security/.eslintrc.js
View File

@ -9,9 +9,6 @@ module.exports = {
// Enforce return statements in callbacks of array methods.
"array-callback-return": "error",
// Verify calls of super() in constructors.
"constructor-super": "error",
// Require default case in switch statements.
"default-case": "error",

3
taskcluster/docker/periodic-updates/.eslintrc.js
View File

@ -14,9 +14,6 @@ module.exports = {
// Enforce return statements in callbacks of array methods.
"array-callback-return": "error",
// Verify calls of super() in constructors.
"constructor-super": "error",
// Require default case in switch statements.
"default-case": "error",

20
tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js
View File

@ -18,6 +18,9 @@
* require-atomic-updates - bug 1551829.
* - This generates too many false positives that are not easy to work
* around, and false positives seem to be inherent in the rule.
* no-inner-declarations - bug 1487642
* - Would be interested if this could apply to just vars, but at the moment
* it doesn't.
*/
module.exports = {
env: {
@ -149,10 +152,6 @@ module.exports = {
// Functions must always return something or nothing
"consistent-return": "error",
// XXX This rule line should be removed to enable it. See bug 1487642.
// Require super() calls in constructors
"constructor-super": "off",
// Require braces around blocks that start a new line
curly: ["error", "all"],
@ -234,6 +233,11 @@ module.exports = {
// No empty statements
"no-empty": ["error", { allowEmptyCatch: true }],
// Disallow empty static blocks.
// This rule will be a recommended rule in ESLint v9 so may be removed
// when we upgrade to that.
"no-empty-static-block": "error",
// Disallow eval and setInteral/setTimeout with strings
"no-eval": "error",
@ -256,8 +260,7 @@ module.exports = {
// Disallow eval and setInteral/setTimeout with strings
"no-implied-eval": "error",
// This has been superseded since we're using ES6.
// Disallow variable or function declarations in nested blocks
// See explicit decisions at top of file.
"no-inner-declarations": "off",
// Disallow the use of the __iterator__ property
@ -275,6 +278,11 @@ module.exports = {
// Nested ternary statements are confusing
"no-nested-ternary": "error",
// Disallow new operators with global non-constructor functions.
// This rule will be a recommended rule in ESLint v9 so may be removed
// when we upgrade to that.
"no-new-native-nonconstructor": "error",
// Disallow use of new wrappers
"no-new-wrappers": "error",