Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-04 11:26:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

allow delete of a node that is not in the document tree. This is a no-op.

Browse Source
This commit is contained in:
buster%netscape.com 1999-04-20 17:40:15 +00:00
parent ced0729237
commit c3f43edd68
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
editor/base/DeleteElementTxn.cpp
View File

@ -59,7 +59,7 @@ NS_IMETHODIMP DeleteElementTxn::Do(void)
return result;
}
if (!mParent) {
return NS_ERROR_NULL_POINTER;
return NS_OK; // this is a no-op, there's no parent to delete mElement from
}
#ifdef NS_DEBUG
@ -98,8 +98,8 @@ NS_IMETHODIMP DeleteElementTxn::Do(void)
NS_IMETHODIMP DeleteElementTxn::Undo(void)
{
if (gNoisy) { printf("%p Undo Delete Element element = %p, parent = %p\n", this, mElement.get(), mParent.get()); }
if (!mParent || !mElement)
return NS_ERROR_NULL_POINTER;
if (!mParent) { return NS_OK; } // this is a legal state, the txn is a no-op
if (!mElement) { return NS_ERROR_NULL_POINTER; }
#ifdef NS_DEBUG
// begin debug output
@ -134,8 +134,8 @@ NS_IMETHODIMP DeleteElementTxn::Undo(void)
NS_IMETHODIMP DeleteElementTxn::Redo(void)
{
if (gNoisy) { printf("%p Redo Delete Element element = %p, parent = %p\n", this, mElement.get(), mParent.get()); }
if (!mParent || !mElement)
return NS_ERROR_NULL_POINTER;
if (!mParent) { return NS_OK; } // this is a legal state, the txn is a no-op
if (!mElement) { return NS_ERROR_NULL_POINTER; }
nsCOMPtr<nsIDOMNode> resultNode;
nsresult result = mParent->RemoveChild(mElement, getter_AddRefs(resultNode));

10
editor/libeditor/base/DeleteElementTxn.cpp
View File

@ -59,7 +59,7 @@ NS_IMETHODIMP DeleteElementTxn::Do(void)
return result;
}
if (!mParent) {
return NS_ERROR_NULL_POINTER;
return NS_OK; // this is a no-op, there's no parent to delete mElement from
}
#ifdef NS_DEBUG
@ -98,8 +98,8 @@ NS_IMETHODIMP DeleteElementTxn::Do(void)
NS_IMETHODIMP DeleteElementTxn::Undo(void)
{
if (gNoisy) { printf("%p Undo Delete Element element = %p, parent = %p\n", this, mElement.get(), mParent.get()); }
if (!mParent || !mElement)
return NS_ERROR_NULL_POINTER;
if (!mParent) { return NS_OK; } // this is a legal state, the txn is a no-op
if (!mElement) { return NS_ERROR_NULL_POINTER; }
#ifdef NS_DEBUG
// begin debug output
@ -134,8 +134,8 @@ NS_IMETHODIMP DeleteElementTxn::Undo(void)
NS_IMETHODIMP DeleteElementTxn::Redo(void)
{
if (gNoisy) { printf("%p Redo Delete Element element = %p, parent = %p\n", this, mElement.get(), mParent.get()); }
if (!mParent || !mElement)
return NS_ERROR_NULL_POINTER;
if (!mParent) { return NS_OK; } // this is a legal state, the txn is a no-op
if (!mElement) { return NS_ERROR_NULL_POINTER; }
nsCOMPtr<nsIDOMNode> resultNode;
nsresult result = mParent->RemoveChild(mElement, getter_AddRefs(resultNode));