Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-01 00:32:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 336210: No "Open (feed name)" item for home page with only one item in feed, patch by Phil Ringnalda <philringnalda@gmail.com>, r=ben

Browse Source
This commit is contained in:
gavin%gavinsharp.com 2006-05-11 21:39:12 +00:00
parent 32670b1600
commit c49978b0a8
1 changed files with 28 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
browser/base/content/browser-places.js
View File

@ -349,39 +349,48 @@ var BookmarksEventHandler = {
if (target.localName == "menupopup" && target.id != "bookmarksMenuPopup") {
// Show "Open in Tabs" menuitem if there are at least
// two menuitems with places result nodes.
// two menuitems with places result nodes, and "Open (Feed Name)"
// if it's a livemark with a siteURI.
var numNodes = 0;
var hasMultipleEntries = false;
var hasFeedHomePage = false;
var currentChild = target.firstChild;
while (currentChild && numNodes < 2) {
if (currentChild.node && currentChild.localName == "menuitem")
numNodes++;
currentChild = currentChild.nextSibling;
}
if (numNodes >= 2) {
if (numNodes > 1)
hasMultipleEntries = true;
var button = target.parentNode;
if (button.getAttribute("livemark") == "true" &&
button.hasAttribute("siteURI"))
hasFeedHomePage = true;
if (hasMultipleEntries || hasFeedHomePage) {
var separator = document.createElement("menuseparator");
target.appendChild(separator);
var strings = document.getElementById("placeBundle");
var button = target.parentNode;
if (button.getAttribute("livemark") == "true") {
// Live bookmarks aren't required to have site URIs
if (button.hasAttribute("siteURI")) {
var openHomePage = document.createElement("menuitem");
openHomePage.setAttribute(
"siteURI", button.getAttribute("siteURI"));
openHomePage.setAttribute(
"label",
strings.getFormattedString("menuOpenLivemarkOrigin.label",
[button.getAttribute("label")]));
target.appendChild(openHomePage);
}
if (hasFeedHomePage) {
var openHomePage = document.createElement("menuitem");
openHomePage.setAttribute(
"siteURI", button.getAttribute("siteURI"));
openHomePage.setAttribute(
"label",
strings.getFormattedString("menuOpenLivemarkOrigin.label",
[button.getAttribute("label")]));
target.appendChild(openHomePage);
}
var openInTabs = document.createElement("menuitem");
openInTabs.setAttribute("openInTabs", "true");
openInTabs.setAttribute("label", strings.getString("menuOpenInTabs.label"));
target.appendChild(openInTabs);
if (hasMultipleEntries) {
var openInTabs = document.createElement("menuitem");
openInTabs.setAttribute("openInTabs", "true");
openInTabs.setAttribute("label",
strings.getString("menuOpenInTabs.label"));
target.appendChild(openInTabs);
}
}
}
}