Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 04:41:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1931859 - Newtab ensure if Unified ads API is turned on and off, we keep the state and experience consistent. a=dmeehan

Browse Source 
Original Revision: https://phabricator.services.mozilla.com/D229341

Differential Revision: https://phabricator.services.mozilla.com/D229351
This commit is contained in:
scottdowne 2024-11-18 18:10:20 +00:00
parent 03da4417dd
commit c56abb8c0e
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
browser/components/newtab/lib/TelemetryFeed.sys.mjs
View File

@ -65,6 +65,7 @@ export const TELEMETRY_PREF = "telemetry";
export const EVENTS_TELEMETRY_PREF = "telemetry.ut.events";
export const PREF_UNIFIED_ADS_SPOCS_ENABLED = "unifiedAds.spocs.enabled";
export const PREF_UNIFIED_ADS_TILES_ENABLED = "unifiedAds.tiles.enabled";
const PREF_ENDPOINTS = "discoverystream.endpoints";
const PREF_SHOW_SPONSORED_STORIES = "showSponsored";
const PREF_SHOW_SPONSORED_TOPSITES = "showSponsoredTopSites";
@ -978,6 +979,14 @@ export class TelemetryFeed {
);
}
// Make sure the callback endpoint is allowed
const allowed = this._prefs.get(PREF_ENDPOINTS).split(",");
if (!allowed.some(prefix => data.url.startsWith(prefix))) {
throw new Error(
`[Unified ads callback] Not one of allowed prefixes (${allowed})`
);
}
const url = new URL(data.url);
url.searchParams.append("position", data.position);

1
browser/components/newtab/lib/TopSitesFeed.sys.mjs
View File

@ -2051,6 +2051,7 @@ export class TopSitesFeed {
this.refresh({ broadcast: true });
break;
case SHOW_SPONSORED_PREF:
case PREF_UNIFIED_ADS_TILES_ENABLED:
if (
lazy.NimbusFeatures.newtab.getVariable(
NIMBUS_VARIABLE_CONTILE_ENABLED