Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-02 22:37:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1433855 - Make sure plugin function broker's PostToDispatchThread is Waiting before Notifying it. r=jimm

Browse Source 
The Monitor's condition variable could be notified before the calling thread had begun to Wait for it.  This caused the Notify to be missed, leading to hangs.  By grabbing the Monitor in PostToDispatchHelper, we know Wait has been called because, otherwise, the calling thread would still hold the Monitor.
This commit is contained in:
David Parks 2018-01-30 17:32:27 -08:00
parent 67e80b725b
commit c6dc5f3406
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dom/plugins/ipc/FunctionBroker.h
View File

@ -1269,6 +1269,12 @@ protected:
// Note: p is also non-null... its just hard to assert that.
MOZ_ASSERT(bmhi && monitor && ok && winErr && r);
*ok = bmhi->BrokerCallClient(*winErr, *r, *p...);
{
// By grabbing (and freeing) the lock, we make sure that Wait() has been
// called in PostToDispatchThread. We need that since we wake it with
// Notify().
MonitorAutoLock lock(*monitor);
}
*ok &= NS_SUCCEEDED(monitor->Notify());
};