Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 956857 - Fix busted semantics for subject parameter in "xpcom-category-entry-removed" notification. r=bsmedberg

Browse Source
This commit is contained in:
Projjol Banerji 2014-01-29 17:07:35 -05:00
parent bb14671576
commit c779a76840
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xpcom/components/nsCategoryManager.cpp
View File

@ -659,7 +659,7 @@ nsCategoryManager::AddCategoryEntry(const char *aCategoryName,
if (NS_SUCCEEDED(rv)) {
if (oldEntry) {
NotifyObservers(NS_XPCOM_CATEGORY_ENTRY_REMOVED_OBSERVER_ID,
aCategoryName, oldEntry);
aCategoryName, aEntryName);
}
NotifyObservers(NS_XPCOM_CATEGORY_ENTRY_ADDED_OBSERVER_ID,
aCategoryName, aEntryName);

5
xpcom/tests/unit/test_bug374754.js
View File

@ -6,6 +6,7 @@ var removedTopic = "xpcom-category-entry-removed";
var testCategory = "bug-test-category";
var testEntry = "@mozilla.org/bug-test-entry;1";
var testValue= "check validity";
var result = "";
var expected = "add remove add remove ";
var timer;
@ -49,8 +50,8 @@ function run_test() {
observerService.addObserver(observer, removedTopic, false);
var categoryManager = Cc["@mozilla.org/categorymanager;1"].getService(Ci.nsICategoryManager);
categoryManager.addCategoryEntry(testCategory, testEntry, testEntry, false, true);
categoryManager.addCategoryEntry(testCategory, testEntry, testEntry, false, true);
categoryManager.addCategoryEntry(testCategory, testEntry, testValue, false, true);
categoryManager.addCategoryEntry(testCategory, testEntry, testValue, false, true);
categoryManager.deleteCategoryEntry(testCategory, testEntry, false);
timer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer);