mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-09 11:25:00 +00:00
Bug 956857 - Fix busted semantics for subject parameter in "xpcom-category-entry-removed" notification. r=bsmedberg
This commit is contained in:
parent
bb14671576
commit
c779a76840
@ -659,7 +659,7 @@ nsCategoryManager::AddCategoryEntry(const char *aCategoryName,
|
|||||||
if (NS_SUCCEEDED(rv)) {
|
if (NS_SUCCEEDED(rv)) {
|
||||||
if (oldEntry) {
|
if (oldEntry) {
|
||||||
NotifyObservers(NS_XPCOM_CATEGORY_ENTRY_REMOVED_OBSERVER_ID,
|
NotifyObservers(NS_XPCOM_CATEGORY_ENTRY_REMOVED_OBSERVER_ID,
|
||||||
aCategoryName, oldEntry);
|
aCategoryName, aEntryName);
|
||||||
}
|
}
|
||||||
NotifyObservers(NS_XPCOM_CATEGORY_ENTRY_ADDED_OBSERVER_ID,
|
NotifyObservers(NS_XPCOM_CATEGORY_ENTRY_ADDED_OBSERVER_ID,
|
||||||
aCategoryName, aEntryName);
|
aCategoryName, aEntryName);
|
||||||
|
@ -6,6 +6,7 @@ var removedTopic = "xpcom-category-entry-removed";
|
|||||||
var testCategory = "bug-test-category";
|
var testCategory = "bug-test-category";
|
||||||
var testEntry = "@mozilla.org/bug-test-entry;1";
|
var testEntry = "@mozilla.org/bug-test-entry;1";
|
||||||
|
|
||||||
|
var testValue= "check validity";
|
||||||
var result = "";
|
var result = "";
|
||||||
var expected = "add remove add remove ";
|
var expected = "add remove add remove ";
|
||||||
var timer;
|
var timer;
|
||||||
@ -49,8 +50,8 @@ function run_test() {
|
|||||||
observerService.addObserver(observer, removedTopic, false);
|
observerService.addObserver(observer, removedTopic, false);
|
||||||
|
|
||||||
var categoryManager = Cc["@mozilla.org/categorymanager;1"].getService(Ci.nsICategoryManager);
|
var categoryManager = Cc["@mozilla.org/categorymanager;1"].getService(Ci.nsICategoryManager);
|
||||||
categoryManager.addCategoryEntry(testCategory, testEntry, testEntry, false, true);
|
categoryManager.addCategoryEntry(testCategory, testEntry, testValue, false, true);
|
||||||
categoryManager.addCategoryEntry(testCategory, testEntry, testEntry, false, true);
|
categoryManager.addCategoryEntry(testCategory, testEntry, testValue, false, true);
|
||||||
categoryManager.deleteCategoryEntry(testCategory, testEntry, false);
|
categoryManager.deleteCategoryEntry(testCategory, testEntry, false);
|
||||||
|
|
||||||
timer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer);
|
timer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer);
|
||||||
|
Loading…
Reference in New Issue
Block a user