From c8698209af0e163e1a175afb354075dd94e59934 Mon Sep 17 00:00:00 2001 From: Malintha Fernando Date: Sat, 25 Jan 2014 17:12:20 +0100 Subject: [PATCH] Bug 953124 - [Australis] Remove the "Open Location" dialog (openLocation.xul). r=dao --- browser/base/content/browser.js | 14 +- browser/base/content/openLocation.js | 143 ------------------ browser/base/content/openLocation.xul | 57 ------- browser/base/content/sanitize.js | 8 - browser/base/jar.mn | 2 - .../privatebrowsing/test/browser/browser.ini | 2 - ...ser_privatebrowsing_openLocationLastURL.js | 63 -------- .../browser_privatebrowsing_openlocation.js | 100 ------------ .../en-US/chrome/browser/openLocation.dtd | 14 -- .../chrome/browser/openLocation.properties | 5 - browser/locales/jar.mn | 2 - browser/modules/moz.build | 1 - browser/modules/openLocationLastURL.jsm | 85 ----------- 13 files changed, 2 insertions(+), 494 deletions(-) delete mode 100644 browser/base/content/openLocation.js delete mode 100644 browser/base/content/openLocation.xul delete mode 100644 browser/components/privatebrowsing/test/browser/browser_privatebrowsing_openLocationLastURL.js delete mode 100644 browser/components/privatebrowsing/test/browser/browser_privatebrowsing_openlocation.js delete mode 100644 browser/locales/en-US/chrome/browser/openLocation.dtd delete mode 100644 browser/locales/en-US/chrome/browser/openLocation.properties delete mode 100644 browser/modules/openLocationLastURL.jsm diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js index 91e093a1661b..8f1a3477a49a 100644 --- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -1712,21 +1712,11 @@ function openLocation() { } else { // If there are no open browser windows, open a new one - win = window.openDialog("chrome://browser/content/", "_blank", - "chrome,all,dialog=no", BROWSER_NEW_TAB_URL); - win.addEventListener("load", openLocationCallback, false); + window.openDialog("chrome://browser/content/", "_blank", + "chrome,all,dialog=no", BROWSER_NEW_TAB_URL); } - return; } #endif - openDialog("chrome://browser/content/openLocation.xul", "_blank", - "chrome,modal,titlebar", window); -} - -function openLocationCallback() -{ - // make sure the DOM is ready - setTimeout(function() { this.openLocation(); }, 0); } function BrowserOpenTab() diff --git a/browser/base/content/openLocation.js b/browser/base/content/openLocation.js deleted file mode 100644 index 4ebcf29d1534..000000000000 --- a/browser/base/content/openLocation.js +++ /dev/null @@ -1,143 +0,0 @@ -/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ - -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ - -var browser; -var dialog = {}; -var pref = null; -let openLocationModule = {}; -try { - pref = Components.classes["@mozilla.org/preferences-service;1"] - .getService(Components.interfaces.nsIPrefBranch); -} catch (ex) { - // not critical, remain silent -} - -Components.utils.import("resource:///modules/openLocationLastURL.jsm", openLocationModule); -Components.utils.import("resource://gre/modules/Task.jsm"); -let gOpenLocationLastURL = new openLocationModule.OpenLocationLastURL(window.opener); - -function onLoad() -{ - dialog.input = document.getElementById("dialog.input"); - dialog.open = document.documentElement.getButton("accept"); - dialog.openWhereList = document.getElementById("openWhereList"); - dialog.openTopWindow = document.getElementById("currentWindow"); - dialog.bundle = document.getElementById("openLocationBundle"); - - if ("arguments" in window && window.arguments.length >= 1) - browser = window.arguments[0]; - - dialog.openWhereList.selectedItem = dialog.openTopWindow; - - if (pref) { - try { - var useAutoFill = pref.getBoolPref("browser.urlbar.autoFill"); - if (useAutoFill) - dialog.input.setAttribute("completedefaultindex", "true"); - } catch (ex) {} - - try { - var value = pref.getIntPref("general.open_location.last_window_choice"); - var element = dialog.openWhereList.getElementsByAttribute("value", value)[0]; - if (element) - dialog.openWhereList.selectedItem = element; - dialog.input.value = gOpenLocationLastURL.value; - } - catch(ex) { - } - if (dialog.input.value) - dialog.input.select(); // XXX should probably be done automatically - } - - doEnabling(); -} - -function doEnabling() -{ - dialog.open.disabled = !dialog.input.value; -} - -function open() -{ - Task.spawn(function() { - let url; - let postData = null; - let mayInheritPrincipal = false; - - if (browser) { - let data = yield browser.getShortcutOrURIAndPostData(dialog.input.value); - url = data.url; - postData = data.postData; - mayInheritPrincipal = data.mayInheritPrincipal; - } else { - url = dialog.input.value; - } - - try { - // Whichever target we use for the load, we allow third-party services to - // fixup the URI - switch (dialog.openWhereList.value) { - case "0": - var webNav = Components.interfaces.nsIWebNavigation; - var flags = webNav.LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP | - webNav.LOAD_FLAGS_FIXUP_SCHEME_TYPOS; - if (!mayInheritPrincipal) - flags |= webNav.LOAD_FLAGS_DISALLOW_INHERIT_OWNER; - browser.gBrowser.loadURIWithFlags(url, flags, null, null, postData); - break; - case "1": - window.opener.delayedOpenWindow(getBrowserURL(), "all,dialog=no", - url, postData, null, null, true); - break; - case "3": - browser.delayedOpenTab(url, null, null, postData, true); - break; - } - } - catch(exception) { - } - - if (pref) { - gOpenLocationLastURL.value = dialog.input.value; - pref.setIntPref("general.open_location.last_window_choice", dialog.openWhereList.value); - } - - // Delay closing slightly to avoid timing bug on Linux. - window.close(); - }); - - return false; -} - -function createInstance(contractid, iidName) -{ - var iid = Components.interfaces[iidName]; - return Components.classes[contractid].createInstance(iid); -} - -const nsIFilePicker = Components.interfaces.nsIFilePicker; -function onChooseFile() -{ - try { - let fp = Components.classes["@mozilla.org/filepicker;1"]. - createInstance(nsIFilePicker); - let fpCallback = function fpCallback_done(aResult) { - if (aResult == nsIFilePicker.returnOK && fp.fileURL.spec && - fp.fileURL.spec.length > 0) { - dialog.input.value = fp.fileURL.spec; - } - doEnabling(); - }; - - fp.init(window, dialog.bundle.getString("chooseFileDialogTitle"), - nsIFilePicker.modeOpen); - fp.appendFilters(nsIFilePicker.filterAll | nsIFilePicker.filterText | - nsIFilePicker.filterImages | nsIFilePicker.filterXML | - nsIFilePicker.filterHTML); - fp.open(fpCallback); - } catch (ex) { - } -} diff --git a/browser/base/content/openLocation.xul b/browser/base/content/openLocation.xul deleted file mode 100644 index 7bafed0fe7fa..000000000000 --- a/browser/base/content/openLocation.xul +++ /dev/null @@ -1,57 +0,0 @@ - - - - - - - - - - -