Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 21:01:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1818724. Rename nsAVIFDecoder::Decode. r=Zaggy1024

Browse Source 
Because it has the same name as the base class function Decoder::Decode but different arguments, which is confusing.

Depends on D172998

Differential Revision: https://phabricator.services.mozilla.com/D173000
This commit is contained in:
Timothy Nikkel 2023-03-20 23:46:50 +00:00
parent a0b48c1d87
commit c869e31d5e
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
image/decoders/nsAVIFDecoder.cpp
View File

@ -1190,7 +1190,7 @@ LexerResult nsAVIFDecoder::DoDecode(SourceBufferIterator& aIterator,
MOZ_LOG(sAVIFLog, LogLevel::Info, MOZ_LOG(sAVIFLog, LogLevel::Info,
("[this=%p] nsAVIFDecoder::DoDecode start", this)); ("[this=%p] nsAVIFDecoder::DoDecode start", this));
DecodeResult result = Decode(aIterator, aOnResume); DecodeResult result = DoDecodeInternal(aIterator, aOnResume);
RecordDecodeResultTelemetry(result); RecordDecodeResultTelemetry(result);
@ -1378,10 +1378,10 @@ static void RecordFrameTelem(bool aAnimated, const Mp4parseAvifInfo& aInfo,
} }
} }
nsAVIFDecoder::DecodeResult nsAVIFDecoder::Decode( nsAVIFDecoder::DecodeResult nsAVIFDecoder::DoDecodeInternal(
SourceBufferIterator& aIterator, IResumable* aOnResume) { SourceBufferIterator& aIterator, IResumable* aOnResume) {
MOZ_LOG(sAVIFLog, LogLevel::Debug, MOZ_LOG(sAVIFLog, LogLevel::Debug,
("[this=%p] nsAVIFDecoder::DoDecode", this)); ("[this=%p] nsAVIFDecoder::DoDecodeInternal", this));
// Since the SourceBufferIterator doesn't guarantee a contiguous buffer, // Since the SourceBufferIterator doesn't guarantee a contiguous buffer,
// but the current mp4parse-rust implementation requires it, always buffer // but the current mp4parse-rust implementation requires it, always buffer

3
image/decoders/nsAVIFDecoder.h
View File

@ -71,7 +71,8 @@ class nsAVIFDecoder final : public Decoder {
Variant<Mp4parseStatus, NonDecoderResult, Dav1dResult, AOMResult>; Variant<Mp4parseStatus, NonDecoderResult, Dav1dResult, AOMResult>;
Mp4parseStatus CreateParser(); Mp4parseStatus CreateParser();
DecodeResult CreateDecoder(); DecodeResult CreateDecoder();
DecodeResult Decode(SourceBufferIterator& aIterator, IResumable* aOnResume); DecodeResult DoDecodeInternal(SourceBufferIterator& aIterator,
IResumable* aOnResume);
static bool IsDecodeSuccess(const DecodeResult& aResult); static bool IsDecodeSuccess(const DecodeResult& aResult);