Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-29 07:42:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1728376 - Searchfox should treat pure virtual declarations as definitions. r=jrmuizel

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D124152
This commit is contained in:
Andrew Sutherland 2021-09-01 02:41:05 +00:00
parent af2775eaec
commit c872d06387
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
build/clang-plugin/mozsearch-plugin/MozsearchIndexer.cpp
View File

@ -1612,7 +1612,8 @@ public:
wasTemplate = true;
D = D2->getTemplateInstantiationPattern();
}
Kind = D2->isThisDeclarationADefinition() ? "def" : "decl";
// We treat pure virtual declarations as definitions.
Kind = (D2->isThisDeclarationADefinition() || D2->isPure()) ? "def" : "decl";
PrettyKind = "function";
PeekRange = getFunctionPeekRange(D2);
@ -1740,7 +1741,7 @@ public:
}
}
if (FunctionDecl *D2 = dyn_cast<FunctionDecl>(D)) {
if (D2->isThisDeclarationADefinition() &&
if ((D2->isThisDeclarationADefinition() || D2->isPure()) &&
// a clause at the top should have generalized and set wasTemplate so
// it shouldn't be the case that isTemplateInstantiation() is true.
!D2->isTemplateInstantiation() &&