Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 14:55:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1723758 - Ensure all Nimbus features explicitly call method to send exposure r=k88hudson

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D123422
This commit is contained in:
Andrei Oprea 2021-09-03 13:04:51 +00:00
parent 472ab1dfc3
commit c87975af29
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
browser/actors/AboutPrivateBrowsingChild.jsm
View File

@ -47,9 +47,8 @@ class AboutPrivateBrowsingChild extends RemotePageChild {
}
PrivateBrowsingFeatureConfig() {
const config = NimbusFeatures.privatebrowsing.getAllVariables({
sendExposureEvent: true,
});
const config = NimbusFeatures.privatebrowsing.getAllVariables();
NimbusFeatures.privatebrowsing.recordExposureEvent();
// Format urls if any are defined
["infoLinkUrl", "promoLinkUrl"].forEach(key => {

8
browser/components/newtab/AboutNewTabService.jsm
View File

@ -443,12 +443,8 @@ class BaseAboutNewTabService {
* This is calculated in the same way the default URL is.
*/
if (
NimbusFeatures.aboutwelcome.isEnabled({
defaultValue: true,
sendExposureEvent: true,
})
) {
NimbusFeatures.aboutwelcome.recordExposureEvent();
if (NimbusFeatures.aboutwelcome.isEnabled({ defaultValue: true })) {
return ABOUT_WELCOME_URL;
}
return this.defaultURL;