Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-02 18:08:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1788596 - Remove extra lock() on UtilityProcessChild r=nika

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D156482
This commit is contained in:
Alexandre Lissy 2022-10-06 10:56:42 +00:00
parent 16c9919af1
commit c89a2edc37
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ipc/glue/UtilityProcessChild.cpp
View File

@ -45,14 +45,13 @@ static StaticRefPtr<UtilityProcessChild> sUtilityProcessChild;
UtilityProcessChild::UtilityProcessChild() { UtilityProcessChild::UtilityProcessChild() {
nsDebugImpl::SetMultiprocessMode("Utility"); nsDebugImpl::SetMultiprocessMode("Utility");
StaticMutexAutoLock lock(sUtilityProcessChildMutex);
sUtilityProcessChild = this;
} }
UtilityProcessChild::~UtilityProcessChild() = default; UtilityProcessChild::~UtilityProcessChild() = default;
/* static */ /* static */
RefPtr<UtilityProcessChild> UtilityProcessChild::GetSingleton() { RefPtr<UtilityProcessChild> UtilityProcessChild::GetSingleton() {
MOZ_ASSERT(XRE_IsUtilityProcess());
StaticMutexAutoLock lock(sUtilityProcessChildMutex); StaticMutexAutoLock lock(sUtilityProcessChildMutex);
if (!sUtilityProcessChild) { if (!sUtilityProcessChild) {
sUtilityProcessChild = new UtilityProcessChild(); sUtilityProcessChild = new UtilityProcessChild();

2
ipc/glue/UtilityProcessImpl.h
View File

@ -27,7 +27,7 @@ class UtilityProcessImpl final : public ipc::ProcessChild {
void CleanUp() override; void CleanUp() override;
private: private:
RefPtr<UtilityProcessChild> mUtility = new UtilityProcessChild(); RefPtr<UtilityProcessChild> mUtility = UtilityProcessChild::GetSingleton();
#if defined(XP_WIN) #if defined(XP_WIN)
mozilla::mscom::ProcessRuntime mCOMRuntime; mozilla::mscom::ProcessRuntime mCOMRuntime;