Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-04 11:26:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 422179 - Implement bilinear filtering of upscaled images for Linux; r=jmuizelaar a=blocking-final+

Browse Source
This commit is contained in:
KUROSAWA, Takeshi 2010-09-09 16:27:10 -04:00
parent df66874870
commit c8cf79903e
1 changed files with 37 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
gfx/thebes/gfxDrawable.cpp
View File

@ -38,6 +38,10 @@
#include "gfxASurface.h"
#include "gfxContext.h"
#include "gfxPlatform.h"
#ifdef MOZ_X11
#include "cairo.h"
#include "gfxXlibSurface.h"
#endif
gfxSurfaceDrawable::gfxSurfaceDrawable(gfxASurface* aSurface,
const gfxIntSize aSize,
@ -61,10 +65,11 @@ DeviceToImageTransform(gfxContext* aContext,
return gfxMatrix(deviceToUser).Multiply(aUserSpaceToImageSpace);
}
static void
static void
PreparePatternForUntiledDrawing(gfxPattern* aPattern,
const gfxMatrix& aDeviceToImage,
gfxASurface::gfxSurfaceType aSurfaceType,
nsRefPtr<gfxASurface> currentTarget,
const gfxPattern::GraphicsFilter aDefaultFilter)
{
// In theory we can handle this using cairo's EXTEND_PAD,
@ -85,11 +90,40 @@ PreparePatternForUntiledDrawing(gfxPattern* aPattern,
// But don't do this for simple downscales because it's horrible.
// Downscaling means that device-space coordinates are
// scaled *up* to find the image pixel coordinates.
//
// Update 8/11/09: The underlying X server/driver bugs are now
// fixed, and cairo uses the fast XRender code-path as of 1.9.2
// (commit a1d0a06b6275cac3974be84919993e187394fe43) --
// but only if running on a 1.7 X server.
// So we enable EXTEND_PAD provided that we're running a recent
// enough cairo version (obviously, this is only relevant if
// --enable-system-cairo is used) AND running on a recent
// enough X server. This should finally bring linux up to par
// with other systems.
PRBool isDownscale =
aDeviceToImage.xx >= 1.0 && aDeviceToImage.yy >= 1.0 &&
aDeviceToImage.xy == 0.0 && aDeviceToImage.yx == 0.0;
if (!isDownscale) {
aPattern->SetFilter(gfxPattern::FILTER_FAST);
#ifdef MOZ_X11
PRBool fastExtendPad = PR_FALSE;
if (currentTarget->GetType() == gfxASurface::SurfaceTypeXlib &&
cairo_version() >= CAIRO_VERSION_ENCODE(1,9,2)) {
gfxXlibSurface *xlibSurface =
static_cast<gfxXlibSurface *>(currentTarget.get());
Display *dpy = xlibSurface->XDisplay();
// This is the exact condition for cairo to use XRender for
// EXTEND_PAD
if (VendorRelease (dpy) < 60700000 &&
VendorRelease (dpy) >= 10699000)
fastExtendPad = PR_TRUE;
}
if (fastExtendPad) {
aPattern->SetExtend(gfxPattern::EXTEND_PAD);
aPattern->SetFilter(aDefaultFilter);
} else
#endif
aPattern->SetFilter(gfxPattern::FILTER_FAST);
}
break;
}
@ -127,7 +161,7 @@ gfxSurfaceDrawable::Draw(gfxContext* aContext,
gfxMatrix deviceSpaceToImageSpace =
DeviceToImageTransform(aContext, aTransform);
PreparePatternForUntiledDrawing(pattern, deviceSpaceToImageSpace,
surfaceType, aFilter);
surfaceType, currentTarget, aFilter);
}
#ifdef MOZ_GFX_OPTIMIZE_MOBILE
pattern->SetFilter(gfxPattern::FILTER_FAST);