Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 08:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1477603 - Part 7: Avoid React warning. r=ladybenko

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D4189

Depends on D4048

--HG--
extra : rebase_source : e09e5648fb0b74195f30f7d5ec13b28ea58e8e60
extra : amend_source : 1a3f9d56301816c31b58db3801fc808ad7b0dcc8
This commit is contained in:
Daisuke Akatsuka 2018-08-24 15:43:37 +09:00
parent 277452e2c2
commit c963a34dfd
4 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
devtools/client/aboutdebugging-new/src/components/debugtarget/DebugTargetList.js
View File

@ -63,8 +63,8 @@ class DebugTargetList extends PureComponent {
(isCollapsed ? " debug-target-list--collapsed" : ""),
ref: this.listRef,
},
targets.map(target =>
DebugTargetItem({ actionComponent, detailComponent, dispatch, target })),
targets.map((target, key) =>
DebugTargetItem({ actionComponent, detailComponent, dispatch, key, target })),
);
}
}

2
devtools/client/aboutdebugging-new/src/components/debugtarget/DebugTargetPane.js
View File

@ -24,7 +24,7 @@ class DebugTargetPane extends PureComponent {
dispatch: PropTypes.func.isRequired,
isCollapsed: PropTypes.bool.isRequired,
name: PropTypes.string.isRequired,
targets: PropTypes.arrayOf(PropTypes.Object).isRequired,
targets: PropTypes.arrayOf(PropTypes.object).isRequired,
};
}

12
devtools/client/aboutdebugging-new/src/components/debugtarget/ExtensionDetail.js
View File

@ -18,12 +18,13 @@ class ExtensionDetail extends PureComponent {
};
}
renderField(name, value, title) {
renderField(key, name, value, title) {
return [
dom.dt({}, name),
dom.dt({ key: `${ key }-dt` }, name),
dom.dd(
{
className: "ellipsis-text",
key: `${ key }-dd`,
title: title || value,
},
value,
@ -40,6 +41,7 @@ class ExtensionDetail extends PureComponent {
dom.a(
{
className: "extension-detail__manifest",
key: "manifest",
href: manifestURL,
target: "_blank",
},
@ -47,7 +49,7 @@ class ExtensionDetail extends PureComponent {
)
];
return this.renderField("Internal UUID", value, uuid);
return this.renderField("uuid", "Internal UUID", value, uuid);
}
render() {
@ -59,8 +61,8 @@ class ExtensionDetail extends PureComponent {
{
className: "extension-detail",
},
location ? this.renderField("Location", location) : null,
this.renderField("Extension ID", id),
location ? this.renderField("location", "Location", location) : null,
this.renderField("extension", "Extension ID", id),
uuid ? this.renderUUID() : null,
);
}

9
devtools/client/aboutdebugging-new/src/components/debugtarget/WorkerDetail.js
View File

@ -27,15 +27,16 @@ class WorkerDetail extends PureComponent {
const label = fetch === SERVICE_WORKER_FETCH_STATES.LISTENING
? "Listening for fetch events"
: "Not listening for fetch events";
return this.renderField("Fetch", label);
return this.renderField("fetch", "Fetch", label);
}
renderField(name, value) {
renderField(key, name, value) {
return [
dom.dt({}, name),
dom.dt({ key: `${ key }-dt` }, name),
dom.dd(
{
className: "ellipsis-text",
key: `${ key }-dd`,
title: value,
},
value,
@ -62,7 +63,7 @@ class WorkerDetail extends PureComponent {
className: "worker-detail",
},
fetch ? this.renderFetch() : null,
scope ? this.renderField("Scope", scope) : null,
scope ? this.renderField("scope", "Scope", scope) : null,
status ? this.renderStatus() : null,
);
}