Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-26 12:20:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1401871 - Check if menu item(home_add_to_launcher) exists or not before accessing it. r=nechen

Browse Source 
We temporarily hide `home_add_to_launcher` in API 26, which means directly accesses it without checking
if it exists or not would cause NullPointerException.

MozReview-Commit-ID: KXnP81ZZa6u

--HG--
extra : rebase_source : 9189f3ab940d50702f82365824feff441faeef5a
This commit is contained in:
Jing-wei Wu 2017-09-26 16:12:15 +08:00
parent 918e171099
commit c9e6661799
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mobile/android/base/java/org/mozilla/gecko/home/HomeFragment.java
View File

@ -208,7 +208,11 @@ public abstract class HomeFragment extends Fragment {
menu.findItem(R.id.home_open_private_tab).setVisible(false);
menu.findItem(R.id.home_copyurl).setVisible(false);
menu.findItem(R.id.home_share).setVisible(false);
menu.findItem(R.id.home_add_to_launcher).setVisible(false);
final MenuItem addToLauncherItem = menu.findItem(R.id.home_add_to_launcher);
if (addToLauncherItem != null) {
addToLauncherItem.setVisible(false);
}
menu.findItem(R.id.home_set_as_homepage).setVisible(false);
menu.findItem(R.id.home_as_pin).setVisible(false);