Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-07 18:04:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1494207 - Add MOZ_CRASH_WRITE_ADDR to avoid ILL with UBSan. r=nfroyd

Browse Source
This commit is contained in:
twsmith 2018-10-04 14:52:16 -07:00
parent c4eb825654
commit ca53c9933c
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
mfbt/Assertions.h
View File

@ -221,16 +221,33 @@ MOZ_NoReturn(int aLine)
MOZ_NoReturn(line); \
} while (false)
#else
/*
* MOZ_CRASH_WRITE_ADDR is the address to be used when performing a forced
* crash. NULL is preferred however if for some reason NULL cannot be used
* this makes choosing another value possible.
*
* In the case of UBSan certain checks, bounds specifically, cause the compiler
* to emit the 'ud2' instruction when storing to 0x0. This causes forced
* crashes to manifest as ILL (at an arbitrary address) instead of the expected
* SEGV at 0x0.
*/
# ifdef MOZ_UBSAN
# define MOZ_CRASH_WRITE_ADDR 0x1
# else
# define MOZ_CRASH_WRITE_ADDR NULL
# endif
# ifdef __cplusplus
# define MOZ_REALLY_CRASH(line) \
do { \
*((volatile int*) NULL) = line; \
*((volatile int*) MOZ_CRASH_WRITE_ADDR) = line; \
::abort(); \
} while (false)
# else
# define MOZ_REALLY_CRASH(line) \
do { \
*((volatile int*) NULL) = line; \
*((volatile int*) MOZ_CRASH_WRITE_ADDR) = line; \
abort(); \
} while (false)
# endif