From cae9cf0b13fb3ddaef891c58ae2ebf3fb0de26a7 Mon Sep 17 00:00:00 2001 From: Andrea Marchesini Date: Thu, 3 May 2018 08:37:27 +0200 Subject: [PATCH] Bug 1458505 - grapping 'self' in mozilla::MakeScopeExit instead of '&' when needed, in HTMLMediaElement, r=me CLOSED TREE --- dom/html/HTMLMediaElement.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dom/html/HTMLMediaElement.cpp b/dom/html/HTMLMediaElement.cpp index 306b938104bd..b428535c2cca 100644 --- a/dom/html/HTMLMediaElement.cpp +++ b/dom/html/HTMLMediaElement.cpp @@ -4827,8 +4827,8 @@ nsresult HTMLMediaElement::InitializeDecoderForChannel(nsIChannel* aChannel, NS_ASSERTION(!mimeType.IsEmpty(), "We should have the Content-Type."); NS_ConvertUTF8toUTF16 mimeUTF16(mimeType); - HTMLMediaElement* self = this; - auto reportCanPlay = [&](bool aCanPlay) { + RefPtr self = this; + auto reportCanPlay = [&, self](bool aCanPlay) { diagnostics.StoreFormatDiagnostics( self->OwnerDoc(), mimeUTF16, aCanPlay, __func__); if (!aCanPlay) {