Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 08:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1542975 - Radio buttons in Forget panel are not keyboard navigable r=Jamie

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D61820

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Kousuke Takaki 2020-02-07 03:44:09 +00:00
parent b9a4e49ccf
commit cb722fa6db
2 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
browser/components/customizableui/PanelMultiView.jsm
View File

@ -1519,6 +1519,7 @@ var PanelView = class extends AssociatedToNode {
let tag = element.localName;
return (
tag == "menulist" ||
tag == "radiogroup" ||
tag == "input" ||
tag == "textarea" ||
// Allow tab to reach embedded documents.

35
browser/components/customizableui/test/browser_PanelMultiView_keyboard.js
View File

@ -20,6 +20,7 @@ let gMainView;
let gMainContext;
let gMainButton1;
let gMainMenulist;
let gMainRadiogroup;
let gMainTextbox;
let gMainButton2;
let gMainButton3;
@ -108,6 +109,16 @@ add_task(async function setup() {
item = document.createXULElement("menuitem");
item.setAttribute("value", "2");
menuPopup.appendChild(item);
gMainRadiogroup = document.createXULElement("radiogroup");
gMainRadiogroup.id = "gMainRadiogroup";
gMainView.appendChild(gMainRadiogroup);
let radio = document.createXULElement("radio");
radio.setAttribute("value", "1");
radio.setAttribute("selected", "true");
gMainRadiogroup.appendChild(radio);
radio = document.createXULElement("radio");
radio.setAttribute("value", "2");
gMainRadiogroup.appendChild(radio);
gMainTextbox = document.createElement("input");
gMainTextbox.id = "gMainTextbox";
gMainView.appendChild(gMainTextbox);
@ -121,6 +132,7 @@ add_task(async function setup() {
gMainTabOrder = [
gMainButton1,
gMainMenulist,
gMainRadiogroup,
gMainTextbox,
gMainButton2,
gMainButton3,
@ -322,6 +334,29 @@ if (AppConstants.platform == "macosx") {
});
}
// Test that the up/down arrow keys work as expected in radiogroups.
add_task(async function testArrowsRadiogroup() {
await openPopup();
gMainRadiogroup.focus();
is(document.activeElement, gMainRadiogroup, "radiogroup focused");
is(gMainRadiogroup.value, "1", "radiogroup initial value 1");
EventUtils.synthesizeKey("KEY_ArrowDown");
is(
document.activeElement,
gMainRadiogroup,
"radiogroup still focused after ArrowDown"
);
is(gMainRadiogroup.value, "2", "radiogroup value 2 after ArrowDown");
EventUtils.synthesizeKey("KEY_ArrowUp");
is(
document.activeElement,
gMainRadiogroup,
"radiogroup still focused after ArrowUp"
);
is(gMainRadiogroup.value, "1", "radiogroup value 1 after ArrowUp");
await hidePopup();
});
// Test that pressing space in a textbox inserts a space (instead of trying to
// activate the control).
add_task(async function testSpaceTextbox() {