Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 01:35:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1434126 - Call GeckoSession.closeWindow() from onDestroy() in CustomTabsActivity and WebAppActivity. r=snorp

Browse Source
This commit is contained in:
Dylan Roeh 2018-02-07 09:15:12 -06:00
parent a11a9d201f
commit cb9419b55e
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
View File

@ -179,6 +179,7 @@ public class CustomTabsActivity extends AppCompatActivity
@Override
public void onDestroy() {
mGeckoSession.closeWindow();
mTextSelection.destroy();
mFormAssistPopup.destroy();
mDoorHangerPopup.destroy();

1
mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java
View File

@ -217,6 +217,7 @@ public class WebAppActivity extends AppCompatActivity
@Override
public void onDestroy() {
mGeckoSession.closeWindow();
mTextSelection.destroy();
mDoorHangerPopup.destroy();
mPromptService.destroy();

3
mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoSession.java
View File

@ -565,7 +565,8 @@ public class GeckoSession extends LayerSession
ThreadUtils.assertOnUiThread();
if (!isOpen()) {
throw new IllegalStateException("Session is not open");
Log.w(LOGTAG, "Attempted to close a GeckoSession that was already closed.")
return;
}
if (GeckoThread.isStateAtLeast(GeckoThread.State.PROFILE_READY)) {