Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-11 16:32:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixes bug 73940. HTTP URLs with '?' characters should not be cached unless

Browse Source 
an expiration time is explicitly provided by the server.
r=gagan,valeski sr=dougt,alecf
This commit is contained in:
darin%netscape.com 2001-03-28 18:24:13 +00:00
parent fcaf601272
commit cd054310fc
1 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
netwerk/protocol/http/src/nsHTTPChannel.cpp
View File

@ -1136,7 +1136,7 @@ nsHTTPChannel::CheckCache()
LOG(("Content-length=%d, CacheEntryDataSize=%u\n", contentLength, size));
if (size != contentLength) {
if (size != (PRUint32) contentLength) {
NS_WARNING("Cached data size does not match the Content-Length header");
return NS_OK; // must re-fetch
}
@ -1339,6 +1339,31 @@ nsHTTPChannel::ResponseIsCacheable()
return PR_FALSE;
}
}
str = 0;
// From section 13.9 of RFC2616: "caches MUST NOT treat responses to URLs
// [containing a "?" in the rel_path part] as fresh unless the server
// provides an explicit expiration time." An explicit expiration time
// can be specified either via the "Cache-Control: max-age" or "Expires"
// headers.
nsCOMPtr<nsIURL> url = do_QueryInterface(mURI);
// Check for a non-empty query string...
if (url)
url->GetQuery(getter_Copies(str));
if (str && *str) {
PRBool avail = PR_FALSE;
PRUint32 value;
// If "Cache-Control: max-age" is present...
mResponse->GetMaxAge(&value, &avail);
if (avail) return PR_TRUE;
// If "Expires" is present...
mResponse->GetExpiresValue(&value, &avail);
if (avail) return PR_TRUE;
// Else, this response is not cacheable!
LOG(("Not caching since request is for an URL with a '?' and the "
"server has not explicitly provided an expiration time\n"));
return PR_FALSE;
}
return PR_TRUE;
}