Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 20:05:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

optimization: When only category changes, dont harvest; just recompute cost.

Browse Source
This commit is contained in:
dp%netscape.com 2002-04-17 01:37:14 +00:00
parent 1a272f9fd1
commit cd6227b553
1 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
tools/trace-malloc/spacetrace.c
View File

@ -1926,7 +1926,7 @@ STRun* createRunFromGlobal(void)
if (globals.mOptions.mCategoryName) if (globals.mOptions.mCategoryName)
{ {
STCategoryNode* node = findCategoryNode(globals.mOptions.mCategoryName, &globals); STCategoryNode* node = findCategoryNode(globals.mOptions.mCategoryName, &globals);
if (node && node->run) if (node)
{ {
/* Recalculate cost of run */ /* Recalculate cost of run */
recalculateRunCost(node->run); recalculateRunCost(node->run);
@ -5046,6 +5046,7 @@ int applySettings(void)
int changedOrder = 0; int changedOrder = 0;
int changedGraph = 0; int changedGraph = 0;
int changedDontCare = 0; int changedDontCare = 0;
int changedCategory = 0;
char looper_buf[32]; char looper_buf[32];
PRIntn looper = 0; PRIntn looper = 0;
@ -5082,13 +5083,13 @@ int applySettings(void)
PR_snprintf(looper_buf, sizeof(looper_buf), "mRestrictText%d", looper); PR_snprintf(looper_buf, sizeof(looper_buf), "mRestrictText%d", looper);
getRes += getDataString(globals.mRequest.mGetData, looper_buf, &globals.mOptions.mRestrictText[looper], &changedSet); getRes += getDataString(globals.mRequest.mGetData, looper_buf, &globals.mOptions.mRestrictText[looper], &changedSet);
} }
getRes += getDataString(globals.mRequest.mGetData, "mCategoryName", &globals.mOptions.mCategoryName, &changedSet); getRes += getDataString(globals.mRequest.mGetData, "mCategoryName", &globals.mOptions.mCategoryName, &changedCategory);
/* /*
** Sanity check options ** Sanity check options
*/ */
if (!globals.mOptions.mCategoryName || !*globals.mOptions.mCategoryName if (changedCategory && (!globals.mOptions.mCategoryName || !*globals.mOptions.mCategoryName
|| !findCategoryNode(globals.mOptions.mCategoryName, &globals)) || !findCategoryNode(globals.mOptions.mCategoryName, &globals)))
{ {
if (globals.mOptions.mCategoryName) if (globals.mOptions.mCategoryName)
free(globals.mOptions.mCategoryName); free(globals.mOptions.mCategoryName);
@ -5111,6 +5112,27 @@ int applySettings(void)
REPORT_ERROR(__LINE__, createRunFromGlobal); REPORT_ERROR(__LINE__, createRunFromGlobal);
} }
} }
else if (0 != changedCategory)
{
/*
** Just a category change. We dont need to harvest. Just find the
** right node and set the cache.mSortedRun. We need to recompute
** cost though. But that is cheap.
*/
if (globals.mOptions.mCategoryName)
{
STCategoryNode* node = findCategoryNode(globals.mOptions.mCategoryName, &globals);
if (node)
{
/* Recalculate cost of run */
recalculateRunCost(node->run);
globals.mCache.mSortedRun = node->run;
}
}
}
#if WANT_GRAPHS #if WANT_GRAPHS
/* /*