Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-02 10:00:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1673683 - Copy activeness status in CanonicalBrowsingContext::ReplacedBy, instead of handling it on consumers. r=nika,agi

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D102220
This commit is contained in:
Emilio Cobos Álvarez 2021-01-20 15:09:09 +00:00
parent c10e4bec55
commit cd99d52bde
3 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
browser/base/content/tabbrowser.js
View File

@ -1876,10 +1876,11 @@
aBrowser.droppedLinkHandler = oldDroppedLinkHandler;
// Switching a browser's remoteness will create a new frameLoader.
// As frameLoaders start out with an active docShell we have to
// deactivate it if this is not the selected tab's browser or the
// browser window is minimized.
// This shouldn't really be necessary (it should always set the same
// value as activeness is correctly preserved across remoteness changes).
// However, this has the side effect of sending MozLayerTreeReady /
// MozLayerTreeCleared events for remote frames, which the tab switcher
// depends on.
aBrowser.docShellIsActive = this.shouldActivateDocShell(aBrowser);
// Create a new tab progress listener for the new browser we just injected,
@ -5695,10 +5696,11 @@
browser.droppedLinkHandler = oldDroppedLinkHandler;
// Switching a browser's remoteness will create a new frameLoader.
// As frameLoaders start out with an active docShell we have to
// deactivate it if this is not the selected tab's browser or the
// browser window is minimized.
// This shouldn't really be necessary (it should always set the same
// value as activeness is correctly preserved across remoteness changes).
// However, this has the side effect of sending MozLayerTreeReady /
// MozLayerTreeCleared events for remote frames, which the tab switcher
// depends on.
browser.docShellIsActive = this.shouldActivateDocShell(browser);
// Create a new tab progress listener for the new browser we just

2
docshell/base/CanonicalBrowsingContext.cpp
View File

@ -167,6 +167,8 @@ void CanonicalBrowsingContext::ReplacedBy(
aNewContext->mWebProgress = std::move(mWebProgress);
aNewContext->mFields.SetWithoutSyncing<IDX_BrowserId>(GetBrowserId());
aNewContext->mFields.SetWithoutSyncing<IDX_HistoryID>(GetHistoryID());
aNewContext->mFields.SetWithoutSyncing<IDX_ExplicitActive>(
GetExplicitActive());
if (mSessionHistory) {
mSessionHistory->SetBrowsingContext(aNewContext);

7
mobile/android/chrome/geckoview/geckoview.js
View File

@ -172,18 +172,11 @@ var ModuleManager = {
this.forEach(module => {
module.onDestroyBrowser();
});
// TODO: Bug 1673683: `docShellIsActive` is sometimes not preserved when
// switching process.
this.docShellIsActiveWhileSwitchingProcess = this.browser.docShellIsActive;
},
didChangeBrowserRemoteness() {
debug`DidChangeBrowserRemoteness`;
this.browser.docShellIsActive = this.docShellIsActiveWhileSwitchingProcess;
this.docShellIsActiveWhileSwitchingProcess = undefined;
this.forEach(module => {
if (module.impl) {
module.impl.onInitBrowser();