Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-18 14:56:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1087368: webrtc & PulseAudio: don't crash in case of buffer holes r=jesup

Browse Source 
DONTBUILD
This commit is contained in:
Giuseppe Bilotta 2014-10-22 16:56:54 +02:00
parent 49ded62b13
commit cdf3b76e36
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
media/webrtc/trunk/webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc
View File

@ -2473,6 +2473,18 @@ void AudioDeviceLinuxPulse::PaStreamReadCallbackHandler()
return;
}
// PulseAudio record streams can have holes (for reasons not entirely clear
// to the PA developers themselves). Since version 4 of PA, these are passed
// over to the application (us), signaled by a non-zero sample data size
// (the size of the hole) and a NULL sample data.
// We handle stream holes as recommended by PulseAudio, i.e. by skipping
// it, which is done with a stream drop.
if (_tempSampleDataSize && !_tempSampleData) {
LATE(pa_stream_drop)(_recStream);
_tempSampleDataSize = 0; // reset
return;
}
// Since we consume the data asynchronously on a different thread, we have
// to temporarily disable the read callback or else Pulse will call it
// continuously until we consume the data. We re-enable it below