Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-01 08:42:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1389854: Don't define lazy getter for uninstall preferences. r=aswan

Browse Source 
These getters are checked very rarely, and not at all in most sessions. They
don't justify the overhead of adding lazy getters at startup.

MozReview-Commit-ID: 9XVlLapNJCE

--HG--
extra : rebase_source : edff8e878528952aeec851203edaa4d41e37e24d
This commit is contained in:
Kris Maglione 2017-08-12 16:21:17 -07:00
parent 1e4b0c194f
commit cdfa0d9032
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
toolkit/components/extensions/Extension.jsm
View File

@ -41,10 +41,6 @@ Cu.importGlobalProperties(["TextEncoder"]);
Cu.import("resource://gre/modules/XPCOMUtils.jsm");
Cu.import("resource://gre/modules/Services.jsm");
/* globals processCount */
XPCOMUtils.defineLazyPreferenceGetter(this, "processCount", "dom.ipc.processCount.extension");
XPCOMUtils.defineLazyModuleGetters(this, {
AddonManager: "resource://gre/modules/AddonManager.jsm",
AddonManagerPrivate: "resource://gre/modules/AddonManager.jsm",
@ -75,6 +71,7 @@ XPCOMUtils.defineLazyServiceGetters(this, {
uuidGen: ["@mozilla.org/uuid-generator;1", "nsIUUIDGenerator"],
});
XPCOMUtils.defineLazyPreferenceGetter(this, "processCount", "dom.ipc.processCount.extension");
XPCOMUtils.defineLazyPreferenceGetter(this, "useRemoteWebExtensions",
"extensions.webextensions.remote", false);
@ -231,8 +228,6 @@ var UninstallObserver = {
init() {
if (!this.initialized) {
AddonManager.addAddonListener(this);
XPCOMUtils.defineLazyPreferenceGetter(this, "leaveStorage", LEAVE_STORAGE_PREF, false);
XPCOMUtils.defineLazyPreferenceGetter(this, "leaveUuid", LEAVE_UUID_PREF, false);
this.initialized = true;
}
},
@ -252,7 +247,7 @@ var UninstallObserver = {
return;
}
if (!this.leaveStorage) {
if (!Services.prefs.getBoolPref(LEAVE_STORAGE_PREF, false)) {
// Clear browser.local.storage
AsyncShutdown.profileChangeTeardown.addBlocker(
`Clear Extension Storage ${addon.id}`,
@ -277,7 +272,7 @@ var UninstallObserver = {
Services.perms.removeFromPrincipal(principal, "persistent-storage");
}
if (!this.leaveUuid) {
if (!Services.prefs.getBoolPref(LEAVE_UUID_PREF, false)) {
// Clear the entry in the UUID map
UUIDMap.remove(addon.id);
}