From cf11c66bf7464b459160ebc1ec2ccef6fa7513bd Mon Sep 17 00:00:00 2001
From: "dietrich%mozilla.com" <dietrich%mozilla.com>
Date: Wed, 16 Aug 2006 06:17:03 +0000
Subject: [PATCH] Bug 348016 The "Recently closed tabs" menu is no longer
 functional after opening the "Customize toolbars" dialogue (r=mconnor)

---
 browser/base/content/browser-menubar.inc |  4 +--
 browser/base/content/browser.js          | 31 ++++++++++++++----------
 2 files changed, 20 insertions(+), 15 deletions(-)

diff --git a/browser/base/content/browser-menubar.inc b/browser/base/content/browser-menubar.inc
index aec23f332564..3fdb424eeb95 100644
--- a/browser/base/content/browser-menubar.inc
+++ b/browser/base/content/browser-menubar.inc
@@ -364,7 +364,7 @@
                 <menuseparator id="startTabHistorySeparator"/>
                 <menuseparator hidden="true" id="endTabHistorySeparator"/>
                 <menu id="historyUndoMenu" label="&historyUndoMenu.label;" disabled="true">
-                  <menupopup id="historyUndoPopup"/>
+                  <menupopup id="historyUndoPopup" onpopupshowing="HistoryMenu.populateUndoSubmenu();"/>
                 </menu>
                 <menuseparator id="endUndoSeparator"/>
                 <menuitem id="sanitizeItem" 
@@ -406,7 +406,7 @@
                 <menuseparator id="startHistorySeparator"/>
                 <menuseparator hidden="true" id="endHistorySeparator"/>
                 <menu id="historyUndoMenu" label="&historyUndoMenu.label;" disabled="true">
-                  <menupopup id="historyUndoPopup"/>
+                  <menupopup id="historyUndoPopup" onpopupshowing="HistoryMenu.populateUndoSubmenu();"/>
                 </menu>
                 <menuseparator id="endUndoSeparator"/>
                 <menuitem observes="viewHistorySidebar" label="&historyShowSidebarCmd.label;"
diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js
index 6543d6fb7b1e..0dd35991fb84 100644
--- a/browser/base/content/browser.js
+++ b/browser/base/content/browser.js
@@ -1131,9 +1131,6 @@ function delayedStartup()
 
   // browser-specific tab augmentation
   AugmentTabs.init();
-
-  // set up history menu
-  HistoryMenu.init();
 }
 
 function BrowserShutdown()
@@ -1741,6 +1738,9 @@ function updateGoMenu(aEvent, goMenu)
 
   if (showSep)
     endSep.hidden = false;
+
+  // enable/disable RCT sub menu
+  HistoryMenu.toggleRecentlyClosedTabs();
 }
  
 function addBookmarkAs(aBrowser, aBookmarkAllTabs, aIsWebPanel)
@@ -3221,6 +3221,10 @@ function FillHistoryMenu(aParent, aMenu, aInsertBefore)
             }
           break;
       }
+
+  // enable/disable RCT sub menu
+  HistoryMenu.toggleRecentlyClosedTabs();
+
     return true;
   }
 
@@ -6836,17 +6840,18 @@ var AugmentTabs = {
 var HistoryMenu = {};
 #endif
 
-HistoryMenu.init = function PHM_init() {
-  this.initializeUndoSubmenu();
-}
+HistoryMenu.toggleRecentlyClosedTabs = function PHM_toggleRecentlyClosedTabs() {
+  // enable/disable the Recently Closed Tabs sub menu
+  var undoPopup = document.getElementById("historyUndoPopup");
 
-/**
- * Initialize the "Undo Close Tabs" menu
- */
-HistoryMenu.initializeUndoSubmenu = function PHM_initializeUndoSubmenu() {
-  // get history menupopup 
-  var histMenu = document.getElementById("goPopup");
-  histMenu.addEventListener("popupshowing", function() { HistoryMenu.populateUndoSubmenu(); }, false);
+  // get closed-tabs from nsSessionStore
+  var ss = Cc["@mozilla.org/browser/sessionstore;1"].
+           getService(Ci.nsISessionStore);
+  // no restorable tabs, so disable menu
+  if (ss.getClosedTabCount(window) == 0)
+    undoPopup.parentNode.setAttribute("disabled", true);
+  else
+    undoPopup.parentNode.removeAttribute("disabled");
 }
 
 /**