Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-03 10:33:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix X-server crash by preventing drags from menus on non-Win32 platforms.

Browse Source 
r=hyatt, sr=blake, a=asa, bug 79003.
This commit is contained in:
ben%netscape.com 2001-06-05 02:15:12 +00:00
parent 119d23f310
commit cf38989bdd
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
xpfe/browser/resources/content/navigatorDD.js
View File

@ -22,12 +22,6 @@
* - Ben Goodger <ben@netscape.com>
*/
////////////////////////////////////////////////////////////////////////////
// XXX - WARNING - DRAG AND DROP API CHANGE ALERT - XXX
// This file has been extensively modified in a checkin planned for Mozilla
// 0.8, and the API has been modified. DO NOT MODIFY THIS FILE without
// approval from ben@netscape.com, otherwise your changes will be lost.
var gRDFService = Components.classes["@mozilla.org/rdf/rdf-service;1"]
.getService(Components.interfaces.nsIRDFService);
@ -76,6 +70,16 @@ var personalToolbarObserver = {
DROP_AFTER: 1,
onDragStart: function (aEvent, aXferData, aDragAction)
{
// Prevent dragging out of menus on non Win32 platforms.
// a) on Mac drag from menus is generally regarded as being satanic
// b) on Linux, this causes an X-server crash, see bug 79003.
// Since we're not doing D&D into menus properly at this point, it seems
// fair enough to disable it on non-Win32 platforms. There is no hang
// or crash associated with this on Windows, so we'll leave the functionality
// there.
if (navigator.platform != "Win32" && aEvent.target.localName != "button")
return;
var personalToolbar = document.getElementById("PersonalToolbar");
if (aEvent.target == personalToolbar) return;