Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug 1603078: remote: fix passing extra prefs to Puppeteer r=remote-protocol-reviewers,maja_zf

Browse Source 
Puppeteer accepts an environmental variable EXTRA_LAUNCH_OPTIONS
that is a JSON encoded object as a string, containing additional
configuration to use when running tests.

This takes an extraPrefsFirefox key which is an object
mapping preference names to values.  This is extracted in
remote/test/puppeteer/lib/Launcher.js:390 and later written to a
fresh profile in :515.

It appears remote/mach_commands.py has left out the "Firefox" appendix.

Differential Revision: https://phabricator.services.mozilla.com/D58511

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Andreas Tolfsen 2020-01-10 14:56:21 +00:00
parent da0f38e5f0
commit cfb4f745d1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
remote/mach_commands.py
View File

@ -229,7 +229,7 @@ class PuppeteerRunner(MozbuildObject):
prefs[k] = mozprofile.Preferences.cast(v)
if prefs:
extra_options["extraPrefs"] = prefs
extra_options["extraPrefsFirefox"] = prefs
if extra_options:
env["EXTRA_LAUNCH_OPTIONS"] = json.dumps(extra_options)