Bug 1320389 - Rename legacyactions; r=ato

MozReview-Commit-ID: 7fImbYQsvJh

--HG--
extra : rebase_source : 2242fabb0e617df7c0d1a65eeadcb194e45a9cae
This commit is contained in:
Maja Frydrychowicz 2016-11-29 11:00:52 -05:00
parent caaa5feca9
commit cfb8c694b7
3 changed files with 19 additions and 22 deletions

View File

@ -18,7 +18,6 @@ XPCOMUtils.defineLazyServiceGetter(
this, "cookieManager", "@mozilla.org/cookiemanager;1", "nsICookieManager2");
Cu.import("chrome://marionette/content/accessibility.js");
Cu.import("chrome://marionette/content/action.js");
Cu.import("chrome://marionette/content/addon.js");
Cu.import("chrome://marionette/content/assert.js");
Cu.import("chrome://marionette/content/atom.js");
@ -139,7 +138,7 @@ this.GeckoDriver = function (appName, server) {
this.importedScripts = new evaluate.ScriptStorageService(
[Context.CHROME, Context.CONTENT]);
this.sandboxes = new Sandboxes(() => this.getCurrentWindow());
this.actions = new action.Chain();
this.legacyactions = new legacyaction.Chain();
this.timer = null;
this.inactivityTimer = null;
@ -179,8 +178,6 @@ this.GeckoDriver = function (appName, server) {
this.dialog = new modal.Dialog(() => this.curBrowser, winr);
};
modal.addHandler(handleDialog);
this.actions = new action.Chain();
};
Object.defineProperty(GeckoDriver.prototype, "a11yChecks", {
@ -1652,7 +1649,7 @@ GeckoDriver.prototype.actionChain = function*(cmd, resp) {
}
let win = this.getCurrentWindow();
resp.body.value = yield this.actions.dispatchActions(
resp.body.value = yield this.legacyactions.dispatchActions(
chain, nextId, {frame: win}, this.curBrowser.seenEls);
break;
@ -2842,8 +2839,8 @@ GeckoDriver.prototype.commands = {
"timeouts": GeckoDriver.prototype.setTimeouts, // deprecated until Firefox 55
"setTimeouts": GeckoDriver.prototype.setTimeouts,
"singleTap": GeckoDriver.prototype.singleTap,
"actionChain": GeckoDriver.prototype.actionChain,
"multiAction": GeckoDriver.prototype.multiAction,
"actionChain": GeckoDriver.prototype.actionChain, // deprecated
"multiAction": GeckoDriver.prototype.multiAction, // deprecated
"executeAsyncScript": GeckoDriver.prototype.executeAsyncScript,
"executeJSScript": GeckoDriver.prototype.executeJSScript,
"findElement": GeckoDriver.prototype.findElement,

View File

@ -13,11 +13,11 @@ Cu.import("chrome://marionette/content/event.js");
const CONTEXT_MENU_DELAY_PREF = "ui.click_hold_context_menus.delay";
const DEFAULT_CONTEXT_MENU_DELAY = 750; // ms
this.EXPORTED_SYMBOLS = ["action"];
this.EXPORTED_SYMBOLS = ["legacyaction"];
const logger = Log.repository.getLogger("Marionette");
this.action = {};
this.legacyaction = this.action = {};
/**
* Functionality for (single finger) action chains.

View File

@ -59,7 +59,7 @@ var SUPPORTED_STRATEGIES = new Set([
var capabilities = {};
var actions = new action.Chain(checkForInterrupted);
var legacyactions = new legacyaction.Chain(checkForInterrupted);
// the unload handler
var onunload;
@ -141,7 +141,7 @@ function registerSelf() {
function emitTouchEventForIFrame(message) {
message = message.json;
let identifier = actions.nextTouchId;
let identifier = legacyactions.nextTouchId;
let domWindowUtils = curContainer.frame.
QueryInterface(Components.interfaces.nsIInterfaceRequestor).
@ -328,7 +328,7 @@ function newSession(msg) {
// events being the result of a physical mouse action.
// This is especially important for the touch event shim,
// in order to prevent creating touch event for these fake mouse events.
actions.inputSource = Ci.nsIDOMMouseEvent.MOZ_SOURCE_TOUCH;
legacyactions.inputSource = Ci.nsIDOMMouseEvent.MOZ_SOURCE_TOUCH;
}
}
@ -408,7 +408,7 @@ function deleteSession(msg) {
// reset container frame to the top-most frame
curContainer = { frame: content, shadowRoot: null };
curContainer.frame.focus();
actions.touchIds = {};
legacyactions.touchIds = {};
}
/**
@ -476,7 +476,7 @@ function sendLog(msg) {
function resetValues() {
sandboxes.clear();
curContainer = {frame: content, shadowRoot: null};
actions.mouseEventsOnly = false;
legacyactions.mouseEventsOnly = false;
}
/**
@ -506,7 +506,7 @@ function checkForInterrupted() {
if (wasInterrupted()) {
if (previousContainer) {
// if previousContainer is set, then we're in a single process environment
curContainer = actions.container = previousContainer;
curContainer = legacyactions.container = previousContainer;
previousContainer = null;
}
else {
@ -595,7 +595,7 @@ function emitTouchEvent(type, touch) {
QueryInterface(Components.interfaces.nsIInterfaceRequestor).
getInterface(Components.interfaces.nsIWebNavigation).
QueryInterface(Components.interfaces.nsIDocShell);
if (docShell.asyncPanZoomEnabled && actions.scrolling) {
if (docShell.asyncPanZoomEnabled && legacyactions.scrolling) {
// if we're in APZ and we're scrolling, we must use sendNativeTouchPoint to dispatch our touchmove events
let index = sendSyncMessage("MarionetteFrame:getCurrentFrameId");
// only call emitTouchEventForIFrame if we're inside an iframe.
@ -639,16 +639,16 @@ function singleTap(id, corx, cory) {
a11y.assertVisible(acc, el, visible);
a11y.assertActionable(acc, el);
if (!curContainer.frame.document.createTouch) {
actions.mouseEventsOnly = true;
legacyactions.mouseEventsOnly = true;
}
let c = element.coordinates(el, corx, cory);
if (!actions.mouseEventsOnly) {
let touchId = actions.nextTouchId++;
if (!legacyactions.mouseEventsOnly) {
let touchId = legacyactions.nextTouchId++;
let touch = createATouch(el, c.x, c.y, touchId);
emitTouchEvent('touchstart', touch);
emitTouchEvent('touchend', touch);
}
actions.mouseTap(el.ownerDocument, c.x, c.y);
legacyactions.mouseTap(el.ownerDocument, c.x, c.y);
});
}
@ -660,7 +660,7 @@ function createATouch(el, corx, cory, touchId) {
let doc = el.ownerDocument;
let win = doc.defaultView;
let [clientX, clientY, pageX, pageY, screenX, screenY] =
actions.getCoordinateInfo(el, corx, cory);
legacyactions.getCoordinateInfo(el, corx, cory);
let atouch = doc.createTouch(win, el, touchId, pageX, pageY, screenX, screenY, clientX, clientY);
return atouch;
}
@ -673,7 +673,7 @@ function actionChain(chain, touchId) {
touchProvider.createATouch = createATouch;
touchProvider.emitTouchEvent = emitTouchEvent;
return actions.dispatchActions(
return legacyactions.dispatchActions(
chain,
touchId,
curContainer,