Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 23:05:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1725797 - Fix + use wasmRelaxedSimdEnabled. r=rhunt

Browse Source 
The WasmFeature for relaxed SIMD was spec'd too weakly: in
moz.configure, relaxed SIMD depends on normal SIMD, but the
WasmFeature did not have the proper dependency.  So add that.

Now that wasmRelaxedSimdEnabled() implies wasmSimdEnabled(), we can
use the former predicate alone to guard relaxed-SIMD tests.

Differential Revision: https://phabricator.services.mozilla.com/D122668
This commit is contained in:
Lars T Hansen 2021-08-17 06:55:08 +00:00
parent 0c9acde69c
commit d006fd15d1
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
js/public/WasmFeatures.h
View File

@ -132,8 +132,7 @@
/* lower case name */ v128Relaxed, \
/* compile predicate */ WASM_RELAXED_SIMD_ENABLED, \
/* compiler predicate */ AnyCompilerAvailable(cx), \
/* flag predicate */ !IsFuzzingCranelift(cx) && \
js::jit::JitSupportsWasmSimd(), \
/* flag predicate */ WasmSimdFlag(cx), \
/* shell flag */ "relaxed-simd", \
/* preference name */ "relaxed_simd") \
EXPERIMENTAL(/* capitalized name */ Memory64, \

2
js/src/jit-test/tests/wasm/simd/experimental.js
View File

@ -1,4 +1,4 @@
// |jit-test| --wasm-relaxed-simd; skip-if: !wasmSimdEnabled()
// |jit-test| --wasm-relaxed-simd; skip-if: !wasmRelaxedSimdEnabled()
// Experimental opcodes. We have no text parsing support for these yet. The
// tests will be cleaned up and moved into ad-hack.js if the opcodes are