Bug 261267 helper application dialog has title issues when opening an unknown filetype

Relanding after aviary branch landing - already reviewed

browser/components/bookmarks/content/addBookmark.js

@@ -116,7 +116,6 @@ function Startup()
   var bookmarkView = document.getElementById("bookmarks-view");
 
   var shouldSetOKButton = true;
-  var dialogElement = document.documentElement;
   if ("arguments" in window) {
     var ind;
     var folderItem = null;
@@ -132,7 +131,7 @@ function Startup()
       document.getElementById("createinseparator").setAttribute("hidden", "true");
       document.getElementById("nameseparator").setAttribute("hidden", "true");
       sizeToContent();
-      dialogElement.setAttribute("title", dialogElement.getAttribute("title-selectFolder"));
+      document.title = document.documentElement.getAttribute("selectFolderTitle");
       shouldSetOKButton = false;
       if (window.arguments[2])
         folderItem = RDF.GetResource(window.arguments[2]);

browser/components/bookmarks/content/bookmarksManager.js

@@ -63,7 +63,7 @@ function Startup()
 
   bookmarksView.treeBoxObject.view.selection.select(0);
 
-  windowNode.setAttribute("title", titleString);
+  document.title = titleString;
 
   document.getElementById("CommandUpdate_Bookmarks").setAttribute("commandupdater","true");
   bookmarksView.focus();

browser/components/bookmarks/content/bookmarksProperties.js

@@ -94,11 +94,8 @@ function Init()
       field.value = value;
   }
 
-  var propsWindow = document.getElementById("bmPropsWindow");
   var nameNode = document.getElementById("name");
-  var title = propsWindow.getAttribute("title");
+  document.title = document.title.replace(/\*\*bm_title\*\*/gi, nameNode.value);
-  title = title.replace(/\*\*bm_title\*\*/gi, nameNode.value);
-  propsWindow.setAttribute("title", title);
 
   // check bookmark schedule
   var scheduleArc = RDF.GetResource(WEB_NS+"Schedule");

toolkit/components/help/content/help.js

@@ -39,7 +39,6 @@
 
 # Global Variables
 var helpBrowser;
-var helpWindow;
 var helpSearchPanel;
 var emptySearch;
 var emptySearchText
@@ -117,7 +116,6 @@ function displayTopic(topic) {
 # Initialize the Help window
 function init() {
     // Cache panel references.
-    helpWindow = document.getElementById("help");
     helpSearchPanel = document.getElementById("help-search-panel");
     helpTocPanel = document.getElementById("help-toc-panel");
     helpIndexPanel = document.getElementById("help-index-panel");
@@ -186,8 +184,7 @@ function loadHelpRDF() {
             log("Help file: " + helpFileURI + " was not found.");
         }
         try {
-            helpWindow.setAttribute("title",
+            document.title = getAttribute(helpFileDS, RDF_ROOT, NC_TITLE, "");
-                getAttribute(helpFileDS, RDF_ROOT, NC_TITLE, ""));
             helpBaseURI = getAttribute(helpFileDS, RDF_ROOT, NC_BASE, helpBaseURI);
             defaultTopic = getAttribute(helpFileDS,
                 RDF_ROOT, NC_DEFAULTTOPIC, "welcome");

toolkit/content/fontpackage.js

@@ -55,8 +55,7 @@ function onLoad()
     // if no download button
     // set title to "Install Font"
     // and set cancel button to "OK"
-    var downloadFontDialog = document.getElementById("downloadFontDialog");
+    document.title = fontPackageBundle.getString("windowTitleNoDownload");
-    downloadFontDialog.setAttribute("title", fontPackageBundle.getString("windowTitleNoDownload"));
     var cancelButton = document.getElementById("cancelButton");
     cancelButton.setAttribute("label", fontPackageBundle.getString("cancelButtonNoDownload"));
   } 

toolkit/content/widgets/wizard.xml

@@ -24,8 +24,8 @@
     </content>
     
     <implementation>
-      <property name="title" onget="return this.getAttribute('title')"
+      <property name="title" onget="return document.title;"
-                             onset="this.setAttribute('title', val);"/>
+                             onset="return document.title = val;"/>
 
       <property name="canAdvance" onget="return this._canAdvance;"
                                   onset="this._canAdvance=val; this._nextButton.setAttribute('disabled', !val);"/>

toolkit/mozapps/downloads/content/nsHelperAppDlg.js

@@ -265,7 +265,6 @@ nsUnknownContentTypeDialog.prototype = {
     // initDialog:  Fill various dialog fields with initial content.
     initDialog : function() {
          // Put file name in window title.
-         var win   = this.dialogElement( "unknownContentType" );
          var suggestedFileName = this.mLauncher.suggestedFileName;
 
          // Some URIs do not implement nsIURL, so we can't just QI.
@@ -288,7 +287,7 @@ nsUnknownContentTypeDialog.prototype = {
            
 
          this.mTitle = this.dialogElement("strings").getFormattedString("title", [fname]);
-         win.setAttribute( "title", this.mTitle );
+         this.mDialog.document.title = this.mTitle;
 
          // Put content type, filename and location into intro.
          this.initIntro(url, fname);

toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in

@@ -350,7 +350,6 @@ nsUnknownContentTypeDialog.prototype = {
     // initDialog:  Fill various dialog fields with initial content.
     initDialog : function() {
       // Put file name in window title.
-      var win   = this.dialogElement( "unknownContentType" );
       var suggestedFileName = this.mLauncher.suggestedFileName;
 
       // Some URIs do not implement nsIURL, so we can't just QI.
@@ -374,7 +373,7 @@ nsUnknownContentTypeDialog.prototype = {
       var displayName = fname.replace(/ +/g, " ");
 
       this.mTitle = this.dialogElement("strings").getFormattedString("title", [displayName]);
-      win.setAttribute( "title", this.mTitle );
+      this.mDialog.document.title = this.mTitle;
 
       // Put content type, filename and location into intro.
       this.initIntro(url, fname, displayName);

toolkit/mozapps/extensions/content/about.js

@@ -44,7 +44,7 @@ function init()
   if (creator)
     creator = creator.QueryInterface(Components.interfaces.nsIRDFLiteral).Value;
   
-  document.documentElement.setAttribute("title", extensionsStrings.getFormattedString("aboutWindowTitle", [name]));
+  document.title = extensionsStrings.getFormattedString("aboutWindowTitle", [name]);
   var extensionName = document.getElementById("extensionName");
   extensionName.setAttribute("value", name);
   var extensionVersion = document.getElementById("extensionVersion");

toolkit/mozapps/extensions/content/extensions.js

@@ -171,7 +171,7 @@ function Startup()
     gExtensionsView.selected = lastSelected;
 
   var extensionsStrings = document.getElementById("extensionsStrings");
-  document.documentElement.setAttribute("title", extensionsStrings.getString(gWindowState + "Title"));
+  document.title = extensionsStrings.getString(gWindowState + "Title");
   
   gExtensionsViewController.onCommandUpdate();