Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-23 18:26:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1517480 - Stop using graytext for labels in the "report a problem" subpanel. r=johannh

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D16870

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Dão Gottwald 2019-01-21 11:56:21 +00:00
parent a116ffc192
commit d08e2d743a
4 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browser/base/content/browser-contentblocking.js
View File

@ -791,7 +791,7 @@ var ContentBlocking = {
// they see in the report breakage dialog.
this.reportURI = gBrowser.currentURI;
let urlWithoutQuery = this.reportURI.asciiSpec.replace("?" + this.reportURI.query, "");
this.reportBreakageURL.textContent = urlWithoutQuery;
this.reportBreakageURL.value = urlWithoutQuery;
this.identityPopupMultiView.showSubView("identity-popup-breakageReportView");
},

2
browser/base/content/test/trackingUI/browser_trackingUI_report_breakage.js
View File

@ -158,7 +158,7 @@ add_task(async function testReportBreakage() {
await viewShown;
let submitButton = document.getElementById("identity-popup-breakageReportView-submit");
let reportURL = document.getElementById("identity-popup-breakageReportView-collection-url").textContent;
let reportURL = document.getElementById("identity-popup-breakageReportView-collection-url").value;
is(reportURL, TRACKING_PAGE, "Shows the correct URL in the report UI.");

6
browser/components/controlcenter/content/panel.inc.xul
View File

@ -280,11 +280,11 @@
</vbox>
<vbox id="identity-popup-breakageReportView-body" class="panel-view-body-unscrollable">
<vbox class="identity-popup-breakageReportView-collection-section">
<label class="identity-popup-breakageReportView-collection-label">&contentBlocking.breakageReportView.collection.url.label;</label>
<label id="identity-popup-breakageReportView-collection-url"/>
<label>&contentBlocking.breakageReportView.collection.url.label;</label>
<textbox readonly="true" id="identity-popup-breakageReportView-collection-url"/>
</vbox>
<vbox class="identity-popup-breakageReportView-collection-section">
<label class="identity-popup-breakageReportView-collection-label">&contentBlocking.breakageReportView.collection.comments.label;</label>
<label>&contentBlocking.breakageReportView.collection.comments.label;</label>
<textbox multiline="true" id="identity-popup-breakageReportView-collection-comments"/>
</vbox>
</vbox>

8
browser/themes/shared/controlcenter/panel.inc.css
View File

@ -345,14 +345,6 @@ description#identity-popup-content-verifier,
font-size: 110%;
}
.identity-popup-breakageReportView-collection-label {
color: graytext;
}
#identity-popup-breakageReportView-collection-url {
word-wrap: break-word;
}
.identity-popup-breakageReportView-collection-section {
margin-bottom: 16px;
}