Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Backed out changeset c35a3bb94b22 (bug 1845356) for causing bc failures in browser_feature_callout_position.js CLOSED TREE

Browse Source
This commit is contained in:
Cristian Tuns 2023-08-28 17:53:19 -04:00
parent de85854ec4
commit d0d03369a4
8 changed files with 16 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browser/base/content/navigator-toolbox.inc.xhtml
View File

@ -43,7 +43,7 @@
<hbox id="TabsToolbar-customization-target" flex="1">
<toolbarbutton id="firefox-view-button"
class="toolbarbutton-1 chromeclass-toolbar-additional"
data-l10n-id="toolbar-button-firefox-view-2"
data-l10n-id="toolbar-button-firefox-view"
role="button"
aria-pressed="false"
oncommand="FirefoxViewHandler.openTab(event);"

14
browser/components/firefoxview/firefoxview.css
View File

@ -109,10 +109,6 @@ body > main > details {
.brand-logo > .brand-feature-name {
display: none;
}
#logo-container {
padding: 0;
}
}
@media (max-width: 65rem) {
@ -138,12 +134,22 @@ body > main > details {
.brand-logo {
display: flex;
justify-content: space-between;
align-items: center;
font-size: 1.75em;
white-space: nowrap;
}
.brand-logo > .brand-icon {
display: inline-block;
background: url("chrome://branding/content/about-logo.png") no-repeat center;
background-size: 32px;
min-width: 40px;
height: 32px;
}
.brand-logo > .brand-feature-name {
margin-inline-start: 8px;
flex: 1 1 auto;
font-weight: 600;
}

1
browser/components/firefoxview/firefoxview.html
View File

@ -49,6 +49,7 @@
<body>
<div id="logo-container" class="content-container">
<div class="brand-logo">
<span class="brand-icon"></span>
<span
class="brand-feature-name"
data-l10n-id="firefoxview-page-title"

2
browser/components/firefoxview/tests/browser/browser_feature_callout.js
View File

@ -219,7 +219,7 @@ add_task(async function feature_callout_arrow_is_not_flipped_on_ltr() {
const testMessage = getCalloutMessageById("FIREFOX_VIEW_FEATURE_TOUR");
testMessage.message.content.screens[0].anchors[0].arrow_position = "start";
testMessage.message.content.screens[0].anchors[0].selector =
"span.brand-feature-name";
"span.brand-icon";
const sandbox = createSandboxWithCalloutTriggerStub(testMessage);
await BrowserTestUtils.withNewTab(
{

4
browser/locales/en-US/browser/firefoxView.ftl
View File

@ -2,9 +2,9 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
toolbar-button-firefox-view-2 =
toolbar-button-firefox-view =
.label = { -firefoxview-brand-name }
.tooltiptext = View recent browsing across windows and devices
.tooltiptext = { -firefoxview-brand-name }
menu-tools-firefox-view =
.label = { -firefoxview-brand-name }

14
browser/themes/shared/icons/firefox-view.svg
View File

@ -1,14 +0,0 @@
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="none">
<g fill="context-fill" clip-path="url(#a)">
<path d="M4 2a.5.5 0 0 0-.5.5H2a2 2 0 0 1 2-2h8a2 2 0 0 1 2 2h-1.5A.5.5 0 0 0 12 2H4Zm2 6h4v1.5H6V8Z"/>
<path fill-rule="evenodd" d="M2 4a2 2 0 0 0-2 2v8a2 2 0 0 0 2 2h12a2 2 0 0 0 2-2V6a2 2 0 0 0-2-2H2Zm-.5 2a.5.5 0 0 1 .5-.5h12a.5.5 0 0 1 .5.5v8a.5.5 0 0 1-.5.5H2a.5.5 0 0 1-.5-.5V6Z" clip-rule="evenodd"/>
</g>
<defs>
<clipPath id="a">
<path fill="context-stroke" d="M0 0h16v16H0z"/>
</clipPath>
</defs>
</svg>
Side by Side

Before

Width:  |  Height:  |  Size: 776 B

1
browser/themes/shared/jar.inc.mn
View File

@ -164,7 +164,6 @@
skin/classic/browser/edit-cut.svg (../shared/icons/edit-cut.svg)
skin/classic/browser/edit-paste.svg (../shared/icons/edit-paste.svg)
skin/classic/browser/fingerprint.svg (../shared/icons/fingerprint.svg)
skin/classic/browser/firefox-view.svg (../shared/icons/firefox-view.svg)
skin/classic/browser/forget.svg (../shared/icons/forget.svg)
skin/classic/browser/forward.svg (../shared/icons/forward.svg)
skin/classic/browser/fullscreen.svg (../shared/icons/fullscreen.svg)

2
browser/themes/shared/toolbarbutton-icons.css
View File

@ -466,5 +466,5 @@ toolbarbutton.bookmark-item {
}
#firefox-view-button {
list-style-image: url("chrome://browser/skin/firefox-view.svg");
list-style-image: url("chrome://branding/content/icon32.png");
}