check in comment about history code may need to change later. No code change.

This commit is contained in:
ftang%netscape.com 1998-09-08 20:21:23 +00:00
parent ba20e43386
commit d0dce1c383
4 changed files with 13 additions and 0 deletions

View File

@ -834,6 +834,8 @@ void CMessageFolderView::SelectionChanged()
}
if (url && *entryName)
{
// i18n problem- we need to convert entryName to UTF8 before call SHIST_CreateHistryEntry
// We didn't do that because mail/news is not alive yet....
History_entry* theNewEntry = SHIST_CreateHistoryEntry(
url,
entryName);

View File

@ -2682,6 +2682,9 @@ void CThreadView::UpdateHistoryEntry()
if (url && *entryName)
{
LO_DiscardDocument(*mContext);
// i18n problem- we need to convert entryName to UTF8 before call SHIST_CreateHistryEntry
// We didn't do that because mail/news is not alive yet....
History_entry* theNewEntry = ::SHIST_CreateHistoryEntry(
url,
entryName);

View File

@ -1142,6 +1142,9 @@ void CBrowserContext::LayoutNewDocument(
theCurrentView->LayoutNewDocument(inURL, inWidth, inHeight, inMarginWidth, inMarginHeight);
CStr31 theTitle = CFileMgr::FileNameFromURL(inURL->address);
// i18n problem- we may need to convert theTitle to UTF8 before call SHIST_CreateHistryEntry
// However, currently theTitle is only URL encoded file name which have no 8bit data. Should double check again later.
History_entry* theNewEntry = SHIST_CreateHistoryEntry(inURL, theTitle);
SHIST_AddDocument(*this, theNewEntry);

View File

@ -188,6 +188,8 @@ hist_go(JSContext *cx, JSObject *obj,
he = SHIST_GetObjectNum(&context->hist, index);
}
else if (JSVAL_IS_STRING(argv[0])) {
/* i18n problem */
/* I believe this part is broken for I18N. Particular after we change the he->title to UTF8 */
char * argv_str = JS_GetStringBytes(JSVAL_TO_STRING(argv[0]));
histlist = SHIST_GetList(context);
if (histlist)
@ -260,6 +262,9 @@ hist_toString(JSContext *cx, JSObject *obj,
"<TABLE BORDER=0 ALIGN=center VALIGN=top HSPACE=8>");
while ((he = XP_ListNextObject(histlist)) != 0) {
StrAllocCat(bytes, "<TR><TD VALIGN=top><STRONG>");
/* i18n problem */
/* I believe this part is broken for I18N. Particular after we change the he->title to UTF8 */
/* force the output HTML to display as in UTF8 will fix it. */
StrAllocCat(bytes, he->title);
StrAllocCat(bytes, "</STRONG></TD><TD>&nbsp;</TD>"
"<TD VALIGN=top><A HREF=\"");