Bug 1856795 - Remove redundant member init r=emilio

Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Differential Revision: https://phabricator.services.mozilla.com/D190002

accessible/atk/ApplicationAccessibleWrap.cpp

@@ -17,8 +17,7 @@ using namespace mozilla::a11y;
 
 // ApplicationAccessibleWrap
 
-ApplicationAccessibleWrap::ApplicationAccessibleWrap()
+ApplicationAccessibleWrap::ApplicationAccessibleWrap() {}
-    : ApplicationAccessible() {}
 
 ApplicationAccessibleWrap::~ApplicationAccessibleWrap() {
   AccessibleWrap::ShutdownAtkObject();

accessible/atk/RootAccessibleWrap.cpp

@@ -13,8 +13,7 @@
 
 using namespace mozilla::a11y;
 
-GtkWindowAccessible::GtkWindowAccessible(AtkObject* aAccessible)
+GtkWindowAccessible::GtkWindowAccessible(AtkObject* aAccessible) {
-    : DummyAccessible() {
   g_object_ref(aAccessible);
   mAtkObject = aAccessible;
 }

accessible/base/nsAccessibilityService.cpp

@@ -397,9 +397,7 @@ xpcAccessibleApplication* nsAccessibilityService::gXPCApplicationAccessible =
 uint32_t nsAccessibilityService::gConsumers = 0;
 
 nsAccessibilityService::nsAccessibilityService()
-    : DocManager(),
+    : mHTMLMarkupMap(ArrayLength(sHTMLMarkupMapList)),
-      FocusManager(),
-      mHTMLMarkupMap(ArrayLength(sHTMLMarkupMapList)),
       mMathMLMarkupMap(ArrayLength(sMathMLMarkupMapList)),
       mXULMarkupMap(ArrayLength(sXULMarkupMapList)) {}
 

accessible/generic/LocalAccessible.cpp

@@ -101,12 +101,10 @@ NS_IMPL_CYCLE_COLLECTING_ADDREF(LocalAccessible)
 NS_IMPL_CYCLE_COLLECTING_RELEASE_WITH_DESTROY(LocalAccessible, LastRelease())
 
 LocalAccessible::LocalAccessible(nsIContent* aContent, DocAccessible* aDoc)
-    : Accessible(),
+    : mContent(aContent),
-      mContent(aContent),
       mDoc(aDoc),
       mParent(nullptr),
       mIndexInParent(-1),
-      mBounds(),
       mFirstLineStart(-1),
       mStateFlags(0),
       mContextFlags(0),

accessible/ipc/RemoteAccessible.h

@@ -413,8 +413,7 @@ class RemoteAccessible : public Accessible, public HyperTextAccessibleBase {
   }
 
   explicit RemoteAccessible(DocAccessibleParent* aThisAsDoc)
-      : Accessible(),
+      : mParent(kNoParent),
-        mParent(kNoParent),
         mDoc(aThisAsDoc),
         mWrapper(0),
         mID(0),

devtools/shared/heapsnapshot/tests/gtest/DeserializedStackFrameUbiStackFrames.cpp

@@ -18,7 +18,7 @@ using testing::ReturnRef;
 
 // A mock DeserializedStackFrame for testing.
 struct MockDeserializedStackFrame : public DeserializedStackFrame {
-  MockDeserializedStackFrame() : DeserializedStackFrame() {}
+  MockDeserializedStackFrame() {}
 };
 
 DEF_TEST(DeserializedStackFrameUbiStackFrames, {

devtools/shared/heapsnapshot/tests/gtest/DevTools.h

@@ -99,7 +99,7 @@ class MOZ_STACK_CLASS FakeNode {
   JS::Zone* zone;
   size_t size;
 
-  explicit FakeNode() : edges(), compartment(nullptr), zone(nullptr), size(1) {}
+  explicit FakeNode() : compartment(nullptr), zone(nullptr), size(1) {}
 };
 
 namespace JS {

docshell/base/nsDocShellLoadState.cpp

@@ -222,7 +222,6 @@ nsDocShellLoadState::nsDocShellLoadState(nsIURI* aURI, uint64_t aLoadIdentifier)
       mOriginalFrameSrc(false),
       mIsFormSubmission(false),
       mLoadType(LOAD_NORMAL),
-      mTarget(),
       mSrcdocData(VoidString()),
       mLoadFlags(0),
       mInternalLoadFlags(0),

dom/animation/Animation.cpp

@@ -2051,7 +2051,7 @@ void Animation::UpdatePendingAnimationTracker(AnimationTimeline* aOldTimeline,
 class AsyncFinishNotification : public MicroTaskRunnable {
  public:
   explicit AsyncFinishNotification(Animation* aAnimation)
-      : MicroTaskRunnable(), mAnimation(aAnimation) {}
+      : mAnimation(aAnimation) {}
 
   virtual void Run(AutoSlowOperation& aAso) override {
     mAnimation->DoFinishNotificationImmediately(this);

dom/base/FragmentOrElement.cpp

@@ -559,8 +559,7 @@ size_t nsIContent::nsExtendedContentSlots::SizeOfExcludingThis(
   return 0;
 }
 
-FragmentOrElement::nsDOMSlots::nsDOMSlots()
+FragmentOrElement::nsDOMSlots::nsDOMSlots() : mDataset(nullptr) {
-    : nsIContent::nsContentSlots(), mDataset(nullptr) {
   MOZ_COUNT_CTOR(nsDOMSlots);
 }
 

dom/base/ImageEncoder.cpp

@@ -84,7 +84,6 @@ class EncodingCompleteEvent final : public DiscardableRunnable {
       EncodeCompleteCallback* aEncodeCompleteCallback)
       : DiscardableRunnable("EncodingCompleteEvent"),
         mImgSize(0),
-        mType(),
         mImgData(nullptr),
         mEncodeCompleteCallback(aEncodeCompleteCallback),
         mFailed(false) {

dom/base/InProcessBrowserChildMessageManager.cpp

@@ -66,7 +66,7 @@ class nsAsyncMessageToParent : public nsSameProcessAsyncMessageBase,
  public:
   explicit nsAsyncMessageToParent(
       InProcessBrowserChildMessageManager* aBrowserChild)
-      : nsSameProcessAsyncMessageBase(), mBrowserChild(aBrowserChild) {}
+      : mBrowserChild(aBrowserChild) {}
 
   virtual nsresult HandleMessage() override {
     RefPtr<nsFrameLoader> fl = mBrowserChild->GetFrameLoader();

dom/base/nsFrameLoader.cpp

@@ -2952,8 +2952,7 @@ class nsAsyncMessageToChild : public nsSameProcessAsyncMessageBase,
                               public Runnable {
  public:
   explicit nsAsyncMessageToChild(nsFrameLoader* aFrameLoader)
-      : nsSameProcessAsyncMessageBase(),
+      : mozilla::Runnable("nsAsyncMessageToChild"),
-        mozilla::Runnable("nsAsyncMessageToChild"),
         mFrameLoader(aFrameLoader) {}
 
   NS_IMETHOD Run() override {

dom/base/nsFrameMessageManager.cpp

@@ -1403,8 +1403,7 @@ class nsAsyncMessageToSameProcessChild : public nsSameProcessAsyncMessageBase,
                                          public Runnable {
  public:
   nsAsyncMessageToSameProcessChild()
-      : nsSameProcessAsyncMessageBase(),
+      : mozilla::Runnable("nsAsyncMessageToSameProcessChild") {}
-        mozilla::Runnable("nsAsyncMessageToSameProcessChild") {}
   NS_IMETHOD Run() override {
     nsFrameMessageManager* ppm =
         nsFrameMessageManager::GetChildProcessManager();
@@ -1498,7 +1497,7 @@ class nsAsyncMessageToSameProcessParent
     : public nsSameProcessAsyncMessageBase,
       public SameProcessMessageQueue::Runnable {
  public:
-  nsAsyncMessageToSameProcessParent() : nsSameProcessAsyncMessageBase() {}
+  nsAsyncMessageToSameProcessParent() {}
   nsresult HandleMessage() override {
     nsFrameMessageManager* ppm =
         nsFrameMessageManager::sSameProcessParentManager;

dom/base/nsGlobalWindowOuter.cpp

@@ -1261,7 +1261,7 @@ const nsOuterWindowProxy nsOuterWindowProxy::singleton;
 
 class nsChromeOuterWindowProxy : public nsOuterWindowProxy {
  public:
-  constexpr nsChromeOuterWindowProxy() : nsOuterWindowProxy() {}
+  constexpr nsChromeOuterWindowProxy() {}
 
   const char* className(JSContext* cx,
                         JS::Handle<JSObject*> wrapper) const override;

dom/base/nsIContent.h

@@ -661,7 +661,7 @@ class nsIContent : public nsINode {
 
   class nsContentSlots : public nsINode::nsSlots {
    public:
-    nsContentSlots() : nsINode::nsSlots(), mExtendedSlots(0) {}
+    nsContentSlots() : mExtendedSlots(0) {}
 
     ~nsContentSlots() {
       if (!(mExtendedSlots & sNonOwningExtendedSlotsFlag)) {

dom/base/nsImageLoadingContent.cpp

@@ -347,8 +347,7 @@ already_AddRefed<Promise> nsImageLoadingContent::QueueDecodeAsync(
    public:
     QueueDecodeTask(nsImageLoadingContent* aOwner, Promise* aPromise,
                     uint32_t aRequestGeneration)
-        : MicroTaskRunnable(),
+        : mOwner(aOwner),
-          mOwner(aOwner),
           mPromise(aPromise),
           mRequestGeneration(aRequestGeneration) {}
 

dom/base/nsWindowSizes.h

@@ -193,8 +193,6 @@ class nsWindowSizes {
   explicit nsWindowSizes(mozilla::SizeOfState& aState)
       : FOR_EACH_SIZE(ZERO_SIZE) mDOMEventTargetsCount(0),
         mDOMEventListenersCount(0),
-        mArenaSizes(),
-        mStyleSizes(),
         mState(aState) {}
 
   void addToTabSizes(nsTabSizes* aSizes) const {

dom/bindings/nsScriptError.cpp

@@ -21,16 +21,10 @@
 #include "mozilla/BasePrincipal.h"
 
 nsScriptErrorBase::nsScriptErrorBase()
-    : mMessage(),
+    : mSourceId(0),
-      mMessageName(),
-      mSourceName(),
-      mCssSelectors(),
-      mSourceId(0),
       mLineNumber(0),
-      mSourceLine(),
       mColumnNumber(0),
       mFlags(0),
-      mCategory(),
       mOuterWindowID(0),
       mInnerWindowID(0),
       mMicroSecondTimeStamp(0),
@@ -473,11 +467,7 @@ bool nsScriptErrorBase::ComputeIsFromChromeContext(
 NS_IMPL_ISUPPORTS(nsScriptError, nsIConsoleMessage, nsIScriptError)
 
 nsScriptErrorNote::nsScriptErrorNote()
-    : mMessage(),
+    : mSourceId(0), mLineNumber(0), mColumnNumber(0) {}
-      mSourceName(),
-      mSourceId(0),
-      mLineNumber(0),
-      mColumnNumber(0) {}
 
 nsScriptErrorNote::~nsScriptErrorNote() = default;
 

dom/canvas/CanvasPattern.cpp

@@ -14,7 +14,6 @@ CanvasPattern::CanvasPattern(CanvasRenderingContext2D* aContext,
     : mContext(aContext),
       mSurface(aSurface),
       mPrincipal(principalForSecurityCheck),
-      mTransform(),
       mForceWriteOnly(forceWriteOnly),
       mCORSUsed(CORSUsed),
       mRepeat(aRepeat) {}

dom/debugger/DebuggerNotificationManager.h

@@ -37,7 +37,7 @@ class DebuggerNotificationManager final : public nsISupports {
   }
 
   explicit DebuggerNotificationManager(nsIGlobalObject* aDebuggeeGlobal)
-      : mDebuggeeGlobal(aDebuggeeGlobal), mNotificationObservers() {}
+      : mDebuggeeGlobal(aDebuggeeGlobal) {}
 
   bool Attach(DebuggerNotificationObserver* aObserver);
   bool Detach(DebuggerNotificationObserver* aObserver);

dom/debugger/DebuggerNotificationObserver.cpp

@@ -39,7 +39,7 @@ DebuggerNotificationObserver::Constructor(GlobalObject& aGlobal,
 
 DebuggerNotificationObserver::DebuggerNotificationObserver(
     nsIGlobalObject* aOwnerGlobal)
-    : mEventListenerCallbacks(), mOwnerGlobal(aOwnerGlobal) {}
+    : mOwnerGlobal(aOwnerGlobal) {}
 
 JSObject* DebuggerNotificationObserver::WrapObject(
     JSContext* aCx, JS::Handle<JSObject*> aGivenProto) {

dom/events/EventListenerManager.cpp

@@ -134,7 +134,7 @@ EventListenerManagerBase::EventListenerManagerBase()
 }
 
 EventListenerManager::EventListenerManager(EventTarget* aTarget)
-    : EventListenerManagerBase(), mTarget(aTarget) {
+    : mTarget(aTarget) {
   NS_ASSERTION(aTarget, "unexpected null pointer");
 
   if (mIsMainThreadELM) {

dom/fs/api/FileSystemWritableFileStream.cpp

@@ -219,7 +219,6 @@ FileSystemWritableFileStream::FileSystemWritableFileStream(
       mManager(aManager),
       mActor(std::move(aActor)),
       mTaskQueue(aTaskQueue),
-      mWorkerRef(),
       mStreamParams(std::move(aStreamParams)),
       mMetadata(std::move(aMetadata)),
       mCloseHandler(MakeAndAddRef<CloseHandler>()),

dom/fs/child/FileSystemDirectoryIteratorFactory.cpp

@@ -81,7 +81,6 @@ class DoubleBufferQueueImpl
   using DataType = FileSystemEntryMetadata;
   explicit DoubleBufferQueueImpl(const FileSystemEntryMetadata& aMetadata)
       : mEntryId(aMetadata.entryId()),
-        mData(),
         mWithinPageEnd(0u),
         mWithinPageIndex(0u),
         mCurrentPageIsLastPage(true),

dom/fs/test/gtest/FileSystemMocks.h

@@ -127,10 +127,7 @@ class TestPromiseListener : public PromiseNativeHandler,
                             public WaitablePromiseListener {
  public:
   TestPromiseListener()
-      : mIsDone(std::make_shared<bool>(false)),
+      : mIsDone(std::make_shared<bool>(false)), mOnSuccess(), mOnError() {
-        mTimer(),
-        mOnSuccess(),
-        mOnError() {
     ClearDone();
   }
 

dom/html/ConstraintValidation.cpp

@@ -56,7 +56,7 @@ bool ConstraintValidation::CheckValidity() {
   return nsIConstraintValidation::CheckValidity(*content);
 }
 
-ConstraintValidation::ConstraintValidation() : nsIConstraintValidation() {}
+ConstraintValidation::ConstraintValidation() {}
 
 void ConstraintValidation::SetCustomValidity(const nsAString& aError) {
   mCustomValidity.Assign(aError);

dom/html/HTMLImageElement.cpp

@@ -84,8 +84,7 @@ class ImageLoadTask final : public MicroTaskRunnable {
  public:
   ImageLoadTask(HTMLImageElement* aElement, bool aAlwaysLoad,
                 bool aUseUrgentStartForChannel)
-      : MicroTaskRunnable(),
+      : mElement(aElement),
-        mElement(aElement),
         mAlwaysLoad(aAlwaysLoad),
         mUseUrgentStartForChannel(aUseUrgentStartForChannel) {
     mDocument = aElement->OwnerDoc();

dom/html/ImageDocument.cpp

@@ -122,8 +122,7 @@ ImageListener::OnStartRequest(nsIRequest* request) {
 }
 
 ImageDocument::ImageDocument()
-    : MediaDocument(),
+    : mVisibleWidth(0.0),
-      mVisibleWidth(0.0),
       mVisibleHeight(0.0),
       mImageWidth(0),
       mImageHeight(0),

dom/html/MediaDocument.cpp

@@ -106,8 +106,7 @@ const char* const MediaDocument::sFormatNames[4] = {
     ""                       // eWithDimAndFile
 };
 
-MediaDocument::MediaDocument()
+MediaDocument::MediaDocument() : mDidInitialDocumentSetup(false) {
-    : nsHTMLDocument(), mDidInitialDocumentSetup(false) {
   mCompatMode = eCompatibility_FullStandards;
 }
 MediaDocument::~MediaDocument() = default;

dom/html/nsGenericHTMLFrameElement.h

@@ -46,7 +46,6 @@ class nsGenericHTMLFrameElement : public nsGenericHTMLElement,
       already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo,
       mozilla::dom::FromParser aFromParser)
       : nsGenericHTMLElement(std::move(aNodeInfo)),
-        nsBrowserElement(),
         mSrcLoadHappened(false),
         mNetworkCreated(aFromParser == mozilla::dom::FROM_PARSER_NETWORK),
         mBrowserFrameListenersRegistered(false),

dom/indexedDB/ActorsChild.cpp

@@ -144,9 +144,7 @@ class MOZ_STACK_CLASS AutoSetCurrentTransaction final {
   AutoSetCurrentTransaction& operator=(AutoSetCurrentTransaction&&) = delete;
 
   explicit AutoSetCurrentTransaction(Maybe<IDBTransaction&> aTransaction)
-      : mTransaction(aTransaction),
+      : mTransaction(aTransaction), mThreadLocal(nullptr) {
-        mPreviousTransaction(),
-        mThreadLocal(nullptr) {
     if (aTransaction) {
       BackgroundChildImpl::ThreadLocal* threadLocal =
           BackgroundChildImpl::GetThreadLocalForCurrentThread();

dom/ipc/BrowserParent.cpp

@@ -284,8 +284,6 @@ BrowserParent::BrowserParent(ContentParent* aManager, const TabId& aTabId,
       mBrowserBridgeParent(nullptr),
       mBrowserHost(nullptr),
       mContentCache(*this),
-      mRemoteLayerTreeOwner{},
-      mChildToParentConversionMatrix{},
       mRect(0, 0, 0, 0),
       mDimensions(0, 0),
       mDPI(0),
@@ -293,10 +291,7 @@ BrowserParent::BrowserParent(ContentParent* aManager, const TabId& aTabId,
       mDefaultScale(0),
       mUpdatedDimensions(false),
       mSizeMode(nsSizeMode_Normal),
-      mClientOffset{},
-      mChromeOffset{},
       mCreatingWindow(false),
-      mDelayedFrameScripts{},
       mVsyncParent(nullptr),
       mMarkedDestroying(false),
       mIsDestroyed(false),

dom/ipc/SharedMap.cpp

@@ -39,7 +39,7 @@ static inline void AlignTo(size_t* aOffset, size_t aAlign) {
   }
 }
 
-SharedMap::SharedMap() : DOMEventTargetHelper() {}
+SharedMap::SharedMap() {}
 
 SharedMap::SharedMap(nsIGlobalObject* aGlobal, const FileDescriptor& aMapFile,
                      size_t aMapSize, nsTArray<RefPtr<BlobImpl>>&& aBlobs)
@@ -240,7 +240,7 @@ void SharedMap::MaybeRebuild() const {
   Unused << const_cast<SharedMap*>(this)->MaybeRebuild();
 }
 
-WritableSharedMap::WritableSharedMap() : SharedMap() {
+WritableSharedMap::WritableSharedMap() {
   mWritable = true;
   // Serialize the initial empty contents of the map immediately so that we
   // always have a file descriptor to send to callers of CloneMapFile().

dom/media/ADTSDemuxer.cpp

@@ -118,7 +118,7 @@ class FrameHeader {
 // header and side info.
 class Frame {
  public:
-  Frame() : mOffset(0), mHeader() {}
+  Frame() : mOffset(0) {}
 
   uint64_t Offset() const { return mOffset; }
   size_t Length() const {

dom/media/CanvasCaptureMediaStream.cpp

@@ -23,9 +23,7 @@ namespace mozilla::dom {
 
 OutputStreamDriver::OutputStreamDriver(SourceMediaTrack* aSourceStream,
                                        const PrincipalHandle& aPrincipalHandle)
-    : FrameCaptureListener(),
+    : mSourceStream(aSourceStream), mPrincipalHandle(aPrincipalHandle) {
-      mSourceStream(aSourceStream),
-      mPrincipalHandle(aPrincipalHandle) {
   MOZ_ASSERT(NS_IsMainThread());
   MOZ_ASSERT(mSourceStream);
 }

dom/media/DeviceInputTrack.cpp

@@ -466,8 +466,7 @@ NonNativeInputTrack::NonNativeInputTrack(
     const PrincipalHandle& aPrincipalHandle)
     : DeviceInputTrack(aSampleRate, aDeviceId, aPrincipalHandle),
       mAudioSource(nullptr),
-      mSourceIdNumber(0),
+      mSourceIdNumber(0) {}
-      mGraphDriverThreadId(std::thread::id()) {}
 
 void NonNativeInputTrack::DestroyImpl() {
   MOZ_ASSERT(mGraph->OnGraphThreadOrNotRunning());

dom/media/gtest/TestWebMWriter.cpp

@@ -66,7 +66,7 @@ const uint32_t FIXED_FRAMESIZE = 500;
 
 class TestWebMWriter : public WebMWriter {
  public:
-  TestWebMWriter() : WebMWriter() {}
+  TestWebMWriter() {}
 
   // When we append an I-Frame into WebM muxer, the muxer will treat previous
   // data as "a cluster".

dom/media/mp4/SinfParser.cpp

@@ -11,7 +11,7 @@
 
 namespace mozilla {
 
-Sinf::Sinf(Box& aBox) : mDefaultIVSize(0), mDefaultEncryptionType() {
+Sinf::Sinf(Box& aBox) : mDefaultIVSize(0) {
   SinfParser parser(aBox);
   if (parser.GetSinf().IsValid()) {
     *this = parser.GetSinf();

dom/media/mp4/SinfParser.h

@@ -18,7 +18,7 @@ class Sinf : public Atom {
  public:
   Sinf()
       : mDefaultIVSize(0),
-        mDefaultEncryptionType(),
+
         mDefaultCryptByteBlock(0),
         mDefaultSkipByteBlock(0) {}
   explicit Sinf(Box& aBox);

dom/media/ogg/OggWriter.cpp

@@ -10,8 +10,7 @@
 
 namespace mozilla {
 
-OggWriter::OggWriter()
+OggWriter::OggWriter() : mOggStreamState(), mOggPage(), mPacket() {
-    : ContainerWriter(), mOggStreamState(), mOggPage(), mPacket() {
   if (NS_FAILED(Init())) {
     LOG("ERROR! Fail to initialize the OggWriter.");
   }

dom/media/webaudio/AudioListener.cpp

@@ -15,7 +15,7 @@ namespace mozilla::dom {
 NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(AudioListener, mContext)
 
 AudioListenerEngine::AudioListenerEngine()
-    : mPosition(), mFrontVector(0., 0., -1.), mRightVector(1., 0., 0.) {}
+    : mFrontVector(0., 0., -1.), mRightVector(1., 0., 0.) {}
 
 void AudioListenerEngine::RecvListenerEngineEvent(
     AudioListenerEngine::AudioListenerParameter aParameter,
@@ -46,7 +46,7 @@ const ThreeDPoint& AudioListenerEngine::RightVector() const {
 AudioListener::AudioListener(AudioContext* aContext)
     : mContext(aContext),
       mEngine(new AudioListenerEngine()),
-      mPosition(),
+
       mFrontVector(0., 0., -1.),
       mRightVector(1., 0., 0.) {
   MOZ_ASSERT(aContext);

dom/media/webaudio/blink/ReverbConvolver.cpp

@@ -62,7 +62,6 @@ ReverbConvolver::ReverbConvolver(const float* impulseResponseData,
                                  bool useBackgroundThreads,
                                  bool* aAllocationFailure)
     : m_impulseResponseLength(impulseResponseLength),
-      m_accumulationBuffer(),
       m_inputBuffer(InputBufferSize),
       m_backgroundThread("ConvolverWorker"),
       m_backgroundThreadMonitor("ConvolverMonitor"),

dom/media/webm/WebMWriter.cpp

@@ -10,8 +10,7 @@
 
 namespace mozilla {
 
-WebMWriter::WebMWriter()
+WebMWriter::WebMWriter() : mEbmlComposer(new EbmlComposer()) {}
-    : ContainerWriter(), mEbmlComposer(new EbmlComposer()) {}
 
 WebMWriter::~WebMWriter() {
   // Out-of-line dtor so mEbmlComposer UniquePtr can delete a complete type.

dom/media/webrtc/jsapi/PeerConnectionImpl.cpp

@@ -331,7 +331,6 @@ bool IsPrivateBrowsing(nsPIDOMWindowInner* aWindow) {
 PeerConnectionImpl::PeerConnectionImpl(const GlobalObject* aGlobal)
     : mTimeCard(MOZ_LOG_TEST(logModuleInfo, LogLevel::Error) ? create_timecard()
                                                              : nullptr),
-      mJsConfiguration(),
       mSignalingState(RTCSignalingState::Stable),
       mIceConnectionState(RTCIceConnectionState::New),
       mIceGatheringState(RTCIceGatheringState::New),

dom/media/webrtc/libwebrtcglue/AudioConduit.cpp

@@ -156,7 +156,6 @@ WebrtcAudioConduit::WebrtcAudioConduit(
     : mCall(std::move(aCall)),
       mSendTransport(this),
       mRecvTransport(this),
-      mRecvStreamConfig(),
       mRecvStream(nullptr),
       mSendStreamConfig(&mSendTransport),
       mSendStream(nullptr),

dom/media/webrtc/sdp/SdpAttribute.h

@@ -738,7 +738,7 @@ class SdpImageattrAttributeList : public SdpAttribute {
 
   class Imageattr {
    public:
-    Imageattr() : pt(), sendAll(false), recvAll(false) {}
+    Imageattr() : sendAll(false), recvAll(false) {}
     void Serialize(std::ostream& os) const;
     // TODO: Remove this Bug 1469702
     bool Parse(std::istream& is, std::string* error);

dom/media/webrtc/transport/nricectx.cpp

@@ -261,7 +261,6 @@ NrIceCtx::NrIceCtx(const std::string& name)
       gathering_state_(ICE_CTX_GATHER_INIT),
       name_(name),
       ice_controlling_set_(false),
-      streams_(),
       ctx_(nullptr),
       peer_(nullptr),
       ice_handler_vtbl_(nullptr),

dom/media/webrtc/transport/nriceresolverfake.cpp

@@ -57,10 +57,7 @@ extern "C" {
 namespace mozilla {
 
 NrIceResolverFake::NrIceResolverFake()
-    : vtbl_(new nr_resolver_vtbl),
+    : vtbl_(new nr_resolver_vtbl), delay_ms_(100), allocated_resolvers_(0) {
-      addrs_(),
-      delay_ms_(100),
-      allocated_resolvers_(0) {
   vtbl_->destroy = &NrIceResolverFake::destroy;
   vtbl_->resolve = &NrIceResolverFake::resolve;
   vtbl_->cancel = &NrIceResolverFake::cancel;

dom/media/webrtc/transport/nrinterfaceprioritizer.cpp

@@ -17,10 +17,7 @@ namespace {
 class LocalAddress {
  public:
   LocalAddress()
-      : ifname_(),
+      : is_vpn_(-1),
-        addr_(),
-        key_(),
-        is_vpn_(-1),
         estimated_speed_(-1),
         type_preference_(-1),
         ip_version_(-1) {}
@@ -164,7 +161,7 @@ class LocalAddress {
 
 class InterfacePrioritizer {
  public:
-  InterfacePrioritizer() : local_addrs_(), preference_map_(), sorted_(false) {}
+  InterfacePrioritizer() : sorted_(false) {}
 
   int add(const nr_local_addr* iface) {
     LocalAddress addr;

dom/media/webrtc/transport/stun_socket_filter.cpp

@@ -100,7 +100,7 @@ static std::ostream& operator<<(std::ostream& aStream, UINT12 aId) {
 
 class STUNUDPSocketFilter : public nsISocketFilter {
  public:
-  STUNUDPSocketFilter() : white_list_(), pending_requests_() {}
+  STUNUDPSocketFilter() {}
 
   // Allocated/freed and used on the PBackground IPC thread
   NS_DECL_ISUPPORTS
@@ -287,8 +287,7 @@ class PendingSTUNId {
 
 class STUNTCPSocketFilter : public nsISocketFilter {
  public:
-  STUNTCPSocketFilter()
+  STUNTCPSocketFilter() : white_listed_(false) {}
-      : white_listed_(false), pending_request_ids_(), response_allowed_ids_() {}
 
   // Allocated/freed and used on the PBackground IPC thread
   NS_DECL_ISUPPORTS

dom/media/webrtc/transport/test/buffered_stun_socket_unittest.cpp

@@ -33,8 +33,7 @@ static size_t kStunMessageLen = sizeof(kStunMessage);
 
 class BufferedStunSocketTest : public MtransportTest {
  public:
-  BufferedStunSocketTest()
+  BufferedStunSocketTest() : dummy_(nullptr), test_socket_(nullptr) {}
-      : MtransportTest(), dummy_(nullptr), test_socket_(nullptr) {}
 
   ~BufferedStunSocketTest() { nr_socket_destroy(&test_socket_); }
 

dom/media/webrtc/transport/test/ice_unittest.cpp

@@ -115,7 +115,7 @@ static std::string Resolve(const std::string& fqdn, int address_family) {
 
 class StunTest : public MtransportTest {
  public:
-  StunTest() : MtransportTest() {}
+  StunTest() {}
 
   void SetUp() override {
     MtransportTest::SetUp();
@@ -353,7 +353,6 @@ class IceTestPeer : public sigslot::has_slots<> {
       : name_(name),
         ice_ctx_(NrIceCtx::Create(name)),
         offerer_(offerer),
-        candidates_(),
         stream_counter_(0),
         shutting_down_(false),
         gathering_complete_(false),
@@ -363,7 +362,6 @@ class IceTestPeer : public sigslot::has_slots<> {
         ice_reached_checking_(false),
         received_(0),
         sent_(0),
-        fake_resolver_(),
         dns_resolver_(new NrIceResolver()),
         remote_(nullptr),
         candidate_filter_(nullptr),

dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp

@@ -32,8 +32,7 @@ namespace {
 
 class MultiTcpSocketTest : public MtransportTest {
  public:
-  MultiTcpSocketTest()
+  MultiTcpSocketTest() : socks(3, nullptr), readable(false) {}
-      : MtransportTest(), socks(3, nullptr), readable(false), ice_ctx_() {}
 
   void SetUp() {
     MtransportTest::SetUp();

dom/media/webrtc/transport/test/nrappkit_unittest.cpp

@@ -26,7 +26,7 @@ namespace {
 
 class TimerTest : public MtransportTest {
  public:
-  TimerTest() : MtransportTest(), handle_(nullptr), fired_(false) {}
+  TimerTest() : handle_(nullptr), fired_(false) {}
   virtual ~TimerTest() = default;
 
   int ArmTimer(int timeout) {

dom/media/webrtc/transport/test/runnable_utils_unittest.cpp

@@ -128,7 +128,7 @@ class TargetClass {
 
 class RunnableArgsTest : public MtransportTest {
  public:
-  RunnableArgsTest() : MtransportTest(), ran_(0), cl_(&ran_) {}
+  RunnableArgsTest() : ran_(0), cl_(&ran_) {}
 
   void Test1Arg() {
     Runnable* r = WrapRunnable(&cl_, &TargetClass::m1, 1);
@@ -149,7 +149,7 @@ class RunnableArgsTest : public MtransportTest {
 
 class DispatchTest : public MtransportTest {
  public:
-  DispatchTest() : MtransportTest(), ran_(0), cl_(&ran_) {}
+  DispatchTest() : ran_(0), cl_(&ran_) {}
 
   void SetUp() {
     MtransportTest::SetUp();

dom/media/webrtc/transport/test/sockettransportservice_unittest.cpp

@@ -28,8 +28,7 @@ namespace {
 class SocketTransportServiceTest : public MtransportTest {
  public:
   SocketTransportServiceTest()
-      : MtransportTest(),
+      : received_(0),
-        received_(0),
         readpipe_(nullptr),
         writepipe_(nullptr),
         registered_(false) {}

dom/media/webrtc/transport/test/stunserver.cpp

@@ -386,7 +386,7 @@ void TestStunServer::ShutdownInstance() {
 struct DeferredStunOperation {
   DeferredStunOperation(TestStunServer* server, const char* data, size_t len,
                         nr_transport_addr* addr, nr_socket* sock)
-      : server_(server), buffer_(), sock_(sock) {
+      : server_(server), sock_(sock) {
     buffer_.Copy(reinterpret_cast<const uint8_t*>(data), len);
     nr_transport_addr_copy(&addr_, addr);
   }

dom/media/webrtc/transport/test/test_nr_socket_unittest.cpp

@@ -32,13 +32,7 @@ namespace mozilla {
 
 class TestNrSocketTest : public MtransportTest {
  public:
-  TestNrSocketTest()
+  TestNrSocketTest() : wait_done_for_main_(false) {}
-      : MtransportTest(),
-        wait_done_for_main_(false),
-        sts_(),
-        public_addrs_(),
-        private_addrs_(),
-        nats_() {}
 
   void SetUp() override {
     MtransportTest::SetUp();

dom/media/webrtc/transport/test/transport_unittests.cpp

@@ -167,7 +167,7 @@ class TransportLayerLossy : public TransportLayer {
 
 class TlsParser {
  public:
-  TlsParser(const unsigned char* data, size_t len) : buffer_(), offset_(0) {
+  TlsParser(const unsigned char* data, size_t len) : offset_(0) {
     buffer_.Copy(data, len);
   }
 
@@ -221,8 +221,7 @@ class TlsParser {
 
 class DtlsRecordParser {
  public:
-  DtlsRecordParser(const unsigned char* data, size_t len)
+  DtlsRecordParser(const unsigned char* data, size_t len) : offset_(0) {
-      : buffer_(), offset_(0) {
     buffer_.Copy(data, len);
   }
 
@@ -324,7 +323,7 @@ class DtlsInspectorInjector : public DtlsRecordInspector {
 class DtlsInspectorRecordHandshakeMessage : public DtlsRecordInspector {
  public:
   explicit DtlsInspectorRecordHandshakeMessage(uint8_t handshake_type)
-      : handshake_type_(handshake_type), buffer_() {}
+      : handshake_type_(handshake_type) {}
 
   virtual void OnRecord(TransportLayer* layer, uint8_t content_type,
                         const unsigned char* data, size_t len) {
@@ -440,13 +439,9 @@ class TransportTestPeer : public sigslot::has_slots<> {
         lossy_(new TransportLayerLossy()),
         dtls_(new TransportLayerDtls()),
         identity_(DtlsIdentity::Generate()),
-        ice_ctx_(),
-        streams_(),
         peer_(nullptr),
         gathering_complete_(false),
         digest_("sha-1"_ns),
-        enabled_cipersuites_(),
-        disabled_cipersuites_(),
         test_utils_(utils) {
     NrIceCtx::InitializeGlobals(NrIceCtx::GlobalConfig());
     ice_ctx_ = NrIceCtx::Create(name);

dom/media/webrtc/transport/test/turn_unittest.cpp

@@ -71,8 +71,7 @@ static std::string kDummyTurnServer("192.0.2.1");  // From RFC 5737
 class TurnClient : public MtransportTest {
  public:
   TurnClient()
-      : MtransportTest(),
+      : real_socket_(nullptr),
-        real_socket_(nullptr),
         net_socket_(nullptr),
         buffered_socket_(nullptr),
         net_fd_(nullptr),

dom/media/webrtc/transport/test/webrtcproxychannel_unittest.cpp

@@ -504,8 +504,7 @@ void FakeWebrtcTCPSocket::InvokeOnRead(nsTArray<uint8_t>&& aReadData) {
 class WebrtcTCPSocketTest : public MtransportTest {
  public:
   WebrtcTCPSocketTest()
-      : MtransportTest(),
+      : mSocketThread(nullptr),
-        mSocketThread(nullptr),
         mSocketTransport(nullptr),
         mInputStream(nullptr),
         mOutputStream(nullptr),

dom/media/webrtc/transport/test_nr_socket.h

@@ -159,8 +159,7 @@ class TestNat {
         block_tls_(false),
         error_code_for_drop_(0),
         delay_stun_resp_ms_(0),
-        nat_delegate_(nullptr),
+        nat_delegate_(nullptr) {}
-        sockets_() {}
 
   bool has_port_mappings() const;
 
@@ -293,10 +292,7 @@ class TestNrSocket : public NrSocketBase {
     DeferredPacket(TestNrSocket* sock, const void* data, size_t len, int flags,
                    const nr_transport_addr* addr,
                    RefPtr<NrSocketBase> internal_socket)
-        : socket_(sock),
+        : socket_(sock), flags_(flags), internal_socket_(internal_socket) {
-          buffer_(),
-          flags_(flags),
-          internal_socket_(internal_socket) {
       buffer_.Copy(reinterpret_cast<const uint8_t*>(data), len);
       nr_transport_addr_copy(&to_, addr);
     }

dom/media/webrtc/transport/transportlayer.h

@@ -37,7 +37,7 @@ class TransportLayer : public sigslot::has_slots<> {
   enum State { TS_NONE, TS_INIT, TS_CONNECTING, TS_OPEN, TS_CLOSED, TS_ERROR };
 
   // Is this a stream or datagram flow
-  TransportLayer() : state_(TS_NONE), flow_id_(), downward_(nullptr) {}
+  TransportLayer() : state_(TS_NONE), downward_(nullptr) {}
 
   virtual ~TransportLayer() = default;
 

dom/media/webrtc/transport/transportlayerdtls.h

@@ -43,7 +43,7 @@ struct Packet;
 class TransportLayerNSPRAdapter {
  public:
   explicit TransportLayerNSPRAdapter(TransportLayer* output)
-      : output_(output), input_(), enabled_(true) {}
+      : output_(output), enabled_(true) {}
 
   void PacketReceived(MediaPacket& packet);
   int32_t Recv(void* buf, int32_t buflen);

dom/media/webrtc/transport/transportlayerloopback.h

@@ -28,7 +28,6 @@ class TransportLayerLoopback : public TransportLayer {
   TransportLayerLoopback()
       : peer_(nullptr),
         timer_(nullptr),
-        packets_(),
         packets_lock_(nullptr),
         deliverer_(nullptr),
         combinePackets_(false) {}

dom/media/webrtc/transportbridge/MediaPipeline.cpp

@@ -262,7 +262,6 @@ MediaPipeline::MediaPipeline(const std::string& aPc,
       mRtpBytesSent(0),
       mRtpBytesReceived(0),
       mPc(aPc),
-      mFilter(),
       mRtpHeaderExtensionMap(new webrtc::RtpHeaderExtensionMap()),
       mPacketDumper(PacketDumper::GetPacketDumper(mPc)) {}
 

dom/quota/OriginOperations.cpp

@@ -2586,8 +2586,7 @@ void EstimateOp::CloseDirectory() {
 
 ListOriginsOp::ListOriginsOp(MovingNotNull<RefPtr<QuotaManager>> aQuotaManager)
     : OpenStorageDirectoryHelper(std::move(aQuotaManager),
-                                 "dom::quota::ListOriginsOp"),
+                                 "dom::quota::ListOriginsOp") {
-      TraverseRepositoryHelper() {
   AssertIsOnOwningThread();
 }
 

dom/quota/OriginParser.h

@@ -78,7 +78,6 @@ class MOZ_STACK_CLASS OriginParser final {
   explicit OriginParser(const nsACString& aOrigin)
       : mOrigin(aOrigin),
         mTokenizer(aOrigin, '+'),
-        mPort(),
         mSchemeType(eNone),
         mState(eExpectingAppIdOrScheme),
         mInIsolatedMozBrowser(false),

dom/script/ScriptLoader.cpp

@@ -1918,7 +1918,7 @@ using ModuleCompileTask =
 class ScriptDecodeTask final : public CompileOrDecodeTask {
  public:
   explicit ScriptDecodeTask(const JS::TranscodeRange& aRange)
-      : CompileOrDecodeTask(), mRange(aRange) {}
+      : mRange(aRange) {}
 
   nsresult Init(JS::DecodeOptions& aOptions) {
     nsresult rv = InitFrontendContext();

dom/script/ScriptSettings.cpp

@@ -643,7 +643,7 @@ AutoJSContext::AutoJSContext() : mCx(nullptr) {
 
 AutoJSContext::operator JSContext*() const { return mCx; }
 
-AutoSafeJSContext::AutoSafeJSContext() : AutoJSAPI() {
+AutoSafeJSContext::AutoSafeJSContext() {
   MOZ_ASSERT(NS_IsMainThread());
 
   DebugOnly<bool> ok = Init(xpc::UnprivilegedJunkScope());

dom/streams/ReadableStreamBYOBReader.cpp

@@ -36,8 +36,7 @@ NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(ReadableStreamBYOBReader)
 NS_INTERFACE_MAP_END_INHERITING(ReadableStreamGenericReader)
 
 ReadableStreamBYOBReader::ReadableStreamBYOBReader(nsISupports* aGlobal)
-    : ReadableStreamGenericReader(do_QueryInterface(aGlobal)),
+    : ReadableStreamGenericReader(do_QueryInterface(aGlobal)) {}
-      mReadIntoRequests({}) {}
 
 JSObject* ReadableStreamBYOBReader::WrapObject(
     JSContext* aCx, JS::Handle<JSObject*> aGivenProto) {

dom/streams/ReadableStreamDefaultReader.cpp

@@ -48,8 +48,7 @@ NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(ReadableStreamDefaultReader)
 NS_INTERFACE_MAP_END_INHERITING(ReadableStreamGenericReader)
 
 ReadableStreamDefaultReader::ReadableStreamDefaultReader(nsISupports* aGlobal)
-    : ReadableStreamGenericReader(do_QueryInterface(aGlobal)),
+    : ReadableStreamGenericReader(do_QueryInterface(aGlobal)) {}
-      nsWrapperCache() {}
 
 ReadableStreamDefaultReader::~ReadableStreamDefaultReader() {
   mReadRequests.clear();

dom/svg/DOMSVGPathSeg.h

@@ -208,7 +208,7 @@ class DOMSVGPathSeg : public nsWrapperCache {
 
 class DOMSVGPathSegClosePath : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegClosePath() : DOMSVGPathSeg() {}
+  DOMSVGPathSegClosePath() {}
 
   IMPL_SVGPATHSEG_SUBCLASS_COMMON(ClosePath,
                                   dom::SVGPathSeg_Binding::PATHSEG_CLOSEPATH)
@@ -222,7 +222,7 @@ class DOMSVGPathSegClosePath : public DOMSVGPathSeg {
 
 class DOMSVGPathSegMovetoAbs : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegMovetoAbs(float x, float y) : DOMSVGPathSeg() {
+  DOMSVGPathSegMovetoAbs(float x, float y) {
     mArgs[0] = x;
     mArgs[1] = y;
   }
@@ -241,7 +241,7 @@ class DOMSVGPathSegMovetoAbs : public DOMSVGPathSeg {
 
 class DOMSVGPathSegMovetoRel : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegMovetoRel(float x, float y) : DOMSVGPathSeg() {
+  DOMSVGPathSegMovetoRel(float x, float y) {
     mArgs[0] = x;
     mArgs[1] = y;
   }
@@ -260,7 +260,7 @@ class DOMSVGPathSegMovetoRel : public DOMSVGPathSeg {
 
 class DOMSVGPathSegLinetoAbs : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegLinetoAbs(float x, float y) : DOMSVGPathSeg() {
+  DOMSVGPathSegLinetoAbs(float x, float y) {
     mArgs[0] = x;
     mArgs[1] = y;
   }
@@ -279,7 +279,7 @@ class DOMSVGPathSegLinetoAbs : public DOMSVGPathSeg {
 
 class DOMSVGPathSegLinetoRel : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegLinetoRel(float x, float y) : DOMSVGPathSeg() {
+  DOMSVGPathSegLinetoRel(float x, float y) {
     mArgs[0] = x;
     mArgs[1] = y;
   }
@@ -299,8 +299,7 @@ class DOMSVGPathSegLinetoRel : public DOMSVGPathSeg {
 class DOMSVGPathSegCurvetoCubicAbs : public DOMSVGPathSeg {
  public:
   DOMSVGPathSegCurvetoCubicAbs(float x1, float y1, float x2, float y2, float x,
-                               float y)
+                               float y) {
-      : DOMSVGPathSeg() {
     mArgs[0] = x1;
     mArgs[1] = y1;
     mArgs[2] = x2;
@@ -332,8 +331,7 @@ class DOMSVGPathSegCurvetoCubicAbs : public DOMSVGPathSeg {
 class DOMSVGPathSegCurvetoCubicRel : public DOMSVGPathSeg {
  public:
   DOMSVGPathSegCurvetoCubicRel(float x1, float y1, float x2, float y2, float x,
-                               float y)
+                               float y) {
-      : DOMSVGPathSeg() {
     mArgs[0] = x1;
     mArgs[1] = y1;
     mArgs[2] = x2;
@@ -364,8 +362,7 @@ class DOMSVGPathSegCurvetoCubicRel : public DOMSVGPathSeg {
 
 class DOMSVGPathSegCurvetoQuadraticAbs : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegCurvetoQuadraticAbs(float x1, float y1, float x, float y)
+  DOMSVGPathSegCurvetoQuadraticAbs(float x1, float y1, float x, float y) {
-      : DOMSVGPathSeg() {
     mArgs[0] = x1;
     mArgs[1] = y1;
     mArgs[2] = x;
@@ -391,8 +388,7 @@ class DOMSVGPathSegCurvetoQuadraticAbs : public DOMSVGPathSeg {
 
 class DOMSVGPathSegCurvetoQuadraticRel : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegCurvetoQuadraticRel(float x1, float y1, float x, float y)
+  DOMSVGPathSegCurvetoQuadraticRel(float x1, float y1, float x, float y) {
-      : DOMSVGPathSeg() {
     mArgs[0] = x1;
     mArgs[1] = y1;
     mArgs[2] = x;
@@ -419,8 +415,7 @@ class DOMSVGPathSegCurvetoQuadraticRel : public DOMSVGPathSeg {
 class DOMSVGPathSegArcAbs : public DOMSVGPathSeg {
  public:
   DOMSVGPathSegArcAbs(float r1, float r2, float angle, bool largeArcFlag,
-                      bool sweepFlag, float x, float y)
+                      bool sweepFlag, float x, float y) {
-      : DOMSVGPathSeg() {
     mArgs[0] = r1;
     mArgs[1] = r2;
     mArgs[2] = angle;
@@ -455,8 +450,7 @@ class DOMSVGPathSegArcAbs : public DOMSVGPathSeg {
 class DOMSVGPathSegArcRel : public DOMSVGPathSeg {
  public:
   DOMSVGPathSegArcRel(float r1, float r2, float angle, bool largeArcFlag,
-                      bool sweepFlag, float x, float y)
+                      bool sweepFlag, float x, float y) {
-      : DOMSVGPathSeg() {
     mArgs[0] = r1;
     mArgs[1] = r2;
     mArgs[2] = angle;
@@ -490,9 +484,7 @@ class DOMSVGPathSegArcRel : public DOMSVGPathSeg {
 
 class DOMSVGPathSegLinetoHorizontalAbs : public DOMSVGPathSeg {
  public:
-  explicit DOMSVGPathSegLinetoHorizontalAbs(float x) : DOMSVGPathSeg() {
+  explicit DOMSVGPathSegLinetoHorizontalAbs(float x) { mArgs[0] = x; }
-    mArgs[0] = x;
-  }
 
   IMPL_SVGPATHSEG_SUBCLASS_COMMON(
       LinetoHorizontalAbs,
@@ -507,9 +499,7 @@ class DOMSVGPathSegLinetoHorizontalAbs : public DOMSVGPathSeg {
 
 class DOMSVGPathSegLinetoHorizontalRel : public DOMSVGPathSeg {
  public:
-  explicit DOMSVGPathSegLinetoHorizontalRel(float x) : DOMSVGPathSeg() {
+  explicit DOMSVGPathSegLinetoHorizontalRel(float x) { mArgs[0] = x; }
-    mArgs[0] = x;
-  }
 
   IMPL_SVGPATHSEG_SUBCLASS_COMMON(
       LinetoHorizontalRel,
@@ -524,9 +514,7 @@ class DOMSVGPathSegLinetoHorizontalRel : public DOMSVGPathSeg {
 
 class DOMSVGPathSegLinetoVerticalAbs : public DOMSVGPathSeg {
  public:
-  explicit DOMSVGPathSegLinetoVerticalAbs(float y) : DOMSVGPathSeg() {
+  explicit DOMSVGPathSegLinetoVerticalAbs(float y) { mArgs[0] = y; }
-    mArgs[0] = y;
-  }
 
   IMPL_SVGPATHSEG_SUBCLASS_COMMON(
       LinetoVerticalAbs, dom::SVGPathSeg_Binding::PATHSEG_LINETO_VERTICAL_ABS)
@@ -540,9 +528,7 @@ class DOMSVGPathSegLinetoVerticalAbs : public DOMSVGPathSeg {
 
 class DOMSVGPathSegLinetoVerticalRel : public DOMSVGPathSeg {
  public:
-  explicit DOMSVGPathSegLinetoVerticalRel(float y) : DOMSVGPathSeg() {
+  explicit DOMSVGPathSegLinetoVerticalRel(float y) { mArgs[0] = y; }
-    mArgs[0] = y;
-  }
 
   IMPL_SVGPATHSEG_SUBCLASS_COMMON(
       LinetoVerticalRel, dom::SVGPathSeg_Binding::PATHSEG_LINETO_VERTICAL_REL)
@@ -556,8 +542,7 @@ class DOMSVGPathSegLinetoVerticalRel : public DOMSVGPathSeg {
 
 class DOMSVGPathSegCurvetoCubicSmoothAbs : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegCurvetoCubicSmoothAbs(float x2, float y2, float x, float y)
+  DOMSVGPathSegCurvetoCubicSmoothAbs(float x2, float y2, float x, float y) {
-      : DOMSVGPathSeg() {
     mArgs[0] = x2;
     mArgs[1] = y2;
     mArgs[2] = x;
@@ -583,8 +568,7 @@ class DOMSVGPathSegCurvetoCubicSmoothAbs : public DOMSVGPathSeg {
 
 class DOMSVGPathSegCurvetoCubicSmoothRel : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegCurvetoCubicSmoothRel(float x2, float y2, float x, float y)
+  DOMSVGPathSegCurvetoCubicSmoothRel(float x2, float y2, float x, float y) {
-      : DOMSVGPathSeg() {
     mArgs[0] = x2;
     mArgs[1] = y2;
     mArgs[2] = x;
@@ -610,7 +594,7 @@ class DOMSVGPathSegCurvetoCubicSmoothRel : public DOMSVGPathSeg {
 
 class DOMSVGPathSegCurvetoQuadraticSmoothAbs : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegCurvetoQuadraticSmoothAbs(float x, float y) : DOMSVGPathSeg() {
+  DOMSVGPathSegCurvetoQuadraticSmoothAbs(float x, float y) {
     mArgs[0] = x;
     mArgs[1] = y;
   }
@@ -630,7 +614,7 @@ class DOMSVGPathSegCurvetoQuadraticSmoothAbs : public DOMSVGPathSeg {
 
 class DOMSVGPathSegCurvetoQuadraticSmoothRel : public DOMSVGPathSeg {
  public:
-  DOMSVGPathSegCurvetoQuadraticSmoothRel(float x, float y) : DOMSVGPathSeg() {
+  DOMSVGPathSegCurvetoQuadraticSmoothRel(float x, float y) {
     mArgs[0] = x;
     mArgs[1] = y;
   }

dom/svg/SVGTransform.h

@@ -21,9 +21,7 @@ class SVGTransform {
  public:
   // Default ctor initialises to matrix type with identity matrix
   SVGTransform()
-      : mMatrix()  // Initialises to identity
+      : mAngle(0.f),
-        ,
-        mAngle(0.f),
         mOriginX(0.f),
         mOriginY(0.f),
         mType(dom::SVGTransform_Binding::SVG_TRANSFORM_MATRIX) {}

dom/vr/XRView.cpp

@@ -20,8 +20,7 @@ NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE_WITH_JS_MEMBERS(XRView,
 XRView::XRView(nsISupports* aParent, const XREye& aEye)
     : mParent(aParent),
       mEye(aEye),
-      mPosition(gfx::PointDouble3D()),
+
-      mOrientation(gfx::QuaternionDouble()),
       mJSProjectionMatrix(nullptr) {
   mozilla::HoldJSObjects(this);
 }

dom/xslt/xslt/txVariableMap.h

@@ -36,7 +36,7 @@ class txVariableMapBase {
  */
 class txVariableMap : public txVariableMapBase {
  public:
-  txVariableMap() : txVariableMapBase() { MOZ_COUNT_CTOR(txVariableMap); }
+  txVariableMap() { MOZ_COUNT_CTOR(txVariableMap); }
   MOZ_COUNTED_DTOR(txVariableMap)
 };
 

editor/libeditor/ChangeStyleTransaction.cpp

@@ -50,8 +50,6 @@ ChangeStyleTransaction::ChangeStyleTransaction(nsStyledElement& aStyledElement,
     : EditTransactionBase(),
       mStyledElement(&aStyledElement),
       mProperty(&aProperty),
-      mUndoValue(),
-      mRedoValue(),
       mRemoveProperty(aRemove),
       mUndoAttributeWasSet(false),
       mRedoAttributeWasSet(false) {

editor/libeditor/HTMLEditHelpers.cpp

@@ -79,9 +79,7 @@ void DOMIterator::AppendNodesToArray(
   }
 }
 
-DOMSubtreeIterator::DOMSubtreeIterator() : DOMIterator() {
+DOMSubtreeIterator::DOMSubtreeIterator() { mIter = &mSubtreeIter; }
-  mIter = &mSubtreeIter;
-}
 
 nsresult DOMSubtreeIterator::Init(nsRange& aRange) {
   return mIter->Init(&aRange);

editor/libeditor/HTMLEditHelpers.h

@@ -189,15 +189,13 @@ class MOZ_STACK_CLASS MoveNodeResult final : public CaretPoint {
  private:
   explicit MoveNodeResult(const EditorDOMPoint& aNextInsertionPoint,
                           bool aHandled)
-      : CaretPoint(),
+      : mNextInsertionPoint(aNextInsertionPoint),
-        mNextInsertionPoint(aNextInsertionPoint),
         mHandled(aHandled && aNextInsertionPoint.IsSet()) {
     AutoEditorDOMPointChildInvalidator computeOffsetAndForgetChild(
         mNextInsertionPoint);
   }
   explicit MoveNodeResult(EditorDOMPoint&& aNextInsertionPoint, bool aHandled)
-      : CaretPoint(),
+      : mNextInsertionPoint(std::move(aNextInsertionPoint)),
-        mNextInsertionPoint(std::move(aNextInsertionPoint)),
         mHandled(aHandled && mNextInsertionPoint.IsSet()) {
     AutoEditorDOMPointChildInvalidator computeOffsetAndForgetChild(
         mNextInsertionPoint);
@@ -673,8 +671,7 @@ class MOZ_STACK_CLASS SplitRangeOffFromNodeResult final : public CaretPoint {
   SplitRangeOffFromNodeResult(nsIContent* aLeftContent,
                               nsIContent* aMiddleContent,
                               nsIContent* aRightContent)
-      : CaretPoint(),
+      : mLeftContent(aLeftContent),
-        mLeftContent(aLeftContent),
         mMiddleContent(aMiddleContent),
         mRightContent(aRightContent) {}
 
@@ -752,8 +749,7 @@ class MOZ_STACK_CLASS SplitRangeOffResult final : public CaretPoint {
   SplitRangeOffResult(EditorDOMRange&& aTrackedRange,
                       SplitNodeResult&& aSplitNodeResultAtStart,
                       SplitNodeResult&& aSplitNodeResultAtEnd)
-      : CaretPoint(),
+      : mRange(std::move(aTrackedRange)),
-        mRange(std::move(aTrackedRange)),
         mHandled(aSplitNodeResultAtStart.Handled() ||
                  aSplitNodeResultAtEnd.Handled()) {
     MOZ_ASSERT(mRange.StartRef().IsSet());

editor/libeditor/HTMLEditorEventListener.h

@@ -22,8 +22,7 @@ class Element;
 class HTMLEditorEventListener final : public EditorEventListener {
  public:
   HTMLEditorEventListener()
-      : EditorEventListener(),
+      : mListeningToMouseMoveEventForResizers(false),
-        mListeningToMouseMoveEventForResizers(false),
         mListeningToMouseMoveEventForGrabber(false),
         mListeningToResizeEvent(false) {}
 

editor/txmgr/TransactionStack.cpp

@@ -13,8 +13,7 @@
 
 namespace mozilla {
 
-TransactionStack::TransactionStack(Type aType)
+TransactionStack::TransactionStack(Type aType) : mType(aType) {}
-    : nsRefPtrDeque<TransactionItem>(), mType(aType) {}
 
 TransactionStack::~TransactionStack() { Clear(); }
 

gfx/2d/Blur.cpp

@@ -540,7 +540,7 @@ void AlphaBoxBlur::Init(const Rect& aRect, const IntSize& aSpreadRadius,
 AlphaBoxBlur::AlphaBoxBlur(const Rect& aRect, int32_t aStride, float aSigmaX,
                            float aSigmaY)
     : mRect(TruncatedToInt(aRect)),
-      mSpreadRadius(),
+
       mBlurRadius(CalculateBlurRadius(Point(aSigmaX, aSigmaY))),
       mStride(aStride),
       mSurfaceAllocationSize(0),

gfx/2d/Path.cpp

@@ -22,7 +22,7 @@ static double CubicRoot(double aValue) {
 struct PointD : public BasePoint<double, PointD> {
   typedef BasePoint<double, PointD> Super;
 
-  PointD() : Super() {}
+  PointD() {}
   PointD(double aX, double aY) : Super(aX, aY) {}
   MOZ_IMPLICIT PointD(const Point& aPoint) : Super(aPoint.x, aPoint.y) {}
 

gfx/layers/FrameMetrics.h

@@ -88,18 +88,13 @@ struct FrameMetrics {
         mCompositionBoundsWidthIgnoringScrollbars(0),
         mDisplayPort(0, 0, 0, 0),
         mScrollableRect(0, 0, 0, 0),
-        mCumulativeResolution(),
         mDevPixelsPerCSSPixel(1),
         mScrollOffset(0, 0),
-        mZoom(),
         mBoundingCompositionSize(0, 0),
         mPresShellId(-1),
         mLayoutViewport(0, 0, 0, 0),
-        mTransformToAncestorScale(),
-        mPaintRequestTime(),
         mVisualDestination(0, 0),
         mVisualScrollUpdateType(eNone),
-        mCompositionSizeWithoutDynamicToolbar(),
         mIsRootContent(false),
         mIsScrollInfoLayer(false),
         mHasNonZeroDisplayPortMargins(false),
@@ -740,10 +735,7 @@ struct ScrollMetadata {
       sNullMetadata;  // We sometimes need an empty metadata
 
   ScrollMetadata()
-      : mMetrics(),
+      : mScrollParentId(ScrollableLayerGuid::NULL_SCROLL_ID),
-        mSnapInfo(),
-        mScrollParentId(ScrollableLayerGuid::NULL_SCROLL_ID),
-        mContentDescription(),
         mLineScrollAmount(0, 0),
         mPageScrollAmount(0, 0),
         mHasScrollgrab(false),
@@ -755,8 +747,7 @@ struct ScrollMetadata {
         mDidContentGetPainted(true),
         mForceMousewheelAutodir(false),
         mForceMousewheelAutodirHonourRoot(false),
-        mIsPaginatedPresentation(false),
+        mIsPaginatedPresentation(false) {}
-        mOverscrollBehavior() {}
 
   bool operator==(const ScrollMetadata& aOther) const {
     return mMetrics == aOther.mMetrics && mSnapInfo == aOther.mSnapInfo &&

gfx/layers/RepaintRequest.h

@@ -48,15 +48,11 @@ struct RepaintRequest {
       : mScrollId(ScrollableLayerGuid::NULL_SCROLL_ID),
         mPresShellResolution(1),
         mCompositionBounds(0, 0, 0, 0),
-        mCumulativeResolution(),
         mDevPixelsPerCSSPixel(1),
         mScrollOffset(0, 0),
-        mZoom(),
         mDisplayPortMargins(0, 0, 0, 0),
         mPresShellId(-1),
         mLayoutViewport(0, 0, 0, 0),
-        mTransformToAncestorScale(),
-        mPaintRequestTime(),
         mScrollUpdateType(eNone),
         mScrollAnimationType(APZScrollAnimationType::No),
         mIsRootContent(false),

gfx/layers/apz/src/AsyncPanZoomController.cpp

@@ -763,7 +763,6 @@ AsyncPanZoomController::AsyncPanZoomController(
                            ViewportMaxScale() / ParentLayerToScreenScale(1)),
       mLastSampleTime(GetFrameTime()),
       mLastCheckerboardReport(GetFrameTime()),
-      mLastNotifiedZoom(),
       mOverscrollEffect(MakeUnique<OverscrollEffect>(*this)),
       mState(NOTHING),
       mX(this),

gfx/layers/ipc/CanvasTranslator.cpp

@@ -67,7 +67,7 @@ TextureData* CanvasTranslator::CreateTextureData(TextureType aTextureType,
   return textureData;
 }
 
-CanvasTranslator::CanvasTranslator() : gfx::InlineTranslator() {
+CanvasTranslator::CanvasTranslator() {
   // Track when remote canvas has been activated.
   Telemetry::ScalarAdd(Telemetry::ScalarID::GFX_CANVAS_REMOTE_ACTIVATED, 1);
 }

gfx/layers/wr/HitTestInfoManager.cpp

@@ -49,8 +49,7 @@ static void CreateWebRenderCommands(wr::DisplayListBuilder& aBuilder,
 }
 
 HitTestInfoManager::HitTestInfoManager()
-    : mArea(nsRect()),
+    : mFlags(gfx::CompositorHitTestInvisibleToHit),
-      mFlags(gfx::CompositorHitTestInvisibleToHit),
       mViewId(ScrollableLayerGuid::NULL_SCROLL_ID),
       mSpaceAndClipChain(wr::InvalidScrollNodeWithChain()) {}
 

gfx/layers/wr/WebRenderImageHost.cpp

@@ -37,9 +37,7 @@ namespace layers {
 class ISurfaceAllocator;
 
 WebRenderImageHost::WebRenderImageHost(const TextureInfo& aTextureInfo)
-    : CompositableHost(aTextureInfo),
+    : CompositableHost(aTextureInfo), mCurrentAsyncImageManager(nullptr) {}
-      ImageComposite(),
-      mCurrentAsyncImageManager(nullptr) {}
 
 WebRenderImageHost::~WebRenderImageHost() {
   MOZ_ASSERT(mPendingRemoteTextureWrappers.empty());

gfx/src/nsRect.h

@@ -35,7 +35,7 @@ struct nsRect : public mozilla::gfx::BaseRect<nscoord, nsRect, nsPoint, nsSize,
       Super;
 
   // Constructors
-  nsRect() : Super() { MOZ_COUNT_CTOR(nsRect); }
+  nsRect() { MOZ_COUNT_CTOR(nsRect); }
   nsRect(const nsRect& aRect) : Super(aRect) { MOZ_COUNT_CTOR(nsRect); }
   nsRect(const nsPoint& aOrigin, const nsSize& aSize) : Super(aOrigin, aSize) {
     MOZ_COUNT_CTOR(nsRect);

gfx/src/nsRectAbsolute.h

@@ -19,7 +19,7 @@ struct nsRectAbsolute
                                          nsRect>
       Super;
 
-  nsRectAbsolute() : Super() {}
+  nsRectAbsolute() {}
   nsRectAbsolute(nscoord aX1, nscoord aY1, nscoord aX2, nscoord aY2)
       : Super(aX1, aY1, aX2, aY2) {}
 

gfx/src/nsSize.h

@@ -19,7 +19,7 @@ typedef mozilla::gfx::IntSize nsIntSize;
 struct nsSize : public mozilla::gfx::BaseSize<nscoord, nsSize> {
   typedef mozilla::gfx::BaseSize<nscoord, nsSize> Super;
 
-  constexpr nsSize() : Super() {}
+  constexpr nsSize() {}
   constexpr nsSize(nscoord aWidth, nscoord aHeight) : Super(aWidth, aHeight) {}
 
   inline mozilla::gfx::IntSize ScaleToNearestPixels(

gfx/thebes/gfxFontEntry.h

@@ -1222,8 +1222,7 @@ struct FontFamily {
 // together with the CSS generic (if any) that was mapped to it in this
 // particular case (so it can be reported to the DevTools font inspector).
 struct FamilyAndGeneric final {
-  FamilyAndGeneric()
+  FamilyAndGeneric() : mGeneric(mozilla::StyleGenericFontFamily(0)) {}
-      : mFamily(), mGeneric(mozilla::StyleGenericFontFamily(0)) {}
   FamilyAndGeneric(const FamilyAndGeneric& aOther) = default;
   explicit FamilyAndGeneric(gfxFontFamily* aFamily,
                             mozilla::StyleGenericFontFamily aGeneric =

gfx/thebes/gfxLineSegment.h

@@ -10,7 +10,7 @@
 #include "gfxPoint.h"
 
 struct gfxLineSegment {
-  gfxLineSegment() : mStart(gfxPoint()), mEnd(gfxPoint()) {}
+  gfxLineSegment() {}
   gfxLineSegment(const gfxPoint& aStart, const gfxPoint& aEnd)
       : mStart(aStart), mEnd(aEnd) {}
 

gfx/thebes/gfxPlatform.cpp

@@ -218,8 +218,7 @@ class CrashStatsLogForwarder : public mozilla::gfx::LogForwarder {
 };
 
 CrashStatsLogForwarder::CrashStatsLogForwarder(CrashReporter::Annotation aKey)
-    : mBuffer(),
+    : mCrashCriticalKey(aKey),
-      mCrashCriticalKey(aKey),
       mMaxCapacity(0),
       mIndex(-1),
       mMutex("CrashStatsLogForwarder") {}

gfx/thebes/gfxPlatformFontList.cpp

@@ -1918,7 +1918,6 @@ FamilyAndGeneric gfxPlatformFontList::GetDefaultFontFamily(
 
 ShmemCharMapHashEntry::ShmemCharMapHashEntry(const gfxSparseBitSet* aCharMap)
     : mList(gfxPlatformFontList::PlatformFontList()->SharedFontList()),
-      mCharMap(),
       mHash(aCharMap->GetChecksum()) {
   size_t len = SharedBitSet::RequiredSize(*aCharMap);
   mCharMap = mList->Alloc(len);

gfx/vr/service/OSVRSession.cpp

@@ -197,8 +197,7 @@ mozilla::gfx::VRFieldOfView SetFromTanRadians(double left, double right,
 }
 
 OSVRSession::OSVRSession()
-    : VRSession(),
+    : mRuntimeLoaded(false),
-      mRuntimeLoaded(false),
       mOSVRInitialized(false),
       mClientContextInitialized(false),
       mDisplayConfigInitialized(false),

gfx/vr/service/OpenVRSession.cpp

@@ -183,8 +183,7 @@ bool GenerateTempFileName(nsCString& aPath) {
 #endif  // defined(XP_WIN)
 
 OpenVRSession::OpenVRSession()
-    : VRSession(),
+    : mVRSystem(nullptr),
-      mVRSystem(nullptr),
       mVRChaperone(nullptr),
       mVRCompositor(nullptr),
       mHapticPulseRemaining{},

gfx/vr/service/PuppetSession.cpp

@@ -21,7 +21,7 @@ using namespace mozilla::gfx;
 
 namespace mozilla::gfx {
 
-PuppetSession::PuppetSession() : VRSession() {}
+PuppetSession::PuppetSession() {}
 
 PuppetSession::~PuppetSession() { Shutdown(); }