Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1409916: Eliminate pointless cross-process call for IAccessible2_2::get_attribute. r=aklotz

Browse Source 
IAccessible2_2::get_attribute is not implemented yet in Gecko.
However, the handler still passes this through, thus resulting in a pointless cross-process call.
Instead, just return E_NOTIMPL in the handler for this method.

MozReview-Commit-ID: 5XHieUC4cuz

--HG--
extra : rebase_source : 814ceda6d9dd4ec26f05a4ff90bbd4af2a6eb84e
This commit is contained in:
James Teh 2017-10-19 09:22:44 +10:00
parent 429ff227ee
commit d11dfce827
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
accessible/ipc/win/handler/AccessibleHandler.cpp
View File

@ -969,13 +969,11 @@ AccessibleHandler::get_attributes(BSTR* attributes)
HRESULT
AccessibleHandler::get_attribute(BSTR name, VARIANT* attribute)
{
// We could extract these individually from cached mAttributes.
// Consider it if traffic warrants it
HRESULT hr = ResolveIA2();
if (FAILED(hr)) {
return hr;
}
return mIA2PassThru->get_attribute(name, attribute);
// Not yet implemented by ia2Accessible.
// Once ia2Accessible implements this, we could either pass it through
// or we could extract these individually from cached mAttributes.
// The latter should be considered if traffic warrants it.
return E_NOTIMPL;
}
HRESULT