Bug 360241: Add a buch of accesskeys to Publishing dialogs/tabs, patch by Giacomo Magnini <prometeo.bugs@gmail.com>, r=glazou, sr=neil

editor/ui/dialogs/content/EditorPublish.xul

@@ -83,19 +83,23 @@
                 style="min-width:18em; max-width:18em;" crop="right"
                 oncommand="SelectSiteList();"/>
               <hbox>
-                <button label="&newSiteButton.label;" oncommand="AddNewSite();"/>
+                <button label="&newSiteButton.label;"
+                        accesskey="&newSiteButton.accesskey;"
+                        oncommand="AddNewSite();"/>
                 <spacer flex="1"/>
               </hbox>
             </row>
             <spacer class="spacer"/>
             <row align="center">
-              <label value="&pageTitle.label;"/>
+              <label value="&pageTitle.label;" accesskey="&pageTitle.accesskey;"
+                     control="PageTitleInput"/>
               <textbox id="PageTitleInput" 
                 tooltiptext="&pageTitle.tooltip;" class="minWidth15"/>
               <label value="&pageTitleExample.label;"/>
             </row>
             <row align="center">
-              <label value="&filename.label;"/>
+              <label value="&filename.label;" accesskey="&filename.accesskey;"
+                     control="FilenameInput"/>
               <textbox id="FilenameInput"
                 tooltiptext="&filename.tooltip;" class="minWidth15 uri-element"/>
               <label value="&filenameExample.label;"/>
@@ -107,28 +111,31 @@
         <hbox align="center">
           <!-- Contents filled in at runtime -->
           <menulist id="DocDirList" class="minWidth20 uri-element" editable="true"  flex="1"
-                    oninput="onInputSettings();"/>
-<!-- 
-          <button label="&chooseDirButton.label;" oncommand="ChooseDir(gDialog.DocDirList);" disabled="true"/>
--->
+                    tooltiptext="&docDirList.tooltip;" oninput="onInputSettings();"/>
         </hbox>
         <spacer class="spacer"/>
         <groupbox>
           <caption>
             <checkbox id="OtherDirCheckbox" label="&publishImgCheckbox.label;" 
-              tooltiptext="&publishImgCheckbox.tooltip;" oncommand="doEnabling();"/>
+                      accesskey="&publishImgCheckbox.accesskey;"
+                      tooltiptext="&publishImgCheckbox.tooltip;"
+                      oncommand="doEnabling();"/>
           </caption>
           <vbox>
           <radiogroup id="OtherDirRadiogroup">
             <hbox>
               <spacer class="checkbox-spacer"/>
               <radio id="SameLocationRadio" label="&sameLocationRadio.label;"
-                tooltiptext="&sameLocationRadio.tooltip;" oncommand="doEnabling();"/>
+                     accesskey="&sameLocationRadio.accesskey;"
+                     tooltiptext="&sameLocationRadio.tooltip;"
+                     oncommand="doEnabling();"/>
             </hbox>
             <hbox>
               <spacer class="checkbox-spacer"/>
               <radio id="UseSubdirRadio" label="&useSubdirRadio.label;"
-                tooltiptext="&useSubdir.tooltip;" oncommand="doEnabling();"/>
+                     accesskey="&useSubdirRadio.accesskey;"
+                     tooltiptext="&useSubdirRadio.tooltip;"
+                     oncommand="doEnabling();"/>
             </hbox>
           </radiogroup>
           </vbox>
@@ -136,11 +143,9 @@
             <spacer class="checkbox-spacer"/>
             <spacer class="radio-spacer"/>
             <!-- Contents filled in at runtime -->
-            <menulist id="OtherDirList" class="minWidth20 uri-element" editable="true" flex="1"
-              tooltiptext="&useSubdir.tooltip;" oninput="onInputSettings();"/>
-<!-- 
-            <button label="&chooseDirButton.label;" oncommand="ChooseDir(gDialog.OtherDirList);" disabled="true"/>
--->
+            <menulist id="OtherDirList" class="minWidth20 uri-element"
+                      editable="true" flex="1" tooltiptext="&otherDirList.tooltip;"
+                      oninput="onInputSettings();"/>
           </hbox>
         </groupbox>
         <spacer flex="1"/>

editor/ui/dialogs/content/EditorPublishOverlay.xul

@@ -49,18 +49,21 @@
   <groupbox id="ServerSettingsBox">
     <caption label="&serverInfo.label;"/>
     <hbox align="center">
-      <label value="&siteName.label;"/>
-      <textbox id="SiteNameInput" class="MinWidth20em" 
-        tooltiptext="&siteName.tooltip;" oninput="onInputSettings();" flex="1"/>
+      <label value="&siteName.label;" accesskey="&siteName.accesskey;"
+             control="SiteNameInput"/>
+      <textbox id="SiteNameInput" class="MinWidth20em" flex="1"
+               tooltiptext="&siteName.tooltip;" oninput="onInputSettings();"/>
     </hbox>
     <spacer class="spacer"/>
-    <label value="&siteUrl.label;"/>
+    <label value="&siteUrl.label;" accesskey="&siteUrl.accesskey;"
+           control="PublishUrlInput"/>
     <textbox id="PublishUrlInput" class="MinWidth20em uri-element"
-      tooltiptext="&siteUrl.tooltip;" oninput="onInputSettings();"/>
+             tooltiptext="&siteUrl.tooltip;" oninput="onInputSettings();"/>
     <spacer class="spacer"/>
-    <label value="&browseUrl.label;"/>
+    <label value="&browseUrl.label;" accesskey="&browseUrl.accesskey;"
+           control="BrowseUrlInput"/>
     <textbox id="BrowseUrlInput" class="MinWidth20em uri-element" 
-      tooltiptext="&browseUrl.tooltip;" oninput="onInputSettings();"/>
+             tooltiptext="&browseUrl.tooltip;" oninput="onInputSettings();"/>
     <spacer class="spacer"/>
   </groupbox>
   <groupbox id="LoginSettingsBox">
@@ -69,17 +72,21 @@
       <columns><column flex="1"/><column flex="3"/></columns>
       <rows>
         <row align="center">
-          <label value="&username.label;"/>
-          <textbox id="UsernameInput" class="MinWidth10em" 
-            tooltiptext="&username.tooltip;" oninput="onInputSettings();" flex="1"/>
+          <label value="&username.label;" accesskey="&username.accesskey;"
+                 control="UsernameInput"/>
+          <textbox id="UsernameInput" class="MinWidth10em" flex="1"
+                   tooltiptext="&username.tooltip;" oninput="onInputSettings();"/>
         </row>
         <row align="center">
-          <label value="&password.label;"/>
+          <label value="&password.label;" accesskey="&password.accesskey;"
+                 control="PasswordInput"/>
           <hbox>
             <textbox id="PasswordInput" type="password" class="MinWidth5em" 
-              oninput="onInputSettings();"/>
-            <checkbox id="SavePassword" label="&savePassword.label;" 
-              tooltiptext="&savePassword.tooltip;" oncommand="onInputSettings();"/>
+                     oninput="onInputSettings();"/>
+            <checkbox id="SavePassword" label="&savePassword.label;"
+                      accesskey="&savePassword.accesskey;" 
+                      tooltiptext="&savePassword.tooltip;"
+                      oncommand="onInputSettings();"/>
           </hbox>
         </row>
       </rows>
@@ -88,4 +95,4 @@
   </groupbox>
 </vbox>
 
-</overlay>
+</overlay>

editor/ui/dialogs/content/EditorPublishSettings.xul

@@ -72,9 +72,12 @@
       </vbox>
       <hbox pack="center">
         <vbox>
-          <button id="NewSiteButton"      label="&newSiteButton.label;"      oncommand="AddNewSite();"/>
-          <button id="SetDefaultButton"   label="&setDefaultButton.label;"   oncommand="SetDefault();"/>
-          <button id="RemoveSiteButton"   label="&removeButton.label;"       oncommand="RemoveSite();"/>
+          <button id="NewSiteButton" label="&newSiteButton.label;"
+                  accesskey="&newSiteButton.accesskey;" oncommand="AddNewSite();"/>
+          <button id="SetDefaultButton" label="&setDefaultButton.label;"
+                  accesskey="&setDefaultButton.accesskey;" oncommand="SetDefault();"/>
+          <button id="RemoveSiteButton" label="&removeButton.label;"
+                  accesskey="&removeButton.accesskey;" oncommand="RemoveSite();"/>
         </vbox>
       </hbox>
     </groupbox>

editor/ui/locales/en-US/chrome/dialogs/EditorPublish.dtd

@@ -37,52 +37,67 @@
 
 
 <!-- Window title -->
-<!ENTITY windowTitle.label         "Publish Page">
-<!ENTITY windowTitleSettings.label "Publish Settings">
+<!ENTITY windowTitle.label            "Publish Page">
+<!ENTITY windowTitleSettings.label    "Publish Settings">
 
-<!ENTITY publishTab.label         "Publish">
-<!ENTITY settingsTab.label        "Settings">
+<!ENTITY publishTab.label             "Publish">
+<!ENTITY settingsTab.label            "Settings">
 
-<!ENTITY publishButton.label      "Publish">
+<!ENTITY publishButton.label          "Publish">
 
 <!-- Publish Tab Panel -->
-<!ENTITY siteList.label           "Site Name:">
-<!ENTITY siteList.tooltip         "Choose the site that you want to publish to">
-<!ENTITY newSiteButton.label      "New Site">
-<!ENTITY siteDirList.label        "Select or type a directory name in your publishing site:">
-<!ENTITY siteDirList.tooltip      "Choose or enter the name of the remote subdirectory to publish to">
-<!ENTITY docDirList.label         "Site subdirectory for this page:">
-<!ENTITY publishImgCheckbox.label "Include images and other files">
-<!ENTITY publishImgCheckbox.tooltip "Publish images and other files referenced by this page">
-<!ENTITY sameLocationRadio.label  "Use same location as page">
-<!ENTITY sameLocationRadio.tooltip "Publish files to the same location as the page">
-<!ENTITY useSubdirRadio.label     "Use this site subdirectory:">
-<!ENTITY useSubdir.tooltip        "Choose or enter name of remote subdirectory where files will be published">
-<!ENTITY chooseDirButton.label    "Choose...">
-<!ENTITY pageTitle.label          "Page Title:">
-<!ENTITY pageTitle.tooltip        "Enter a title to identify the page in the window and in bookmarks">
-<!ENTITY pageTitleExample.label   "e.g.: &quot;My Web Page&quot;">
-<!ENTITY filename.label           "Filename:">
-<!ENTITY filename.tooltip         "Enter a name for this file, including '.html' for a web page">
-<!ENTITY filenameExample.label    "e.g,: &quot;mypage.html&quot;">
-<!ENTITY relatedDocs.label        "Other files to publish">
-<!ENTITY setDefaultButton.label   "Set as Default">
-<!ENTITY setDefSiteAndDir.label   "Set as Default Site and Directory">
-<!ENTITY removeButton.label       "Remove Site">
+<!ENTITY siteList.label               "Site Name:">
+<!ENTITY siteList.accesskey           "e">
+<!ENTITY siteList.tooltip             "Choose the site that you want to publish to">
+<!ENTITY newSiteButton.label          "New Site">
+<!ENTITY newSiteButton.accesskey      "N">
+<!ENTITY docDirList.label             "Site subdirectory for this page:">
+<!ENTITY docDirList.accesskey         "S">
+<!ENTITY docDirList.tooltip           "Choose or enter the name of the remote subdirectory for this page">
+<!ENTITY publishImgCheckbox.label     "Include images and other files">
+<!ENTITY publishImgCheckbox.accesskey "o">
+<!ENTITY publishImgCheckbox.tooltip   "Publish images and other files referenced by this page">
+<!ENTITY sameLocationRadio.label      "Use same location as page">
+<!ENTITY sameLocationRadio.accesskey  "U">
+<!ENTITY sameLocationRadio.tooltip    "Publish files to the same location as the page">
+<!ENTITY useSubdirRadio.label         "Use this site subdirectory:">
+<!ENTITY useSubdirRadio.accesskey     "d">
+<!ENTITY useSubdirRadio.tooltip       "Publish files to the selected remote subdirectory">
+<!ENTITY otherDirList.tooltip         "Choose or enter name of remote subdirectory where files will be published">
+<!ENTITY pageTitle.label              "Page Title:">
+<!ENTITY pageTitle.accesskey          "T">
+<!ENTITY pageTitle.tooltip            "Enter a title to identify the page in the window and in bookmarks">
+<!ENTITY pageTitleExample.label       "e.g.: &quot;My Web Page&quot;">
+<!ENTITY filename.label               "Filename:">
+<!ENTITY filename.accesskey           "F">
+<!ENTITY filename.tooltip             "Enter a name for this file, including '.html' for a web page">
+<!ENTITY filenameExample.label        "e.g,: &quot;mypage.html&quot;">
+<!ENTITY relatedDocs.label            "Other files to publish">
+<!ENTITY setDefaultButton.label       "Set as Default">
+<!ENTITY setDefaultButton.accesskey   "D">
+<!ENTITY setDefSiteAndDir.label       "Set as Default Site and Directory">
+<!ENTITY removeButton.label           "Remove Site">
+<!ENTITY removeButton.accesskey       "R">
 
 <!-- Settings Tab Panel -->
-<!ENTITY publishSites.label   "Publishing Sites">
-<!ENTITY serverInfo.label     "Server Information">
-<!ENTITY loginInfo.label      "Login Information">
-<!ENTITY siteName.label       "Site Name:">
-<!ENTITY siteName.tooltip     "A nickname that identifies this publishing site (e.g.: 'MySite')">
-<!ENTITY siteUrl.label        "Publishing address (e.g.: 'ftp://ftp.myisp.com/myusername'):">
-<!ENTITY siteUrl.tooltip      "The FTP:// or HTTP:// address provided by your ISP or web hosting service">
-<!ENTITY browseUrl.label      "HTTP address of your homepage (e.g.: 'http://www.myisp.com/myusername'):">
-<!ENTITY browseUrl.tooltip    "The HTTP:// address of your home directory (don't include filename)">
-<!ENTITY username.label       "User name:">
-<!ENTITY username.tooltip     "The user name you use to log in to your ISP or web hosting service">
-<!ENTITY password.label       "Password:">
-<!ENTITY password.tooltip     "The password associated with your user name">
-<!ENTITY savePassword.label   "Save Password">
-<!ENTITY savePassword.tooltip "Select this to save your password securely using Password Manager">
+<!ENTITY publishSites.label           "Publishing Sites">
+<!ENTITY serverInfo.label             "Server Information">
+<!ENTITY loginInfo.label              "Login Information">
+<!ENTITY siteName.label               "Site Name:">
+<!ENTITY siteName.accesskey           "e">
+<!ENTITY siteName.tooltip             "A nickname that identifies this publishing site (e.g.: 'MySite')">
+<!ENTITY siteUrl.label                "Publishing address (e.g.: 'ftp://ftp.myisp.com/myusername'):">
+<!ENTITY siteUrl.accesskey            "a">
+<!ENTITY siteUrl.tooltip              "The FTP:// or HTTP:// address provided by your ISP or web hosting service">
+<!ENTITY browseUrl.label              "HTTP address of your homepage (e.g.: 'http://www.myisp.com/myusername'):">
+<!ENTITY browseUrl.accesskey          "T">
+<!ENTITY browseUrl.tooltip            "The HTTP:// address of your home directory (don't include filename)">
+<!ENTITY username.label               "User name:">
+<!ENTITY username.accesskey           "U">
+<!ENTITY username.tooltip             "The user name you use to log in to your ISP or web hosting service">
+<!ENTITY password.label               "Password:">
+<!ENTITY password.accesskey           "w">
+<!ENTITY password.tooltip             "The password associated with your user name">
+<!ENTITY savePassword.label           "Save Password">
+<!ENTITY savePassword.accesskey       "S">
+<!ENTITY savePassword.tooltip         "Select this to save your password securely using Password Manager">