From d15bd0078d563b9a808acef5bac314269e229732 Mon Sep 17 00:00:00 2001 From: Andrew McCreight Date: Tue, 7 Nov 2023 18:27:13 +0000 Subject: [PATCH] Bug 1859530 - Remove unused HangMonitorParent fields. r=gsvelto mBrowserCrashDumpIds and mBrowserCrashDumpHashLock were used to record NPAPI plugin hangs, but that code is long gone. Differential Revision: https://phabricator.services.mozilla.com/D192964 --- dom/ipc/ProcessHangMonitor.cpp | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/dom/ipc/ProcessHangMonitor.cpp b/dom/ipc/ProcessHangMonitor.cpp index fd2c63d0c723..13703991e684 100644 --- a/dom/ipc/ProcessHangMonitor.cpp +++ b/dom/ipc/ProcessHangMonitor.cpp @@ -300,7 +300,7 @@ class HangMonitorParent : public PProcessHangMonitorParent { bool IsOnThread() { return mHangMonitor->IsOnThread(); } private: - ~HangMonitorParent() override; + ~HangMonitorParent() override = default; void SendHangNotification(const SlowScriptData& aSlowScriptData, const nsString& aBrowserDumpId); @@ -331,11 +331,6 @@ class HangMonitorParent : public PProcessHangMonitorParent { // Must be accessed with mMonitor held. bool mShutdownDone MOZ_GUARDED_BY(mMonitor); - // Map from plugin ID to crash dump ID. Protected by - // mBrowserCrashDumpHashLock. - nsTHashMap mBrowserCrashDumpIds - MOZ_GUARDED_BY(mMonitor); - Mutex mBrowserCrashDumpHashLock MOZ_GUARDED_BY(mMonitor); mozilla::ipc::TaskFactory mMainThreadTaskFactory MOZ_GUARDED_BY(mMonitor); }; @@ -791,21 +786,10 @@ HangMonitorParent::HangMonitorParent(ProcessHangMonitor* aMonitor) mIPCOpen(true), mMonitor("HangMonitorParent lock"), mShutdownDone(false), - mBrowserCrashDumpHashLock("mBrowserCrashDumpIds lock"), mMainThreadTaskFactory(this) { MOZ_RELEASE_ASSERT(NS_IsMainThread()); } -HangMonitorParent::~HangMonitorParent() { - MutexAutoLock lock(mBrowserCrashDumpHashLock); - - for (const auto& crashId : mBrowserCrashDumpIds.Values()) { - if (!crashId.IsEmpty()) { - CrashReporter::DeleteMinidumpFilesForID(crashId); - } - } -} - void HangMonitorParent::Shutdown() { MOZ_RELEASE_ASSERT(NS_IsMainThread());