From d1d87025a15ab340e59fa711d10ebaf22fff52ab Mon Sep 17 00:00:00 2001 From: Ryan VanderMeulen Date: Tue, 19 Nov 2024 22:12:49 +0000 Subject: [PATCH] Bug 1932247 - Fix some IgnoreWithoutReason lint warnings. r=geckoview-reviewers,ohall Differential Revision: https://phabricator.services.mozilla.com/D229543 --- .../java/org/mozilla/geckoview/test/NavigationDelegateTest.kt | 3 +-- .../java/org/mozilla/geckoview/test/ProgressDelegateTest.kt | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/NavigationDelegateTest.kt b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/NavigationDelegateTest.kt index 1c3454284ae8..dabbc006d19b 100644 --- a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/NavigationDelegateTest.kt +++ b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/NavigationDelegateTest.kt @@ -783,8 +783,7 @@ class NavigationDelegateTest : BaseSessionTest() { } @Setting(key = Setting.Key.USE_TRACKING_PROTECTION, value = "true") - @Ignore - // TODO: Bug 1564373 + @Ignore // Bug 1564373 @Test fun trackingProtection() { val category = ContentBlocking.AntiTracking.TEST diff --git a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/ProgressDelegateTest.kt b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/ProgressDelegateTest.kt index 518db44b3cb6..b465202093e8 100644 --- a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/ProgressDelegateTest.kt +++ b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/ProgressDelegateTest.kt @@ -10,7 +10,6 @@ import androidx.test.filters.MediumTest import junit.framework.TestCase.assertTrue import org.hamcrest.Matchers.* // ktlint-disable no-wildcard-imports import org.junit.Assume.assumeThat -import org.junit.Ignore import org.junit.Test import org.junit.runner.RunWith import org.mozilla.geckoview.GeckoSession @@ -112,7 +111,6 @@ class ProgressDelegateTest : BaseSessionTest() { }) } - @Ignore @Test fun multipleLoads() { mainSession.loadUri(UNKNOWN_HOST_URI)