Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 17:55:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1583269 - Part 3: Update tests after ICU update. r=jwalden

Browse Source 
js/src/tests/jstests.list
- Enable now passing test262 tests.

non262/Intl/RelativeTimeFormat/format.js
- "minute" and "hour" are now supported in 'text' contexts for relative time formatting.
- Also see the now passing test262 tests.

non262/Intl/NumberFormat/currency-sign-accounting.js
non262/Intl/NumberFormat/sign-display.js
- Referenced ICU bug has been fixed in ICU 65.

non262/Intl/NumberFormat/notation-compact-short.js
- 万亿 is preferred over 兆 in mainland China; CLDR sources were updated accordingly.

non262/Intl/NumberFormat/notation-engineering.js
non262/Intl/NumberFormat/notation-scientific.js
- ICU removed "E0" suffix for non-finite numbers in engineering and scientific contexts.

Differential Revision: https://phabricator.services.mozilla.com/D49445

--HG--
extra : moz-landing-system : lando
This commit is contained in:
André Bargull 2019-10-22 08:36:58 +00:00
parent e96ab7f00d
commit d2125e5768
8 changed files with 20 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/src/tests/jstests.list
View File

@ -437,10 +437,6 @@ ignore-flag(--more-compartments) script test262/built-ins/Proxy/construct/return
skip script test262/intl402/DateTimeFormat/numbering-system-calendar-options.js
skip script test262/intl402/NumberFormat/numbering-system-options.js
# https://bugzilla.mozilla.org/show_bug.cgi?id=1570245
skip script test262/intl402/RelativeTimeFormat/prototype/format/en-us-numeric-auto.js
skip script test262/intl402/RelativeTimeFormat/prototype/formatToParts/en-us-numeric-auto.js
# https://bugzilla.mozilla.org/show_bug.cgi?id=1277801
skip script test262/built-ins/Object/prototype/toString/symbol-tag-non-str-builtin.js

2
js/src/tests/non262/Intl/ListFormat/conjunction-long.js
View File

@ -58,7 +58,7 @@ const {Element, Literal} = ListFormatParts;
const list = ["A", "B", "C", "D"];
const testData = {
"ar": [Element("A"), Literal("، "), Element("B"), Literal("، "), Element("C"), Literal("، و"), Element("D")],
"ar": [Element("A"), Literal(" و"), Element("B"), Literal(" و"), Element("C"), Literal(" و"), Element("D")],
"de": [Element("A"), Literal(", "), Element("B"), Literal(", "), Element("C"), Literal(" und "), Element("D")],
"en": [Element("A"), Literal(", "), Element("B"), Literal(", "), Element("C"), Literal(", and "), Element("D")],
"es": [Element("A"), Literal(", "), Element("B"), Literal(", "), Element("C"), Literal(" y "), Element("D")],

3
js/src/tests/non262/Intl/NumberFormat/currency-sign-accounting.js
View File

@ -108,8 +108,7 @@ const testcases = [
{value: -1, string: "($1.00)",
parts: [Literal("("), Currency("$"), Integer("1"), Decimal("."), Fraction("00"), Literal(")")]},
// ICU bug: https://unicode-org.atlassian.net/projects/ICU/issues/ICU-20708
{value: Infinity, string: "$∞", parts: [Currency("$"), Inf("∞")]},
{value: Infinity, string: "+$∞", parts: [PlusSign("+"), Currency("$"), Inf("∞")]},
{value: -Infinity, string: "($∞)", parts: [Literal("("), Currency("$"), Inf("∞"), Literal(")")]},
{value: NaN, string: "$NaN", parts: [Currency("$"), Nan("NaN")]},

10
js/src/tests/non262/Intl/NumberFormat/notation-compact-short.js
View File

@ -120,12 +120,12 @@ const testcases = [
{value: 1000e7, string: "100\u4EBF", parts: [Integer("100"), Compact("\u4EBF")]},
{value: 10000e7, string: "1000\u4EBF", parts: [Integer("1000"), Compact("\u4EBF")]},
{value: 10e11, string: "1\u5146", parts: [Integer("1"), Compact("\u5146")]},
{value: 100e11, string: "10\u5146", parts: [Integer("10"), Compact("\u5146")]},
{value: 1000e11, string: "100\u5146", parts: [Integer("100"), Compact("\u5146")]},
{value: 10000e11, string: "1000\u5146", parts: [Integer("1000"), Compact("\u5146")]},
{value: 10e11, string: "1\u4E07\u4EBF", parts: [Integer("1"), Compact("\u4E07\u4EBF")]},
{value: 100e11, string: "10\u4E07\u4EBF", parts: [Integer("10"), Compact("\u4E07\u4EBF")]},
{value: 1000e11, string: "100\u4E07\u4EBF", parts: [Integer("100"), Compact("\u4E07\u4EBF")]},
{value: 10000e11, string: "1000\u4E07\u4EBF", parts: [Integer("1000"), Compact("\u4E07\u4EBF")]},
{value: 100000e11, string: "10,000\u5146", parts: [Integer("10"), Group(","), Integer("000"), Compact("\u5146")]},
{value: 100000e11, string: "10,000\u4E07\u4EBF", parts: [Integer("10"), Group(","), Integer("000"), Compact("\u4E07\u4EBF")]},
],
},
];

8
js/src/tests/non262/Intl/NumberFormat/notation-engineering.js
View File

@ -40,11 +40,11 @@ const testcases = [
{value: 0.000001, string: "1E-6", parts: [Integer("1"), ExponentSeparator("E"), ExponentMinusSign("-"), ExponentInteger("6")]},
{value: 0.0000001, string: "100E-9", parts: [Integer("100"), ExponentSeparator("E"), ExponentMinusSign("-"), ExponentInteger("9")]},
{value: Infinity, string: "∞E0", parts: [Inf("∞"), ExponentSeparator("E"), ExponentInteger("0")]},
{value: -Infinity, string: "-∞E0", parts: [MinusSign("-"), Inf("∞"), ExponentSeparator("E"), ExponentInteger("0")]},
{value: Infinity, string: "∞", parts: [Inf("∞")]},
{value: -Infinity, string: "-∞", parts: [MinusSign("-"), Inf("∞")]},
{value: NaN, string: "NaNE0", parts: [Nan("NaN"), ExponentSeparator("E"), ExponentInteger("0")]},
{value: -NaN, string: "NaNE0", parts: [Nan("NaN"), ExponentSeparator("E"), ExponentInteger("0")]},
{value: NaN, string: "NaN", parts: [Nan("NaN")]},
{value: -NaN, string: "NaN", parts: [Nan("NaN")]},
],
},

8
js/src/tests/non262/Intl/NumberFormat/notation-scientific.js
View File

@ -40,11 +40,11 @@ const testcases = [
{value: 0.000001, string: "1E-6", parts: [Integer("1"), ExponentSeparator("E"), ExponentMinusSign("-"), ExponentInteger("6")]},
{value: 0.0000001, string: "1E-7", parts: [Integer("1"), ExponentSeparator("E"), ExponentMinusSign("-"), ExponentInteger("7")]},
{value: Infinity, string: "∞E0", parts: [Inf("∞"), ExponentSeparator("E"), ExponentInteger("0")]},
{value: -Infinity, string: "-∞E0", parts: [MinusSign("-"), Inf("∞"), ExponentSeparator("E"), ExponentInteger("0")]},
{value: Infinity, string: "∞", parts: [Inf("∞")]},
{value: -Infinity, string: "-∞", parts: [MinusSign("-"), Inf("∞")]},
{value: NaN, string: "NaNE0", parts: [Nan("NaN"), ExponentSeparator("E"), ExponentInteger("0")]},
{value: -NaN, string: "NaNE0", parts: [Nan("NaN"), ExponentSeparator("E"), ExponentInteger("0")]},
{value: NaN, string: "NaN", parts: [Nan("NaN")]},
{value: -NaN, string: "NaN", parts: [Nan("NaN")]},
],
},

3
js/src/tests/non262/Intl/NumberFormat/sign-display.js
View File

@ -119,8 +119,7 @@ const testcases = [
{value: 0.9, string: "+0.9", parts: [PlusSign("+"), Integer("0"), Decimal("."), Fraction("9")]},
{value: -0.9, string: "-0.9", parts: [MinusSign("-"), Integer("0"), Decimal("."), Fraction("9")]},
// ICU bug: https://unicode-org.atlassian.net/browse/ICU-20708
{value: Infinity, string: "∞", parts: [Inf("∞")]},
{value: Infinity, string: "+∞", parts: [PlusSign("+"), Inf("∞")]},
{value: -Infinity, string: "-∞", parts: [MinusSign("-"), Inf("∞")]},
{value: NaN, string: "NaN", parts: [Nan("NaN")]},

8
js/src/tests/non262/Intl/RelativeTimeFormat/format.js
View File

@ -56,13 +56,13 @@ var rtf;
assertEq(rtf.format(-1, "second"), "1 second ago");
assertEq(rtf.format(1, "second"), "in 1 second");
assertEq(rtf.format(0, "minute"), "in 0 minutes");
assertEq(rtf.format(-0, "minute"), "0 minutes ago");
assertEq(rtf.format(0, "minute"), "this minute");
assertEq(rtf.format(-0, "minute"), "this minute");
assertEq(rtf.format(-1, "minute"), "1 minute ago");
assertEq(rtf.format(1, "minute"), "in 1 minute");
assertEq(rtf.format(0, "hour"), "in 0 hours");
assertEq(rtf.format(-0, "hour"), "0 hours ago");
assertEq(rtf.format(0, "hour"), "this hour");
assertEq(rtf.format(-0, "hour"), "this hour");
assertEq(rtf.format(-1, "hour"), "1 hour ago");
assertEq(rtf.format(1, "hour"), "in 1 hour");