From d32f4a69fff499a9872a9ea3b9b4b4c33446918f Mon Sep 17 00:00:00 2001 From: Jared Wein Date: Wed, 12 Jun 2019 14:44:14 +0000 Subject: [PATCH] Bug 1556965 - Move the scrolling from the login-list element to the OL element inside of the login-list so the header won't be positioned above the list when scrolling. r=MattN This fixes the issue of a translucent header showing the text through. Differential Revision: https://phabricator.services.mozilla.com/D34112 --HG-- extra : moz-landing-system : lando --- browser/components/aboutlogins/content/aboutLogins.css | 2 +- .../components/aboutlogins/content/components/login-list.css | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/browser/components/aboutlogins/content/aboutLogins.css b/browser/components/aboutlogins/content/aboutLogins.css index 07db24076448..1d01aa4227f3 100644 --- a/browser/components/aboutlogins/content/aboutLogins.css +++ b/browser/components/aboutlogins/content/aboutLogins.css @@ -4,7 +4,7 @@ body { display: grid; - grid-template-columns: 280px 1fr; + grid-template-columns: minmax(320px, max-content) 1fr; grid-template-rows: 75px 1fr; grid-template-areas: "header header" "logins login"; diff --git a/browser/components/aboutlogins/content/components/login-list.css b/browser/components/aboutlogins/content/components/login-list.css index 472baad6ec1e..f634976713dd 100644 --- a/browser/components/aboutlogins/content/components/login-list.css +++ b/browser/components/aboutlogins/content/components/login-list.css @@ -5,6 +5,9 @@ :host { border-inline-end: 1px solid var(--in-content-box-border-color); background-color: var(--in-content-box-background); + display: flex; + flex-direction: column; + overflow: auto; } .meta { @@ -28,4 +31,5 @@ ol { margin-top: 0; margin-bottom: 0; padding-inline-start: 0; + overflow: hidden auto; }