Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1488874 - Part 2: Notification channel name changes. r=nalexander

Browse Source 
The media and default channels are changed as per comment 2 of this bug.
I'm keeping the location service string as it is, though, as our settings UI
uses "&vendorShortName; Location Service" as well.

Differential Revision: https://phabricator.services.mozilla.com/D10771

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Jan Henning 2018-11-05 18:54:24 +00:00
parent 11b47ce96d
commit d3a0ac78b6
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mobile/android/base/java/org/mozilla/gecko/notifications/NotificationHelper.java
View File

@ -242,7 +242,7 @@ public final class NotificationHelper implements BundleEventListener {
case MEDIA: {
channel = new NotificationChannel(mDefinedNotificationChannels.get(definedChannel),
mContext.getString(R.string.media_notification_channel),
mContext.getString(R.string.media_notification_channel2),
NotificationManager.IMPORTANCE_LOW);
}
break;
@ -263,7 +263,7 @@ public final class NotificationHelper implements BundleEventListener {
case LP_DEFAULT: {
channel = new NotificationChannel(mDefinedNotificationChannels.get(definedChannel),
mContext.getString(R.string.leanplum_default_notifications_channel),
mContext.getString(R.string.leanplum_default_notifications_channel2),
NotificationManager.IMPORTANCE_LOW);
}
break;
@ -278,7 +278,7 @@ public final class NotificationHelper implements BundleEventListener {
case DEFAULT:
default: {
channel = new NotificationChannel(mDefinedNotificationChannels.get(definedChannel),
mContext.getString(R.string.default_notification_channel),
mContext.getString(R.string.default_notification_channel2),
NotificationManager.IMPORTANCE_LOW);
}
break;

6
mobile/android/base/locales/en-US/android_strings.dtd
View File

@ -897,12 +897,12 @@ Picture-in-picture mini window -->
<!ENTITY pip_pause_button_description "Pause playing">
<!-- Notification channels names -->
<!ENTITY default_notification_channel "&brandShortName;">
<!ENTITY default_notification_channel2 "Browser">
<!ENTITY mls_notification_channel "&vendorShortName; Location Service">
<!ENTITY download_notification_channel "Downloads">
<!ENTITY media_notification_channel "Media playback">
<!ENTITY media_notification_channel2 "Sound and video">
<!-- These push notifications come without a specific channel and/or name from Leanplum -->
<!ENTITY leanplum_default_notifications_channel "&brandShortName; Push notifications">
<!ENTITY leanplum_default_notifications_channel2 "&vendorShortName; tips and tricks">
<!ENTITY updater_notification_channel "App updates">
<!ENTITY synced_tabs_notification_channel "Synced tabs">
<!-- LOCALIZATION NOTE (site_notifications_channel): This is for system notifications displayed by

6
mobile/android/base/strings.xml.in
View File

@ -647,11 +647,11 @@
<string name="pip_pause_button_title">&pip_pause_button_title;</string>
<string name="pip_pause_button_description">&pip_pause_button_description;</string>
<string name="default_notification_channel">&default_notification_channel;</string>
<string name="default_notification_channel2">&default_notification_channel2;</string>
<string name="mls_notification_channel">&mls_notification_channel;</string>
<string name="media_notification_channel">&media_notification_channel;</string>
<string name="media_notification_channel2">&media_notification_channel2;</string>
<string name="download_notification_channel">&download_notification_channel;</string>
<string name="leanplum_default_notifications_channel">&leanplum_default_notifications_channel;</string>
<string name="leanplum_default_notifications_channel2">&leanplum_default_notifications_channel2;</string>
<string name="updater_notification_channel">&updater_notification_channel;</string>
<string name="synced_tabs_notification_channel">&synced_tabs_notification_channel;</string>
<string name="site_notifications_channel">&site_notifications_channel;</string>