Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 12:51:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1879503 - Do not send third-party cookies when it's not allowed by preferences. r=webdriver-reviewers,whimboo

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D205081
This commit is contained in:
Alexandra Borovova 2024-04-10 08:22:35 +00:00
parent 4cef601970
commit d3b7dd8c5c
1 changed files with 101 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

137
remote/webdriver-bidi/modules/root/storage.sys.mjs
View File

@ -16,6 +16,15 @@ ChromeUtils.defineESModuleGetters(lazy, {
"chrome://remote/content/shared/UserContextManager.sys.mjs",
});
const PREF_COOKIE_BEHAVIOR = "network.cookie.cookieBehavior";
const PREF_COOKIE_OPTIN_PARTITIONING =
"network.cookie.cookieBehavior.optInPartitioning";
// This is a static preference, so it cannot be modified during runtime and we can cache its value.
ChromeUtils.defineLazyGetter(lazy, "cookieBehaviorOptInPartitioning", () =>
Services.prefs.getBoolPref(PREF_COOKIE_OPTIN_PARTITIONING)
);
const CookieFieldsMapping = {
domain: "host",
expiry: "expiry",
@ -603,10 +612,22 @@ class StorageModule extends Module {
if (partitionSpec.type === PartitionType.Context) {
const { context: contextId } = partitionSpec;
const browsingContext = this.#getBrowsingContext(contextId);
const principal = Services.scriptSecurityManager.createContentPrincipal(
browsingContext.currentURI,
{}
);
// Define browsing context’s associated storage partition as combination of user context id
// and the origin of the document in this browsing context.
// and the origin of the document in this browsing context. We also add here `isThirdPartyURI`
// which is required to filter out third-party cookies in case they are not allowed.
return {
// In case we have the browsing context of an iframe here, we perform a check
// if the URI of the top context is considered third-party to the URI of the iframe principal.
// It's considered a third-party if base domains or hosts (in case one or both base domains
// can not be determined) do not match.
isThirdPartyURI: browsingContext.parent
? principal.isThirdPartyURI(browsingContext.top.currentURI)
: false,
sourceOrigin: browsingContext.currentURI.prePath,
userContext: browsingContext.originAttributes.userContextId,
};
@ -640,6 +661,9 @@ class StorageModule extends Module {
);
}
// This key is not used for partitioning and was required to only filter out third-party cookies.
delete partitionKey.isThirdPartyURI;
return partitionKey;
}
@ -742,43 +766,60 @@ class StorageModule extends Module {
// Prepare the data in the format required for the platform API.
const originAttributes = this.#getOriginAttributes(storagePartitionKey);
// In case we want to get the cookies for a certain `sourceOrigin`,
// we have to separately retrieve cookies for a hostname built from `sourceOrigin`,
// and with `partitionKey` equal an empty string to retrieve the cookies that which were set
// by this hostname but without `partitionKey`, e.g. with `document.cookie`.
if (storagePartitionKey.sourceOrigin) {
const url = new URL(storagePartitionKey.sourceOrigin);
const hostname = url.hostname;
const principal = Services.scriptSecurityManager.createContentPrincipal(
Services.io.newURI(url),
{}
);
const isSecureProtocol = principal.isOriginPotentiallyTrustworthy;
// We want to keep `userContext` id here, if it's present,
// but set the `partitionKey` to an empty string.
const cookiesMatchingHostname =
Services.cookies.getCookiesWithOriginAttributes(
JSON.stringify({ ...originAttributes, partitionKey: "" }),
hostname
);
for (const cookie of cookiesMatchingHostname) {
// Ignore secure cookies for non-secure protocols.
if (cookie.isSecure && !isSecureProtocol) {
continue;
}
store.push(cookie);
}
}
// Add the cookies which exactly match a built partition attributes.
store = store.concat(
// Retrieve the cookies which exactly match a built partition attributes.
const cookiesWithOriginAttributes =
Services.cookies.getCookiesWithOriginAttributes(
JSON.stringify(originAttributes)
)
);
);
const isFirstPartyOrCrossSiteAllowed =
!storagePartitionKey.isThirdPartyURI ||
this.#shouldIncludeCrossSiteCookie();
// Check if we accessing the first party storage or cross-site cookies are allowed.
if (isFirstPartyOrCrossSiteAllowed) {
// In case we want to get the cookies for a certain `sourceOrigin`,
// we have to separately retrieve cookies for a hostname built from `sourceOrigin`,
// and with `partitionKey` equal an empty string to retrieve the cookies that which were set
// by this hostname but without `partitionKey`, e.g. with `document.cookie`.
if (storagePartitionKey.sourceOrigin) {
const url = new URL(storagePartitionKey.sourceOrigin);
const hostname = url.hostname;
const principal = Services.scriptSecurityManager.createContentPrincipal(
Services.io.newURI(url),
{}
);
const isSecureProtocol = principal.isOriginPotentiallyTrustworthy;
// We want to keep `userContext` id here, if it's present,
// but set the `partitionKey` to an empty string.
const cookiesMatchingHostname =
Services.cookies.getCookiesWithOriginAttributes(
JSON.stringify({ ...originAttributes, partitionKey: "" }),
hostname
);
for (const cookie of cookiesMatchingHostname) {
// Ignore secure cookies for non-secure protocols.
if (cookie.isSecure && !isSecureProtocol) {
continue;
}
store.push(cookie);
}
}
store = store.concat(cookiesWithOriginAttributes);
}
// If we're trying to access the store in the third party context and
// the preferences imply that we shouldn't include cross site cookies,
// but we should include partitioned cookies, add only partitioned cookies.
else if (this.#shouldIncludePartitionedCookies()) {
for (const cookie of cookiesWithOriginAttributes) {
if (cookie.isPartitioned) {
store.push(cookie);
}
}
}
return store;
}
@ -856,6 +897,30 @@ class StorageModule extends Module {
return cookie;
}
#shouldIncludeCrossSiteCookie() {
const cookieBehavior = Services.prefs.getIntPref(PREF_COOKIE_BEHAVIOR);
if (
cookieBehavior === Ci.nsICookieService.BEHAVIOR_REJECT_FOREIGN ||
cookieBehavior ===
Ci.nsICookieService.BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN
) {
return false;
}
return true;
}
#shouldIncludePartitionedCookies() {
const cookieBehavior = Services.prefs.getIntPref(PREF_COOKIE_BEHAVIOR);
return (
cookieBehavior ===
Ci.nsICookieService.BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN &&
lazy.cookieBehaviorOptInPartitioning
);
}
}
export const storage = StorageModule;