Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-13 05:15:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1315885 - Part 3: Transfer the ownership of ReactionQueue's entry due to re-enter CustomElementReactionsStack::InvokeReactions. r=wchen

Browse Source 
MozReview-Commit-ID: 9Ku4jnuV9o3

--HG--
extra : rebase_source : 2d20a838d2f9362df5c77c43808f3d11aec3c920
This commit is contained in:
John Dai 2017-07-10 16:33:16 +08:00
parent 8da9589387
commit d42ab7cdaa
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
dom/base/CustomElementRegistry.cpp
View File

@ -988,6 +988,7 @@ CustomElementReactionsStack::InvokeBackupQueue()
void void
CustomElementReactionsStack::InvokeReactions(ElementQueue& aElementQueue) CustomElementReactionsStack::InvokeReactions(ElementQueue& aElementQueue)
{ {
// Note: It's possible to re-enter this method.
for (uint32_t i = 0; i < aElementQueue.Length(); ++i) { for (uint32_t i = 0; i < aElementQueue.Length(); ++i) {
nsCOMPtr<Element> element = do_QueryReferent(aElementQueue[i]); nsCOMPtr<Element> element = do_QueryReferent(aElementQueue[i]);
@ -998,10 +999,14 @@ CustomElementReactionsStack::InvokeReactions(ElementQueue& aElementQueue)
RefPtr<CustomElementData> elementData = element->GetCustomElementData(); RefPtr<CustomElementData> elementData = element->GetCustomElementData();
MOZ_ASSERT(elementData, "CustomElementData should exist"); MOZ_ASSERT(elementData, "CustomElementData should exist");
nsTArray<nsAutoPtr<CustomElementReaction>>& reactions = auto& reactions = elementData->mReactionQueue;
elementData->mReactionQueue;
for (uint32_t j = 0; j < reactions.Length(); ++j) { for (uint32_t j = 0; j < reactions.Length(); ++j) {
reactions.ElementAt(j)->Invoke(element); // Transfer the ownership of the entry due to reentrant invocation of
// this funciton. The entry will be removed when bug 1379573 is landed.
auto reaction(Move(reactions.ElementAt(j)));
if (reaction) {
reaction->Invoke(element);
}
} }
reactions.Clear(); reactions.Clear();
} }